NetBSD Problem Report #48024

From tsutsui@ceres.dti.ne.jp  Sat Jul  6 10:41:33 2013
Return-Path: <tsutsui@ceres.dti.ne.jp>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id A83C1718B2
	for <gnats-bugs@gnats.NetBSD.org>; Sat,  6 Jul 2013 10:41:33 +0000 (UTC)
Message-Id: <201307061041.r66AfTqs000764@mirage.localdomain>
Date: Sat, 6 Jul 2013 19:41:29 +0900 (JST)
From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
Reply-To: tsutsui@ceres.dti.ne.jp
To: gnats-bugs@gnats.NetBSD.org
Cc: tsutsui@ceres.dti.ne.jp
Subject: PKG_OPTIONS.gtk2=-py-numpy doesn't work as expected
X-Send-Pr-Version: 3.95

>Number:         48024
>Category:       pkg
>Synopsis:       PKG_OPTIONS.py-gtk2=-py-numpy doesn't work as expected
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Jul 06 10:45:00 +0000 2013
>Closed-Date:    Sat Jul 10 14:40:24 +0000 2021
>Last-Modified:  Sat Jul 10 14:40:24 +0000 2021
>Originator:     Izumi Tsutsui
>Release:        NetBSD 6.1 + pkgsrc-2013Q2 updated around 201307060200Z
>Organization:
>Environment:
System: NetBSD 6.1 (MIRAGE)
Architecture: i386
Machine: i386
>Description:
pkgsrc/x11/py-gtk2 has an option py-numpy to disable fortran mess
but x11/py-gtk2/buildlink3.mk doesn't check the option
so build with PKG_OPTIONS.py-gtk2=-py-numpy fails on
packages that depend on py-gtk2.

>How-To-Repeat:
$ export PKG_OPTIONS.gtk2=-py-numpy
$ cd pkgsrc/sysutils/py-notify-python
$ make package

 :

===> Creating toolchain wrappers for py27-notify-python-0.1.1nb20
ERROR: py-27-numpy>=1.0 is not installed; can't buildlink files.
*** Error code 1

>Fix:
Check options rather than platforms in buildlink3.mk?
(not sure if options.mk should explicitly included or not)

Index: buildlink3.mk
===================================================================
RCS file: /cvsroot/pkgsrc/x11/py-gtk2/buildlink3.mk,v
retrieving revision 1.46
diff -u -p -r1.46 buildlink3.mk
--- buildlink3.mk	6 Jun 2013 12:53:56 -0000	1.46
+++ buildlink3.mk	6 Jul 2013 10:38:55 -0000
@@ -6,6 +6,7 @@ BUILDLINK_TREE+=	pygtk2
 PYGTK2_BUILDLINK3_MK:=

 .include "../../lang/python/pyversion.mk"
+.include "../../mk/pkg-build-options.mk"

 BUILDLINK_API_DEPENDS.pygtk2+=	${PYPKGPREFIX}-gtk2>=2.8.4
 BUILDLINK_ABI_DEPENDS.pygtk2+=	${PYPKGPREFIX}-gtk2>=2.24.0nb13
@@ -13,10 +14,7 @@ BUILDLINK_PKGSRCDIR.pygtk2?=	../../x11/p

 .include "../../devel/py-gobject/buildlink3.mk"
 .include "../../devel/libglade/buildlink3.mk"
-.if (!empty(MACHINE_ARCH:Mi386) || !empty(MACHINE_ARCH:Mx86_64) || \
-	!empty(MACHINE_ARCH:Mia64) || !empty(MACHINE_ARCH:Mpowerpc*) || \
-	!empty(MACHINE_ARCH:Mhppa) || !empty(MACHINE_ARCH:Msparc*) || \
-	!empty(MACHINE_ARCH:Malpha) || !empty(MACHINE_ARCH:Mmips*))
+.if !empty(PKG_OPTIONS:Mpy-numpy)
 .include "../../math/py-numpy/buildlink3.mk"
 .endif
 .include "../../x11/gtk2/buildlink3.mk"

>Release-Note:

>Audit-Trail:

From: "Izumi Tsutsui" <tsutsui@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/48024 CVS commit: pkgsrc/x11/py-gtk2
Date: Tue, 9 Jul 2013 14:13:30 +0000

 Module Name:	pkgsrc
 Committed By:	tsutsui
 Date:		Tue Jul  9 14:13:30 UTC 2013

 Modified Files:
 	pkgsrc/x11/py-gtk2: buildlink3.mk

 Log Message:
 Handle PKG_OPTIONS.py-gtk2=-py-numpy properly in buildlink3.mk.  PR/48024


 To generate a diff of this commit:
 cvs rdiff -u -r1.46 -r1.47 pkgsrc/x11/py-gtk2/buildlink3.mk

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "OBATA Akio" <obache@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/48024 CVS commit: pkgsrc/x11/py-gtk2
Date: Mon, 15 Jul 2013 03:26:51 +0000

 Module Name:	pkgsrc
 Committed By:	obache
 Date:		Mon Jul 15 03:26:51 UTC 2013

 Modified Files:
 	pkgsrc/x11/py-gtk2: buildlink3.mk

 Log Message:
 PKGBASE name must be set as pkgbase for PKG_BUILD_OPTIONS.
 PR pkg/48024 should be finally resolved.


 To generate a diff of this commit:
 cvs rdiff -u -r1.48 -r1.49 pkgsrc/x11/py-gtk2/buildlink3.mk

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->feedback
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sat, 03 Aug 2013 22:18:58 +0000
State-Changed-Why:
Fixed?


State-Changed-From-To: feedback->open
State-Changed-By: obache@NetBSD.org
State-Changed-When: Sun, 04 Aug 2013 01:26:20 +0000
State-Changed-Why:
pkg-build-options.mk cannot handle correctly yet for the case
pkgbase != ${PKGBASE}


State-Changed-From-To: open->closed
State-Changed-By: tsutsui@NetBSD.org
State-Changed-When: Sat, 10 Jul 2021 14:40:24 +0000
State-Changed-Why:
I no longer used py-gtk2 even on dependencies and py-numpy has been disabled
by default. If pkg-build-options.mk still has a problem, it should be handled
in an independent PR.


>Unformatted:

Home	PR Database Search