NetBSD Problem Report #48482

From hauke@Espresso.Rhein-Neckar.DE  Sat Dec 28 18:27:08 2013
Return-Path: <hauke@Espresso.Rhein-Neckar.DE>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "Postmaster NetBSD.org" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 1DEFBA566B
	for <gnats-bugs@gnats.NetBSD.org>; Sat, 28 Dec 2013 18:27:08 +0000 (UTC)
Message-Id: <201312281758.rBSHwNOG022793@pizza.causeuse.org>
Date: Sat, 28 Dec 2013 18:58:23 +0100 (CET)
From: Hauke Fath <hauke@Espresso.Rhein-Neckar.DE>
Reply-To: Hauke Fath <hauke@Espresso.Rhein-Neckar.DE>
To: gnats-bugs@gnats.NetBSD.org
Cc: Hauke Fath <hauke@Espresso.Rhein-Neckar.DE>
Subject: lang/f2c does not build
X-Send-Pr-Version: 3.95

>Number:         48482
>Category:       pkg
>Synopsis:       lang/f2c does not build
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    dmcmahill
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Dec 28 18:30:00 +0000 2013
>Closed-Date:    Tue Nov 20 09:38:56 +0000 2018
>Last-Modified:  Tue Nov 20 09:40:00 +0000 2018
>Originator:     Hauke Fath
>Release:        NetBSD 6.1_STABLE
>Organization:
Falling Raindrops
>Environment:


System: NetBSD pizza.causeuse.org 6.1_STABLE NetBSD 6.1_STABLE (BLACKBOX-$Revision: 1.85 $) #0: Tue Nov 19 00:33:07 CET 2013 hauke@pizza.causeuse.org:/var/obj/netbsd-builds/6/amd64/sys/arch/amd64/compile/BLACKBOX amd64
Architecture: x86_64
Machine: amd64
>Description:

	The build of lang/f2c fails with

#   compile  src/main.o
gcc -O2 -pipe -Wall -Wno-error  -std=gnu99 -Werror   -I. -I.  -c    main.c
cc1: warnings being treated as errors
main.c: In function 'write_typedefs':
main.c:363:3: error: suggest parentheses around assignment used as truth value
main.c:380:3: error: array subscript has type 'char'
main.c:384:5: error: array subscript has type 'char'
main.c: In function 'commonprotos':
main.c:419:7: error: suggest parentheses around assignment used as truth value
main.c:417:6: error: suggest explicit braces to avoid ambiguous 'else'
main.c: In function 'I_args':
main.c:471:5: error: suggest parentheses around '&&' within '||'
main.c: In function 'omit_non_f':
main.c:489:2: error: suggest parentheses around assignment used as truth value
main.c: In function 'main':
main.c:653:2: error: suggest parentheses around assignment used as truth value
main.c: In function 'opf':
main.c:747:2: error: suggest parentheses around assignment used as truth value
*** Error code 1

Stop.
make: stopped in /var/obj/pkgsrc/lang/f2c/work/f2c/src
*** Error code 1

>How-To-Repeat:

	Try to build it - watch it fail on the first file.

>Fix:
	Add the suggested parentheses? Update the package?

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->dmcmahill
Responsible-Changed-By: hauke@NetBSD.org
Responsible-Changed-When: Sat, 28 Dec 2013 19:54:14 +0000
Responsible-Changed-Why:
Over to maintainer.


State-Changed-From-To: open->closed
State-Changed-By: maya@NetBSD.org
State-Changed-When: Tue, 20 Nov 2018 09:38:56 +0000
State-Changed-Why:
should be fixed, I don't like to request people feedback for their 5 y/o setup, I assume you don't want to replicate it.


From: "Maya Rashish" <maya@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/48482 CVS commit: pkgsrc/lang/f2c
Date: Tue, 20 Nov 2018 09:38:26 +0000

 Module Name:	pkgsrc
 Committed By:	maya
 Date:		Tue Nov 20 09:38:26 UTC 2018

 Modified Files:
 	pkgsrc/lang/f2c: Makefile

 Log Message:
 f2c: strip -Werror for everyone. It's unsuitable for a release, and it
 isn't an upstream choice, but is likely a result of using bsd.prog.mk in
 files/

 At least one person had an issue with it, although it (mysteriously) builds
 fine with GCC 6.5 and -Werror, even now.

 PR pkg/48482


 To generate a diff of this commit:
 cvs rdiff -u -r1.65 -r1.66 pkgsrc/lang/f2c/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search