NetBSD Problem Report #48566
From www@NetBSD.org Sun Feb 2 17:38:18 2014
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
(Client CN "mail.NetBSD.org", Issuer "Postmaster NetBSD.org" (not verified))
by mollari.NetBSD.org (Postfix) with ESMTPS id 6B70FA645E
for <gnats-bugs@gnats.NetBSD.org>; Sun, 2 Feb 2014 17:38:18 +0000 (UTC)
Message-Id: <20140202173817.25806A64B0@mollari.NetBSD.org>
Date: Sun, 2 Feb 2014 17:38:17 +0000 (UTC)
From: manu@netbsd.org
Reply-To: manu@netbsd.org
To: gnats-bugs@NetBSD.org
Subject: getpwnam() fix and ECDH for sendmail from upstream
X-Send-Pr-Version: www-1.0
>Number: 48566
>Category: pkg
>Synopsis: getpwnam() fix and ECDH for sendmail from upstream
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: jnemeth
>State: closed
>Class: change-request
>Submitter-Id: net
>Arrival-Date: Sun Feb 02 17:40:00 +0000 2014
>Closed-Date: Wed Jun 25 15:34:28 +0000 2014
>Last-Modified: Wed Jun 25 15:34:28 +0000 2014
>Originator: Emmanuel Dreyfus
>Release: NetBSD 6.1.2
>Organization:
>Environment:
NetBSD lego 6.1.2 NetBSD 6.1.2 (XEN3_DOMU) amd64
>Description:
I would like to have two patches from upstream available in pkgsrc. The
pkgsrc change is here:
http://ftp.espci.fr/shadow/manu/sendmail.patch
We have the ffr_tls_ec option to enable ECDH, which I already proposed
before. This helps a lot of clients negociating with PFS enabled.
I recall we talk about enabling it uncondtionnaly with ffr_tls_1. I can
do that if it is confirmed to be the way to go. But please note it
changes the default behavior, as OpenSSL sets a high priority by default
on ECDH ciphers, which tend to be picked first if they are available.
They can be disabled with an appropriate O CipherList setting in
sendmail.cf, though.
Next, we have the getpwnam patch, which fixes a long standing bug in
sendmail, where an unreachable LDAP directory can cause a mail to be
rejected just like if there was aun unknown sender.
>How-To-Repeat:
>Fix:
Just commit it:
http://ftp.espci.fr/shadow/manu/sendmail.patch
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: pkg-manager->jnemeth
Responsible-Changed-By: manu@NetBSD.org
Responsible-Changed-When: Sun, 02 Feb 2014 17:45:05 +0000
Responsible-Changed-Why:
Responsible asked for the PR
From: manu@netbsd.org (Emmanuel Dreyfus)
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: pkg/48566: getpwnam() fix and ECDH for sendmail from upstream
Date: Tue, 25 Feb 2014 13:35:15 +0100
Updated patch with missing file:
http://ftp.espci.fr/shadow/manu/sendmail2.patch
--
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
manu@netbsd.org
From: Emmanuel Dreyfus <manu@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: pkg/48566: getpwnam() fix and ECDH for sendmail from upstream
Date: Wed, 26 Feb 2014 16:22:10 +0000
--Bn2rw/3z4jIqBvZU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Here is the updated patch for -current pkgsrc:
--
Emmanuel Dreyfus
manu@netbsd.org
--Bn2rw/3z4jIqBvZU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="sendmail3.patch"
? mail/sendmail/files/site.config.m4-ffr_tls_ec
Index: mail/sendmail/Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/mail/sendmail/Makefile,v
retrieving revision 1.119
diff -U4 -r1.119 Makefile
--- mail/sendmail/Makefile 12 Feb 2014 23:18:09 -0000 1.119
+++ mail/sendmail/Makefile 26 Feb 2014 16:17:43 -0000
@@ -1,8 +1,8 @@
# $NetBSD: Makefile,v 1.119 2014/02/12 23:18:09 tron Exp $
PKGNAME= sendmail-${DIST_VERS}
-PKGREVISION= 1
+PKGREVISION= 2
COMMENT= The well known Mail Transport Agent
CONFLICTS+= courier-mta-[0-9]* fastforward>=0.51nb2 postfix-[0-9]*
CONFLICTS+= esmtp>=1.2
@@ -69,8 +69,11 @@
.endif
.if !empty(PKG_OPTIONS:Mffr_tls_1)
cat ${FILESDIR}/site.config.m4-ffr_tls_1 >>${SITECONFIG}
.endif
+.if !empty(PKG_OPTIONS:Mffr_tls_ec)
+ cat ${FILESDIR}/site.config.m4-ffr_tls_ec >>${SITECONFIG}
+.endif
.if !empty(PKG_OPTIONS:Msasl)
cat ${FILESDIR}/site.config.m4-sasl2 >>${SITECONFIG}
.endif
Index: mail/sendmail/options.mk
===================================================================
RCS file: /cvsroot/pkgsrc/mail/sendmail/options.mk,v
retrieving revision 1.20
diff -U4 -r1.20 options.mk
--- mail/sendmail/options.mk 19 Sep 2013 10:54:05 -0000 1.20
+++ mail/sendmail/options.mk 26 Feb 2014 16:17:43 -0000
@@ -1,8 +1,9 @@
# $NetBSD: options.mk,v 1.20 2013/09/19 10:54:05 manu Exp $
PKG_OPTIONS_VAR= PKG_OPTIONS.sendmail
PKG_SUPPORTED_OPTIONS= inet6 db2 ldap sasl tls tcpwrappers ffr_tls_1
+PKG_SUPPORTED_OPTIONS+= ffr_tls_ec
PKG_SUGGESTED_OPTIONS= inet6 tcpwrappers
PKG_OPTIONS_LEGACY_OPTS+= starttls:tls
Index: mail/sendmail/files/site.config.m4
===================================================================
RCS file: /cvsroot/pkgsrc/mail/sendmail/files/site.config.m4,v
retrieving revision 1.10
diff -U4 -r1.10 site.config.m4
--- mail/sendmail/files/site.config.m4 16 Dec 2009 09:46:36 -0000 1.10
+++ mail/sendmail/files/site.config.m4 26 Feb 2014 16:17:43 -0000
@@ -34,4 +34,7 @@
# XXX all supported systems should support poll(2), if one is discovered
# that doesn't, we can revisit this
APPENDDEF(`conf_libmilter_ENVDEF', `-DSM_CONF_POLL=1')
+# See patches/patch-getpwnam
+APPENDDEF(`confENVDEF', `-D_FFR_USE_GETPWNAM_ERRNO=1')
+
--- /dev/null 2014-02-26 17:15:02.000000000 +0100
+++ mail/sendmail/files/site.config.m4-ffr_tls_ec 2014-02-26 17:06:02.000000000 +0100
@@ -0,0 +1,5 @@
+# $NetBSD$
+
+# enable _FFR_TLS_EC
+APPENDDEF(`conf_sendmail_ENVDEF', `-D_FFR_TLS_EC')
+
--Bn2rw/3z4jIqBvZU--
From: "John Nemeth" <jnemeth@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/48566 CVS commit: pkgsrc/mail/sendmail
Date: Sun, 15 Jun 2014 20:48:50 +0000
Module Name: pkgsrc
Committed By: jnemeth
Date: Sun Jun 15 20:48:50 UTC 2014
Modified Files:
pkgsrc/mail/sendmail: Makefile Makefile.common PLIST distinfo
options.mk
pkgsrc/mail/sendmail/files: sendmail.sh site.config.m4 smmsp.sh
pkgsrc/mail/sendmail/patches: patch-aa patch-af patch-ai
Added Files:
pkgsrc/mail/sendmail: TODO
pkgsrc/mail/sendmail/files: netbsd-proto.mc site.config.m4-ffr_tls
site.config.m4-stdbool sm_os_netbsd.h
pkgsrc/mail/sendmail/patches: patch-ao patch-ap patch-aq patch-ar
patch-as patch-at patch-au patch-av patch-aw patch-ax patch-ay
patch-az
Removed Files:
pkgsrc/mail/sendmail/files: site.config.m4-ffr_tls_1
pkgsrc/mail/sendmail/patches: patch-ab patch-ac patch-ad patch-ae
patch-al patch-am
Log Message:
Update to sendmail 8.14.9: this fixes a minor potential security issue
pkgsrc changes:
- consolidate several patches into site.config.m4
- pkgsrc LDFLAGS should always be used
- don't bother specifying file owner/group anywhere except in Makefile
- create include/sm/os/sm_os_netbsd.h to fix warnings and OS specific stuff
- install mail.local and rmail
- convert to use res_n* functions
- allows for linking against threaded libraries
- add a TODO file
- PR/35249 - Loren M. Lang
- can't find libraries on Linux, this should be fixed by using pkgsrc LDFLAGS
- PR/46694 - Makoto Fujiwara
- bring back netbsd-proto.mc from when sendmail was part of the base system
- PR/47207 - Richard Palo
- let pkgsrc infrastructure handle file ownership and group
- PR/48566 - Emmanuel Dreyfus
- always set _FFR_USE_GETPWNAM_ERRNO on NetBSD
- roll ffr_tls_1 and the suggested ffr_tls_ec into one new ffr_tls option
- not enabled by default because it changes behaviour
8.14.9/8.14.9 2014/05/21
SECURITY: Properly set the close-on-exec flag for file descriptors
(except stdin, stdout, and stderr) before executing mailers.
Fix a misformed comment in conf.c: "/*" within comment
which may cause a compilation error on some systems.
Problem reported by John Beck of Oracle.
DEVTOOLS: Fix regression in auto-detection of libraries when only
shared libraries are available. Problem reported by
Bryan Costales.
To generate a diff of this commit:
cvs rdiff -u -r1.120 -r1.121 pkgsrc/mail/sendmail/Makefile
cvs rdiff -u -r1.60 -r1.61 pkgsrc/mail/sendmail/Makefile.common
cvs rdiff -u -r1.19 -r1.20 pkgsrc/mail/sendmail/PLIST
cvs rdiff -u -r0 -r1.1 pkgsrc/mail/sendmail/TODO
cvs rdiff -u -r1.50 -r1.51 pkgsrc/mail/sendmail/distinfo
cvs rdiff -u -r1.20 -r1.21 pkgsrc/mail/sendmail/options.mk
cvs rdiff -u -r0 -r1.1 pkgsrc/mail/sendmail/files/netbsd-proto.mc \
pkgsrc/mail/sendmail/files/site.config.m4-ffr_tls \
pkgsrc/mail/sendmail/files/site.config.m4-stdbool \
pkgsrc/mail/sendmail/files/sm_os_netbsd.h
cvs rdiff -u -r1.2 -r1.3 pkgsrc/mail/sendmail/files/sendmail.sh \
pkgsrc/mail/sendmail/files/smmsp.sh
cvs rdiff -u -r1.10 -r1.11 pkgsrc/mail/sendmail/files/site.config.m4
cvs rdiff -u -r1.1 -r0 pkgsrc/mail/sendmail/files/site.config.m4-ffr_tls_1
cvs rdiff -u -r1.20 -r1.21 pkgsrc/mail/sendmail/patches/patch-aa
cvs rdiff -u -r1.12 -r0 pkgsrc/mail/sendmail/patches/patch-ab
cvs rdiff -u -r1.6 -r0 pkgsrc/mail/sendmail/patches/patch-ac
cvs rdiff -u -r1.7 -r0 pkgsrc/mail/sendmail/patches/patch-ad
cvs rdiff -u -r1.5 -r0 pkgsrc/mail/sendmail/patches/patch-ae \
pkgsrc/mail/sendmail/patches/patch-al
cvs rdiff -u -r1.11 -r1.12 pkgsrc/mail/sendmail/patches/patch-af
cvs rdiff -u -r1.8 -r1.9 pkgsrc/mail/sendmail/patches/patch-ai
cvs rdiff -u -r1.3 -r0 pkgsrc/mail/sendmail/patches/patch-am
cvs rdiff -u -r0 -r1.3 pkgsrc/mail/sendmail/patches/patch-ao
cvs rdiff -u -r0 -r1.1 pkgsrc/mail/sendmail/patches/patch-ap \
pkgsrc/mail/sendmail/patches/patch-aq \
pkgsrc/mail/sendmail/patches/patch-ar \
pkgsrc/mail/sendmail/patches/patch-as \
pkgsrc/mail/sendmail/patches/patch-at \
pkgsrc/mail/sendmail/patches/patch-au \
pkgsrc/mail/sendmail/patches/patch-av \
pkgsrc/mail/sendmail/patches/patch-aw \
pkgsrc/mail/sendmail/patches/patch-ax \
pkgsrc/mail/sendmail/patches/patch-ay \
pkgsrc/mail/sendmail/patches/patch-az
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
State-Changed-From-To: open->feedback
State-Changed-By: jnemeth@NetBSD.org
State-Changed-When: Sun, 15 Jun 2014 20:55:41 +0000
State-Changed-Why:
getpwnam() patch added
ECDH patch combined with previous FFR_TLS patch
Please check that these changes fixes the issues.
From: manu@netbsd.org (Emmanuel Dreyfus)
To: gnats-bugs@NetBSD.org, jnemeth@NetBSD.org, pkgsrc-bugs@netbsd.org,
gnats-admin@netbsd.org
Cc:
Subject: Re: pkg/48566 (getpwnam() fix and ECDH for sendmail from upstream)
Date: Mon, 16 Jun 2014 06:18:11 +0200
<jnemeth@NetBSD.org> wrote:
> ECDH patch combined with previous FFR_TLS patch
> Please check that these changes fixes the issues.
It fails the build for a minor issue:
=> Checking file-check results for sendmail-8.14.9
ERROR: ************************************************************
ERROR: The following files are in
/pkg_comp/obj/pkgsrc/mail/sendmail/default/.destdir/usr/pkg but not in
the PLIST:
ERROR:
/pkg_comp/obj/pkgsrc/mail/sendmail/default/.destdir/usr/pkg/share/exampl
es/rc.d/sendmail
ERROR:
/pkg_comp/obj/pkgsrc/mail/sendmail/default/.destdir/usr/pkg/share/exampl
es/rc.d/smmsp
--
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
manu@netbsd.org
From: jnemeth@CornerstoneService.ca (John Nemeth)
To: manu@netbsd.org (Emmanuel Dreyfus), gnats-bugs@netbsd.org,
pkgsrc-bugs@netbsd.org, gnats-admin@netbsd.org
Cc:
Subject: Re: pkg/48566 (getpwnam() fix and ECDH for sendmail from upstream)
Date: Sun, 15 Jun 2014 23:02:48 -0700
On Jun 16, 6:18am, Emmanuel Dreyfus wrote:
} Subject: Re: pkg/48566 (getpwnam() fix and ECDH for sendmail from upstream
} <jnemeth@NetBSD.org> wrote:
}
} > ECDH patch combined with previous FFR_TLS patch
} > Please check that these changes fixes the issues.
}
} It fails the build for a minor issue:
}
} => Checking file-check results for sendmail-8.14.9
} ERROR: ************************************************************
} ERROR: The following files are in
} /pkg_comp/obj/pkgsrc/mail/sendmail/default/.destdir/usr/pkg but not in
} the PLIST:
} ERROR:
} /pkg_comp/obj/pkgsrc/mail/sendmail/default/.destdir/usr/pkg/share/exampl
} es/rc.d/sendmail
} ERROR:
} /pkg_comp/obj/pkgsrc/mail/sendmail/default/.destdir/usr/pkg/share/exampl
} es/rc.d/smmsp
Sounds like your infrastructure is out of date. With changes
to support SMF these files are no longer in PLIST as they are
handled automatically. You should update pkgsrc/mk.
}-- End of excerpt from Emmanuel Dreyfus
From: manu@netbsd.org (Emmanuel Dreyfus)
To: gnats-bugs@NetBSD.org, jnemeth@NetBSD.org, pkgsrc-bugs@netbsd.org,
gnats-admin@netbsd.org
Cc:
Subject: Re: pkg/48566 (getpwnam() fix and ECDH for sendmail from upstream)
Date: Mon, 16 Jun 2014 10:40:42 +0200
<jnemeth@NetBSD.org> wrote:
> Please check that these changes fixes the issues.
ECDH and FFR_TLS features are there, so is the proper getpwnam() failure
handling.
However I have a regression: Many clients cannot connect anymore and get
"STARTTLS: read error=timeout" in the log.
That error appeared before, but it was rare (around 50 per day), and it
is now much more widespread (110 within an hour before I downgraded
sendmail to previous version).
--
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
manu@netbsd.org
From: Emmanuel Dreyfus <manu@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: jnemeth@NetBSD.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org,
manu@netbsd.org
Subject: Re: pkg/48566 (getpwnam() fix and ECDH for sendmail from upstream)
Date: Tue, 17 Jun 2014 13:59:12 +0000
On Mon, Jun 16, 2014 at 08:40:00AM +0000, Emmanuel Dreyfus wrote:
> However I have a regression: Many clients cannot connect anymore and get
> "STARTTLS: read error=timeout" in the log.
>
> That error appeared before, but it was rare (around 50 per day), and it
> is now much more widespread (110 within an hour before I downgraded
> sendmail to previous version).
In fact I now get it reliabily for many clients. Reverting
pkgsrc/mail/sendmail/patches/* to its content prior this upgrades
and running make makepatchsum fixes the problem.
The bug is therefore not in sendmail-8.14.9 but in the pkgsrc patches
we apply to it. The change is about using re-entrant resolver and
IPv6 resolution, and it is quite intrusive. Was that submitted upstream
to sendmail maintainers?
--
Emmanuel Dreyfus
manu@netbsd.org
From: Emmanuel Dreyfus <manu@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: jnemeth@NetBSD.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org,
manu@netbsd.org
Subject: Re: pkg/48566 (getpwnam() fix and ECDH for sendmail from upstream)
Date: Tue, 17 Jun 2014 14:10:22 +0000
On Tue, Jun 17, 2014 at 02:00:00PM +0000, Emmanuel Dreyfus wrote:
> The bug is therefore not in sendmail-8.14.9 but in the pkgsrc patches
> we apply to it.
And with -current pkgsrc/mail/sendmail/paches, I can restore functionnality
with this simple change (and make makepatchsum of course), hence re-entrant
resolver is the culprit.
Index: mail//sendmail/patches/patch-aq
===================================================================
RCS file: /cvsroot/pkgsrc/mail/sendmail/patches/patch-aq,v
retrieving revision 1.1
diff -U4 -r1.1 patch-aq
--- mail//sendmail/patches/patch-aq 15 Jun 2014 20:48:50 -0000 1.1
+++ mail//sendmail/patches/patch-aq 17 Jun 2014 14:07:50 -0000
@@ -5,10 +5,10 @@
@@ -234,6 +234,10 @@ struct rusage; /* forward declaration to
# define PIPELINING 1 /* SMTP PIPELINING */
#endif /* PIPELINING */
-+#ifndef NAMED_RESN
-+# define NAMED_RESN 1 /* res_n* functions are available */
++#ifdef NAMED_RESN
++# undef NAMED_RESN
+#endif
+
/***************************************
--
Emmanuel Dreyfus
manu@netbsd.org
From: Emmanuel Dreyfus <manu@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: jnemeth@NetBSD.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org,
manu@netbsd.org
Subject: Re: pkg/48566 (getpwnam() fix and ECDH for sendmail from upstream)
Date: Tue, 17 Jun 2014 15:39:09 +0000
On Tue, Jun 17, 2014 at 02:15:00PM +0000, Emmanuel Dreyfus wrote:
> And with -current pkgsrc/mail/sendmail/paches, I can restore functionnality
> with this simple change (and make makepatchsum of course), hence re-entrant
> resolver is the culprit.
I found two bugs in the pkgsrc patches for NAMED_RESN
- res_ninit is called regardless if the structure was already initialized
- there is a res_search left in sendmail/sm_resolve.c that does not have
a res_nsearch counterpart. If NAMED_RESN is defined I think it will operate
without proper resolver initiliazation.
Is that code really ready for being enabled by default?
--
Emmanuel Dreyfus
manu@netbsd.org
From: christos@zoulas.com (Christos Zoulas)
To: Emmanuel Dreyfus <manu@netbsd.org>, gnats-bugs@NetBSD.org
Cc: jnemeth@NetBSD.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/48566 (getpwnam() fix and ECDH for sendmail from upstream)
Date: Tue, 17 Jun 2014 12:28:35 -0400
On Jun 17, 3:39pm, manu@netbsd.org (Emmanuel Dreyfus) wrote:
-- Subject: Re: pkg/48566 (getpwnam() fix and ECDH for sendmail from upstream
| On Tue, Jun 17, 2014 at 02:15:00PM +0000, Emmanuel Dreyfus wrote:
| > And with -current pkgsrc/mail/sendmail/paches, I can restore functionnality
| > with this simple change (and make makepatchsum of course), hence re-entrant
| > resolver is the culprit.
|
| I found two bugs in the pkgsrc patches for NAMED_RESN
| - res_ninit is called regardless if the structure was already initialized
| - there is a res_search left in sendmail/sm_resolve.c that does not have
| a res_nsearch counterpart. If NAMED_RESN is defined I think it will operate
| without proper resolver initiliazation.
|
| Is that code really ready for being enabled by default?
Does not look like it :-) Who wrote the patch?
christos
From: manu@netbsd.org (Emmanuel Dreyfus)
To: gnats-bugs@NetBSD.org
Cc: jnemeth@NetBSD.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/48566 (getpwnam() fix and ECDH for sendmail from upstream)
Date: Tue, 17 Jun 2014 20:25:25 +0200
Emmanuel Dreyfus <manu@netbsd.org> wrote:
> I found two bugs in the pkgsrc patches for NAMED_RESN
> - res_ninit is called regardless if the structure was already initialized
> - there is a res_search left in sendmail/sm_resolve.c that does not have
> a res_nsearch counterpart. If NAMED_RESN is defined I think it will operate
> without proper resolver initiliazation.
I made a patch that:
1) introduces a threads option that enable NAMED_RESN code. It is
disabled by default.
2) pull a patch that just went upstream so that SSL_OP_TLSEXT_PADDING
can be disabled, as it breaks interoperability with some other MTA.
Here is it. Okay to commit?
http://ftp.espci.fr/shadow/manu/patch-resn
--
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
manu@netbsd.org
From: christos@zoulas.com (Christos Zoulas)
To: manu@netbsd.org (Emmanuel Dreyfus), gnats-bugs@NetBSD.org
Cc: jnemeth@NetBSD.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/48566 (getpwnam() fix and ECDH for sendmail from upstream)
Date: Tue, 17 Jun 2014 14:36:56 -0400
On Jun 17, 8:25pm, manu@netbsd.org (Emmanuel Dreyfus) wrote:
-- Subject: Re: pkg/48566 (getpwnam() fix and ECDH for sendmail from upstream
| Emmanuel Dreyfus <manu@netbsd.org> wrote:
|
| > I found two bugs in the pkgsrc patches for NAMED_RESN
| > - res_ninit is called regardless if the structure was already initialized
| > - there is a res_search left in sendmail/sm_resolve.c that does not have
| > a res_nsearch counterpart. If NAMED_RESN is defined I think it will operate
| > without proper resolver initiliazation.
|
| I made a patch that:
| 1) introduces a threads option that enable NAMED_RESN code. It is
| disabled by default.
| 2) pull a patch that just went upstream so that SSL_OP_TLSEXT_PADDING
| can be disabled, as it breaks interoperability with some other MTA.
|
| Here is it. Okay to commit?
| http://ftp.espci.fr/shadow/manu/patch-resn
If you are threaded and you use _res you'll break with NetBSD because we
don't allow that.
christos
From: manu@netbsd.org (Emmanuel Dreyfus)
To: christos@zoulas.com (Christos Zoulas), gnats-bugs@NetBSD.org
Cc: jnemeth@NetBSD.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/48566 (getpwnam() fix and ECDH for sendmail from upstream)
Date: Tue, 17 Jun 2014 21:40:56 +0200
Christos Zoulas <christos@zoulas.com> wrote:
> If you are threaded and you use _res you'll break with NetBSD because we
> don't allow that.
Sendmail is not threaded, hence it is perfectly fine to use __res. I
must confess I do not understand why this change was done. The commit
message says:
- convert to use res_n* functions
- allows for linking against threaded libraries
But I do not know what case we are talking about. I already link
sendmail with a SASL plugin that does not use threads, but pulls
-lpthread through other libraries, and it works fine, hence it is not
the problem we have here.
--
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
manu@netbsd.org
From: christos@zoulas.com (Christos Zoulas)
To: gnats-bugs@NetBSD.org, jnemeth@NetBSD.org, gnats-admin@netbsd.org,
pkgsrc-bugs@netbsd.org, manu@netbsd.org
Cc:
Subject: Re: pkg/48566 (getpwnam() fix and ECDH for sendmail from upstream)
Date: Tue, 17 Jun 2014 15:47:55 -0400
On Jun 17, 7:40pm, manu@netbsd.org (Emmanuel Dreyfus) wrote:
-- Subject: Re: pkg/48566 (getpwnam() fix and ECDH for sendmail from upstream
| > If you are threaded and you use _res you'll break with NetBSD because we
| > don't allow that.
|
| Sendmail is not threaded, hence it is perfectly fine to use __res. I
| must confess I do not understand why this change was done. The commit
| message says:
| - convert to use res_n* functions
| - allows for linking against threaded libraries
Yes, someone else encountered the same problem and tried to fix it.
| But I do not know what case we are talking about. I already link
| sendmail with a SASL plugin that does not use threads, but pulls
| -lpthread through other libraries, and it works fine, hence it is not
| the problem we have here.
As long as it is not actually using threads and _res gets resolved to the
libc one instead of the libpthread one it should be ok. In the long term
it is better to use the new resolver functions though.
christos
From: Hisashi T Fujinaka <htodd@twofifty.com>
To: Emmanuel Dreyfus <manu@netbsd.org>
Cc: Christos Zoulas <christos@zoulas.com>, gnats-bugs@NetBSD.org,
jnemeth@NetBSD.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/48566 (getpwnam() fix and ECDH for sendmail from upstream)
Date: Tue, 17 Jun 2014 13:29:28 -0700 (PDT)
On Tue, 17 Jun 2014, Emmanuel Dreyfus wrote:
> Christos Zoulas <christos@zoulas.com> wrote:
>
>> If you are threaded and you use _res you'll break with NetBSD because we
>> don't allow that.
>
> Sendmail is not threaded, hence it is perfectly fine to use __res. I
> must confess I do not understand why this change was done. The commit
> message says:
> - convert to use res_n* functions
> - allows for linking against threaded libraries
>
> But I do not know what case we are talking about. I already link
> sendmail with a SASL plugin that does not use threads, but pulls
> -lpthread through other libraries, and it works fine, hence it is not
> the problem we have here.
IIRC, this broke my sendmail last time someone tried it. It is what
finally got me to change to postfix.
--
Hisashi T Fujinaka - htodd@twofifty.com
BSEE(6/86) + BSChem(3/95) + BAEnglish(8/95) + MSCS(8/03) + $2.50 = latte
From: manu@netbsd.org (Emmanuel Dreyfus)
To: christos@zoulas.com (Christos Zoulas), gnats-bugs@NetBSD.org,
jnemeth@NetBSD.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Cc:
Subject: Re: pkg/48566 (getpwnam() fix and ECDH for sendmail from upstream)
Date: Wed, 18 Jun 2014 03:47:52 +0200
Christos Zoulas <christos@zoulas.com> wrote:
> As long as it is not actually using threads and _res gets resolved to the
> libc one instead of the libpthread one it should be ok. In the long term
> it is better to use the new resolver functions though.
Sure but such an intrusive change should first go upstream for review,
IMO. We do not want to fork Sendmail, do we?
--
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
manu@netbsd.org
From: christos@zoulas.com (Christos Zoulas)
To: manu@netbsd.org (Emmanuel Dreyfus), gnats-bugs@NetBSD.org,
jnemeth@NetBSD.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Cc:
Subject: Re: pkg/48566 (getpwnam() fix and ECDH for sendmail from upstream)
Date: Tue, 17 Jun 2014 21:47:44 -0400
On Jun 18, 3:47am, manu@netbsd.org (Emmanuel Dreyfus) wrote:
-- Subject: Re: pkg/48566 (getpwnam() fix and ECDH for sendmail from upstream
| Christos Zoulas <christos@zoulas.com> wrote:
|
| > As long as it is not actually using threads and _res gets resolved to the
| > libc one instead of the libpthread one it should be ok. In the long term
| > it is better to use the new resolver functions though.
|
| Sure but such an intrusive change should first go upstream for review,
| IMO. We do not want to fork Sendmail, do we?
I sent a similar patch to postfix a year ago and it is part of the postfix
source already; it is not that intrusive.
christos
From: jnemeth@CornerstoneService.ca (John Nemeth)
To: manu@netbsd.org (Emmanuel Dreyfus), gnats-bugs@netbsd.org
Cc: gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/48566 (getpwnam() fix and ECDH for sendmail from upstream)
Date: Tue, 17 Jun 2014 19:17:50 -0700
On Jun 17, 8:25pm, Emmanuel Dreyfus wrote:
} Emmanuel Dreyfus <manu@netbsd.org> wrote:
}
} > I found two bugs in the pkgsrc patches for NAMED_RESN
} > - res_ninit is called regardless if the structure was already initialized
} > - there is a res_search left in sendmail/sm_resolve.c that does not have
} > a res_nsearch counterpart. If NAMED_RESN is defined I think it will operate
} > without proper resolver initiliazation.
}
} I made a patch that:
} 1) introduces a threads option that enable NAMED_RESN code. It is
} disabled by default.
} 2) pull a patch that just went upstream so that SSL_OP_TLSEXT_PADDING
} can be disabled, as it breaks interoperability with some other MTA.
}
} Here is it. Okay to commit?
} http://ftp.espci.fr/shadow/manu/patch-resn
No. Something else will be done very shortly.
}-- End of excerpt from Emmanuel Dreyfus
From: manu@netbsd.org (Emmanuel Dreyfus)
To: gnats-bugs@NetBSD.org, jnemeth@NetBSD.org, gnats-admin@netbsd.org,
pkgsrc-bugs@netbsd.org
Cc:
Subject: Re: pkg/48566 (getpwnam() fix and ECDH for sendmail from upstream)
Date: Wed, 18 Jun 2014 05:24:59 +0200
John Nemeth <jnemeth@CornerstoneService.ca> wrote:
> No. Something else will be done very shortly.
Is it possible to know what will be done?
--
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
manu@netbsd.org
From: jnemeth@CornerstoneService.ca (John Nemeth)
To: Emmanuel Dreyfus <manu@netbsd.org>, gnats-bugs@netbsd.org
Cc: gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/48566 (getpwnam() fix and ECDH for sendmail from upstream)
Date: Wed, 18 Jun 2014 22:06:55 -0700
On Jun 17, 3:39pm, Emmanuel Dreyfus wrote:
} On Tue, Jun 17, 2014 at 02:15:00PM +0000, Emmanuel Dreyfus wrote:
} > And with -current pkgsrc/mail/sendmail/paches, I can restore functionnality
} > with this simple change (and make makepatchsum of course), hence re-entrant
} > resolver is the culprit.
}
} I found two bugs in the pkgsrc patches for NAMED_RESN
} - res_ninit is called regardless if the structure was already initialized
The case where res_ninit() was called without checking for
previous initialisation was relatively early in the startup. A
visual code inspection indicated that it was highly unlikely that
res_ninit() would be called after initialisation. Did you find a
code path where it could happen? I didn't bother testing for
initialisation at that point because it made things rather awkward.
However, just to make you happy I figured out a way to do it. Note
that in the unlikely event that res_ninit() was called when it had
already been called, all that would have happened is a small amount
of leaked memory. Not great, but hardly the end of the world.
BTW, even in the case that res_init()/res_ninit() didn't get called,
the code went ahead and initialised all the options anyways. Which
is kind of silly, but not a change created by this patch.
} - there is a res_search left in sendmail/sm_resolve.c that does not have
Thank you for pointing that out. It was the only place that
got missed. I found it and squashed it. I have also verified with
the help of nm that all deprecated functions, as listed in resolver(3),
have been found and eradicated.
} a res_nsearch counterpart. If NAMED_RESN is defined I think it will operate
} without proper resolver initiliazation.
BTW, where were you when I asked for testing and feedback
prior to 8.14.9 being committed?
}-- End of excerpt from Emmanuel Dreyfus
From: Emmanuel Dreyfus <manu@netbsd.org>
To: John Nemeth <jnemeth@CornerstoneService.ca>
Cc: Emmanuel Dreyfus <manu@netbsd.org>, gnats-bugs@netbsd.org,
gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/48566 (getpwnam() fix and ECDH for sendmail from upstream)
Date: Thu, 19 Jun 2014 07:29:21 +0000
On Wed, Jun 18, 2014 at 10:06:55PM -0700, John Nemeth wrote:
> The case where res_ninit() was called without checking for
> previous initialisation was relatively early in the startup. A
> visual code inspection indicated that it was highly unlikely that
> res_ninit() would be called after initialisation. Did you find a
> code path where it could happen?
No, but sendmail is completely broken at mine (timeouts in all TLS sessions)
and this is caused by this patchset, as it works fine if I undef NAMED_RESN.
Hence I am looking for possible explanations.
Unfortunately it is not one of these two problems, as I still get the
tiemout problem with your updated patchset. There must be other bugs.
While there, even with NAMED_RESN there is are still many sites sendmail
cannot connect to because of SSL_OP_TLSEXT_PADDING introduced in
OpenSSL 1.0.1g. Since that cause troubles on latest NetBSD releases, we
need to add that patch which was accepted upstream by sendmail maintainers:
ftp://ftp.espci.fr/shadow/manu/patch-sendmail_readcf.c
> BTW, where were you when I asked for testing and feedback
> prior to 8.14.9 being committed?
Busy on something else, I am sure you can understand that.
--
Emmanuel Dreyfus
manu@netbsd.org
From: "John Nemeth" <jnemeth@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/48566 CVS commit: pkgsrc/mail/sendmail
Date: Fri, 20 Jun 2014 05:24:32 +0000
Module Name: pkgsrc
Committed By: jnemeth
Date: Fri Jun 20 05:24:32 UTC 2014
Modified Files:
pkgsrc/mail/sendmail: Makefile distinfo
pkgsrc/mail/sendmail/files: netbsd-proto.mc
pkgsrc/mail/sendmail/patches: patch-an patch-au patch-aw patch-ay
Added Files:
pkgsrc/mail/sendmail/patches: patch-ba patch-bb patch-bc patch-bd
patch-be
Log Message:
Update to sendmail 8.14.9nb1: this is a pkgsrc bugfix update
- remove some HTML cruft from netbsd-proto.mc
- stop trying to set file ownership and group during stage-install
- initialize sm_res earlier and test before calling res_ninit()
- clear SSL_OP_TLSEXT_PADDING by defualt to fix interoperability issues
- eliminate stray call to res_search()
- verified with nm that all deprecated resolver functions have been eradicated
The above should address the folling PRs:
- PR/47207 - Richard Palo -- attempt to set ownership when unprivileged
- PR/48566 - Emmanuel Dreyfus -- problem with TLS timeouts
- PR/48913 - Matthias Scheler -- attempt to set ownership when unprivileged
To generate a diff of this commit:
cvs rdiff -u -r1.122 -r1.123 pkgsrc/mail/sendmail/Makefile
cvs rdiff -u -r1.51 -r1.52 pkgsrc/mail/sendmail/distinfo
cvs rdiff -u -r1.1 -r1.2 pkgsrc/mail/sendmail/files/netbsd-proto.mc
cvs rdiff -u -r1.1 -r1.2 pkgsrc/mail/sendmail/patches/patch-an \
pkgsrc/mail/sendmail/patches/patch-au \
pkgsrc/mail/sendmail/patches/patch-aw \
pkgsrc/mail/sendmail/patches/patch-ay
cvs rdiff -u -r0 -r1.3 pkgsrc/mail/sendmail/patches/patch-ba
cvs rdiff -u -r0 -r1.1 pkgsrc/mail/sendmail/patches/patch-bb \
pkgsrc/mail/sendmail/patches/patch-bc \
pkgsrc/mail/sendmail/patches/patch-bd \
pkgsrc/mail/sendmail/patches/patch-be
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: manu@netbsd.org (Emmanuel Dreyfus)
To: gnats-bugs@NetBSD.org, jnemeth@NetBSD.org, gnats-admin@netbsd.org,
pkgsrc-bugs@netbsd.org
Cc:
Subject: Re: PR/48566 CVS commit: pkgsrc/mail/sendmail
Date: Fri, 20 Jun 2014 08:14:22 +0200
John Nemeth <jnemeth@netbsd.org> wrote:
> Update to sendmail 8.14.9nb1: this is a pkgsrc bugfix update
The build fails if you have OpenSSL >= 1.0.1g (which means it breaks on latests NetBSD releases):
cc -O -I. -I../../include -DNEWDB -DNIS -DMAP_REGEX -DSOCKETMAP -DLDAPMAP -D_FFR_LDAP_NETWORK_TIMEOUT -I/usr/pkg/include -DSMRSH_CMDDIR=\"/usr/pkg/libexec/sm.bin\"
-DNETINET6 -DNEEDSGETIPNODE -DTCPWRAPPERS -DSASL=2 -D_FFR_USE_GETPWNAM_ERRNO=1 -DMILTER -DSTARTTLS -D_FFR_TLS_1 -D_FFR_TLS_EC -DLDAP_DEPRECATED -I/usr/pkg/include
-I/usr/include -c readcf.c
readcf.c:2424:2: error: expected '}' before '{' token
readcf.c:2425:2: error: expected '}' before ';' token
There is a line with }, missing:
#ifdef SSL_OP_CRYPTOPRO_TLSEXT_BUG
{ "SSL_OP_CRYPTOPRO_TLSEXT_BUG", SSL_OP_CRYPTOPRO_TLSEXT_BUG
},
#endif
#ifdef SSL_OP_TLSEXT_PADDING
{ "SSL_OP_TLSEXT_PADDING", SSL_OP_TLSEXT_PADDING
#endif
{ NULL, 0 }
};
Updated pkgsrc/mail/sendmail/patches/patch-aw that builds:
http://ftp.espci.fr/shadow/manu/patch-aw
> The above should address the folling PRs:
(...)
> - PR/48566 - Emmanuel Dreyfus -- problem with TLS timeouts
It still times out but I tracked it down to this setup:
It hangs at RCPT stage when sendmail is built with the sasl
option (even if no SASL option is configured in sendmail.cf) and a
milter is configured in sendmail.cf
I can enable and configure everything else (ldap, tls,
sendmail-ffr-tls) except sasl, and use a milter, it works.
I can enable and configure sasl and disable the milter, it works too.
--
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
manu@netbsd.org
From: jnemeth@CornerstoneService.ca (John Nemeth)
To: manu@netbsd.org (Emmanuel Dreyfus), gnats-bugs@netbsd.org,
gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Cc:
Subject: Re: PR/48566 CVS commit: pkgsrc/mail/sendmail
Date: Fri, 20 Jun 2014 02:16:43 -0700
On Jun 20, 8:14am, Emmanuel Dreyfus wrote:
} Subject: Re: PR/48566 CVS commit: pkgsrc/mail/sendmail
} John Nemeth <jnemeth@netbsd.org> wrote:
}
} > Update to sendmail 8.14.9nb1: this is a pkgsrc bugfix update
}
} The build fails if you have OpenSSL >= 1.0.1g (which means it breaks on latests NetBSD releases):
}
} cc -O -I. -I../../include -DNEWDB -DNIS -DMAP_REGEX -DSOCKETMAP -DLDAPMAP -D_FFR_LDAP_NETWORK_TIMEOUT -I/usr/pkg/include -DSMRSH_CMDDIR=\"/usr/pkg/libexec/sm.bin\"
} -DNETINET6 -DNEEDSGETIPNODE -DTCPWRAPPERS -DSASL=2 -D_FFR_USE_GETPWNAM_ERRNO=1 -DMILTER -DSTARTTLS -D_FFR_TLS_1 -D_FFR_TLS_EC -DLDAP_DEPRECATED -I/usr/pkg/include
} -I/usr/include -c readcf.c
} readcf.c:2424:2: error: expected '}' before '{' token
} readcf.c:2425:2: error: expected '}' before ';' token
}
} There is a line with }, missing:
}
} #ifdef SSL_OP_CRYPTOPRO_TLSEXT_BUG
} { "SSL_OP_CRYPTOPRO_TLSEXT_BUG", SSL_OP_CRYPTOPRO_TLSEXT_BUG
} },
} #endif
} #ifdef SSL_OP_TLSEXT_PADDING
} { "SSL_OP_TLSEXT_PADDING", SSL_OP_TLSEXT_PADDING
} #endif
} { NULL, 0 }
} };
Argh! I am building with OpenSSL 1.0.1g, but apparently not new
enough. I will start my buildbox buidling a newer -current.
} > The above should address the folling PRs:
} (...)
} > - PR/48566 - Emmanuel Dreyfus -- problem with TLS timeouts
}
} It still times out but I tracked it down to this setup:
}
} It hangs at RCPT stage when sendmail is built with the sasl
} option (even if no SASL option is configured in sendmail.cf) and a
} milter is configured in sendmail.cf
}
} I can enable and configure everything else (ldap, tls,
} sendmail-ffr-tls) except sasl, and use a milter, it works.
}
} I can enable and configure sasl and disable the milter, it works too.
This is truely weird. For now, I disable NAMED_RESN when
using the sasl option. I want to stop the churn during the freeze.
But, I still wish to have the NAMED_RESN option to get it tested.
I'm using it in production, and I've had a positive report from
somebody else.
I have placed a new package at
ftp.netbsd.org:/pub/NetBSD/misc/jnemeth/sendmail.pkgsrc.tgz. Could
you try that, please?
}-- End of excerpt from Emmanuel Dreyfus
From: Emmanuel Dreyfus <manu@netbsd.org>
To: John Nemeth <jnemeth@CornerstoneService.ca>
Cc: Emmanuel Dreyfus <manu@netbsd.org>, gnats-bugs@netbsd.org,
gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: PR/48566 CVS commit: pkgsrc/mail/sendmail
Date: Fri, 20 Jun 2014 09:55:52 +0000
On Fri, Jun 20, 2014 at 02:16:43AM -0700, John Nemeth wrote:
> Argh! I am building with OpenSSL 1.0.1g, but apparently not new
> enough. I will start my buildbox buidling a newer -current.
Perhaps you updated the library but not the header files?
> This is truely weird. For now, I disable NAMED_RESN when
> using the sasl option.
> ftp.netbsd.org:/pub/NetBSD/misc/jnemeth/sendmail.pkgsrc.tgz. Could
> you try that, please?
That works fine on my testbed.
A note on the coment in site.config.m4-sasl2: this is really
NAMED_RESN + SASL + milter that breaks. Withut milter it works.
--
Emmanuel Dreyfus
manu@netbsd.org
From: "John Nemeth" <jnemeth@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/48566 CVS commit: pkgsrc/mail/sendmail
Date: Fri, 20 Jun 2014 16:26:55 +0000
Module Name: pkgsrc
Committed By: jnemeth
Date: Fri Jun 20 16:26:55 UTC 2014
Modified Files:
pkgsrc/mail/sendmail: Makefile TODO distinfo
pkgsrc/mail/sendmail/files: site.config.m4-sasl2
pkgsrc/mail/sendmail/patches: patch-aw
Added Files:
pkgsrc/mail/sendmail/patches: patch-bf
Log Message:
Update to sendmail 8.14.9nb2: this is a pkgsrc bugfix update.
This should be the last update during the freeze.
PR/48566 - Emmanuel Dreyfus -- typo in patch-aw leading to build failure
PR/48913 - Matthias Scheler -- libmilter fails on unprivileged builds
To generate a diff of this commit:
cvs rdiff -u -r1.123 -r1.124 pkgsrc/mail/sendmail/Makefile
cvs rdiff -u -r1.1 -r1.2 pkgsrc/mail/sendmail/TODO
cvs rdiff -u -r1.52 -r1.53 pkgsrc/mail/sendmail/distinfo
cvs rdiff -u -r1.2 -r1.3 pkgsrc/mail/sendmail/files/site.config.m4-sasl2
cvs rdiff -u -r1.2 -r1.3 pkgsrc/mail/sendmail/patches/patch-aw
cvs rdiff -u -r0 -r1.1 pkgsrc/mail/sendmail/patches/patch-bf
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: Hauke Fath <hauke@Espresso.Rhein-Neckar.DE>
To: gnats-bugs@NetBSD.org
Cc: jnemeth@NetBSD.org, gnats-admin@NetBSD.org
Subject: Re: PR/48566 CVS commit: pkgsrc/mail/sendmail
Date: Sat, 21 Jun 2014 17:28:57 +0200
On Fri, 20 Jun 2014 05:25:01 +0000 (UTC), John Nemeth wrote:
> Log Message:
> Update to sendmail 8.14.9nb1: this is a pkgsrc bugfix update
Here's another one:
=3D=3D=3D> Updating using binary package of sendmail-8.14.9nb2
/usr/pkg/sbin/pkg_add -K /var/db/pkg -U -D=20
/var/obj/pkgsrc/mail/sendmail/work/.packages/sendmail-8.14.9nb2.tgz
pkg_add: Conflicting PLIST with uucp-1.07nb7: bin/rmail
pkg_add: 1 package addition failed
*** Error code 1
--=20
Hauke Fath <hauke@Espresso.Rhein-Neckar.DE>
Ernst-Ludwig-Stra=DFe 15
64625 Bensheim
Germany
From: jnemeth@CornerstoneService.ca (John Nemeth)
To: gnats-bugs@NetBSD.org, gnats-admin@NetBSD.org, pkgsrc-bugs@NetBSD.org,
manu@NetBSD.org
Cc:
Subject: Re: PR/48566 CVS commit: pkgsrc/mail/sendmail
Date: Tue, 24 Jun 2014 22:30:34 -0700
Is it okay to close this PR now? It would appear that everything
is fixed and I haven't seen any comments since June 21st.
From: Emmanuel Dreyfus <manu@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: PR/48566 CVS commit: pkgsrc/mail/sendmail
Date: Wed, 25 Jun 2014 06:24:31 +0000
On Wed, Jun 25, 2014 at 05:35:00AM +0000, John Nemeth wrote:
> Is it okay to close this PR now? It would appear that everything
> is fixed and I haven't seen any comments since June 21st.
>
It seems fine.
--
Emmanuel Dreyfus
manu@netbsd.org
State-Changed-From-To: feedback->closed
State-Changed-By: jnemeth@NetBSD.org
State-Changed-When: Wed, 25 Jun 2014 15:34:28 +0000
State-Changed-Why:
Submitter confirms fixed. Thanks for the PR!
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2007
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.
Home