NetBSD Problem Report #48727

From www@NetBSD.org  Tue Apr  8 11:30:19 2014
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 78F18A580E
	for <gnats-bugs@gnats.NetBSD.org>; Tue,  8 Apr 2014 11:30:19 +0000 (UTC)
Message-Id: <20140408113018.4BF51A5814@mollari.NetBSD.org>
Date: Tue,  8 Apr 2014 11:30:18 +0000 (UTC)
From: henning.petersen@t-online.de
Reply-To: henning.petersen@t-online.de
To: gnats-bugs@NetBSD.org
Subject: Missing paranthesis in ia64 boot.c
X-Send-Pr-Version: www-1.0

>Number:         48727
>Category:       port-ia64
>Synopsis:       Missing paranthesis in ia64 boot.c
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    port-ia64-maintainer
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Apr 08 11:35:00 +0000 2014
>Closed-Date:    Tue Apr 08 21:52:02 +0000 2014
>Last-Modified:  Tue Apr 08 21:55:00 +0000 2014
>Originator:     Henning Petersen
>Release:        NetBSD-current
>Organization:
>Environment:
>Description:
Missing paranthesis found by cppcheck.
>How-To-Repeat:

>Fix:
diff -u -p -r1.6 boot.c
--- sys/arch/ia64/stand/common/boot.c	25 Mar 2014 18:35:32 -0000	1.6
+++ sys/arch/ia64/stand/common/boot.c	8 Apr 2014 11:23:12 -0000
@@ -108,7 +108,7 @@ command_boot(int argc, char *argv[])
 	return(CMD_ERROR);

     /* Call the exec handler from the loader matching the kernel */
-    command_seterr("%s", strerror(file_formats[fp->f_loader]->l_exec(fp));
+    command_seterr("%s", strerror(file_formats[fp->f_loader]->l_exec(fp)));
     return(CMD_ERROR);
 }


>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: martin@NetBSD.org
State-Changed-When: Tue, 08 Apr 2014 21:52:02 +0000
State-Changed-Why:
Fixed, thanks!


From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/48727 CVS commit: src/sys/arch/ia64/stand
Date: Tue, 8 Apr 2014 21:51:06 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Tue Apr  8 21:51:06 UTC 2014

 Modified Files:
 	src/sys/arch/ia64/stand/common: boot.c commands.c
 	src/sys/arch/ia64/stand/efi/libefi: devicename.c
 	src/sys/arch/ia64/stand/ia64/ski: devicename.c

 Log Message:
 Make it compile again - partly from PR 48727 by Henning Petersen.


 To generate a diff of this commit:
 cvs rdiff -u -r1.6 -r1.7 src/sys/arch/ia64/stand/common/boot.c
 cvs rdiff -u -r1.4 -r1.5 src/sys/arch/ia64/stand/common/commands.c
 cvs rdiff -u -r1.7 -r1.8 src/sys/arch/ia64/stand/efi/libefi/devicename.c
 cvs rdiff -u -r1.6 -r1.7 src/sys/arch/ia64/stand/ia64/ski/devicename.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search