NetBSD Problem Report #48816

From www@NetBSD.org  Sat May 17 22:48:13 2014
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 7A8D1A6009
	for <gnats-bugs@gnats.NetBSD.org>; Sat, 17 May 2014 22:48:13 +0000 (UTC)
Message-Id: <20140517224812.60524A64F0@mollari.NetBSD.org>
Date: Sat, 17 May 2014 22:48:12 +0000 (UTC)
From: dhgutteridge@sympatico.ca
Reply-To: dhgutteridge@sympatico.ca
To: gnats-bugs@NetBSD.org
Subject: Compile fix for src/sys/arch/arm/broadcom/bcm2835_gpio.c
X-Send-Pr-Version: www-1.0

>Number:         48816
>Category:       port-evbarm
>Synopsis:       Compile fix for src/sys/arch/arm/broadcom/bcm2835_gpio.c
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    port-evbarm-maintainer
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat May 17 22:50:00 +0000 2014
>Closed-Date:    Mon May 19 22:58:27 +0000 2014
>Last-Modified:  Mon May 19 22:58:27 +0000 2014
>Originator:     David H. Gutteridge
>Release:        HEAD sources as of May 17, 2014
>Organization:
>Environment:
(As above.)
>Description:
While compiling a new kernel for my Raspberry Pi, I encountered this
build failure:

--- bcm2835_gpio.o ---
/usr/builds/netbsd-current/src/sys/arch/arm/broadcom/bcm2835_gpio.c: In function 'bcmgpio_attach':
/usr/builds/netbsd-current/src/sys/arch/arm/broadcom/bcm2835_gpio.c:116:3: error: 'maxpin' undeclared (first use in this function)
   maxpin = 53;
   ^
/usr/builds/netbsd-current/src/sys/arch/arm/broadcom/bcm2835_gpio.c:116:3: note: each undeclared identifier is reported only once for each function it appears in
/usr/builds/netbsd-current/src/sys/arch/arm/broadcom/bcm2835_gpio.c:117:3: error: 'minpin' undeclared (first use in this function)
   minpin = 32;
   ^
*** [bcm2835_gpio.o] Error code 1

The fix is trivial (attached below).
>How-To-Repeat:
Attempt to compile a kernel without NGPIO defined.
>Fix:
--- bcm2835_gpio.c.orig 2014-04-22 14:51:35.000000000 -0400
+++ bcm2835_gpio.c      2014-05-17 18:43:53.000000000 -0400
@@ -100,8 +100,9 @@
 bcmgpio_attach(device_t parent, device_t self, void *aux)
 {
        struct bcmgpio_softc * const sc = device_private(self);
+       int minpin, maxpin;
 #if NGPIO > 0
-       int pin, minpin, maxpin;
+       int pin;
        u_int func;
        struct gpiobus_attach_args gba;
 #endif

>Release-Note:

>Audit-Trail:
From: "David H. Gutteridge" <dhgutteridge@sympatico.ca>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: port-evbarm/48816: Compile fix for src/sys/arch/arm/broadcom/bcm2835_gpio.c
Date: Sat, 17 May 2014 19:30:30 -0400

 Bah, that should be "Attempt to compile a kernel when NGPIO > 0 is false."

 Dave

From: "Nick Hudson" <skrll@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/48816 CVS commit: src/sys/arch/arm/broadcom
Date: Mon, 19 May 2014 08:33:41 +0000

 Module Name:	src
 Committed By:	skrll
 Date:		Mon May 19 08:33:41 UTC 2014

 Modified Files:
 	src/sys/arch/arm/broadcom: bcm2835_gpio.c

 Log Message:
 Build fix for when there is no gpio in the kernel.

 PR/48816: Compile fix for src/sys/arch/arm/broadcom/bcm2835_gpio.c


 To generate a diff of this commit:
 cvs rdiff -u -r1.1 -r1.2 src/sys/arch/arm/broadcom/bcm2835_gpio.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "David H. Gutteridge" <dhgutteridge@sympatico.ca>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: port-evbarm/48816: Compile fix for src/sys/arch/arm/broadcom/bcm2835_gpio.c
Date: Mon, 19 May 2014 16:42:46 -0400

 This can be closed, thanks.

 Dave

From: "David H. Gutteridge" <dhgutteridge@sympatico.ca>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: port-evbarm/48816: Compile fix for src/sys/arch/arm/broadcom/bcm2835_gpio.c
Date: Mon, 19 May 2014 16:44:07 -0400

 This can be closed, thanks.

 Dave

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Mon, 19 May 2014 22:58:27 +0000
State-Changed-Why:
Confirmed fixed, thanks.


>Unformatted:

Home	PR Database Search