NetBSD Problem Report #49051

From www@NetBSD.org  Tue Jul 29 15:22:40 2014
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id E8614A825B
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 29 Jul 2014 15:22:39 +0000 (UTC)
Message-Id: <20140729152238.3FC3AA825D@mollari.NetBSD.org>
Date: Tue, 29 Jul 2014 15:22:38 +0000 (UTC)
From: venture37@geeklan.co.uk
Reply-To: venture37@geeklan.co.uk
To: gnats-bugs@NetBSD.org
Subject: Unbreak devel/git on Mac OS X Tiger
X-Send-Pr-Version: www-1.0

>Number:         49051
>Notify-List:    bsiegert@NetBSD.org
>Category:       pkg
>Synopsis:       Unbreak devel/git-base on Mac OS X Tiger
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    schmonz
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Jul 29 15:25:00 +0000 2014
>Closed-Date:    Thu Nov 20 21:54:32 +0000 2014
>Last-Modified:  Thu Nov 20 21:54:32 +0000 2014
>Originator:     Sevan Janiyan
>Release:        
>Organization:
>Environment:
Darwin 8.11.0 Darwin Kernel Version 8.11.0: Wed Oct 10 18:26:00 PDT 2007; root:xnu-792.24.17~1/RELEASE_PPC Power Macintosh powerpc
>Description:
The Apple CommonCrypto components required by git were not introduced until Darwin 9 / Leopard so build fails on previous releases

In file included from git-compat-util.h:330,
                 from cache.h:4,
                 from credential-store.c:1:
compat/apple-common-crypto.h:5:37: error: CommonCrypto/CommonHMAC.h: No such file or directory

Attached diff sets the build to use openssl instead.
>How-To-Repeat:

>Fix:
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/devel/git-base/Makefile,v
retrieving revision 1.15
diff -u -r1.15 Makefile
--- Makefile    2 Jun 2014 16:32:36 -0000       1.15
+++ Makefile    29 Jul 2014 15:20:21 -0000
@@ -92,6 +92,10 @@

 LDFLAGS.SunOS+=                -lintl -lnsl

+.if !empty(MACHINE_PLATFORM:MDarwin-[0-8].*-*)
+MAKE_FLAGS+=   NO_APPLE_COMMON_CRYPTO=1
+.endif
+
 .include "../../mk/compiler.mk"
 .if !empty(PKGSRC_COMPILER:Mclang)
 # configure test gets confused by wrappers dropping -R /

>Release-Note:

>Audit-Trail:
From: Venture37 <venture37@geeklan.co.uk>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/49051: Unbreak devel/git on Mac OS X Tiger
Date: Tue, 29 Jul 2014 16:31:53 +0100

 Sorry, that should've been devel/git-base

Responsible-Changed-From-To: pkg-manager->darwin-pkg-people
Responsible-Changed-By: hauke@NetBSD.org
Responsible-Changed-When: Tue, 29 Jul 2014 18:30:02 +0000
Responsible-Changed-Why:
This is macosx specific.


Responsible-Changed-From-To: darwin-pkg-people->schmonz
Responsible-Changed-By: schmonz@NetBSD.org
Responsible-Changed-When: Fri, 01 Aug 2014 19:25:27 +0000
Responsible-Changed-Why:
I committed an update that should fix the problem. Can you confirm?


State-Changed-From-To: open->feedback
State-Changed-By: schmonz@NetBSD.org
State-Changed-When: Fri, 01 Aug 2014 19:25:27 +0000
State-Changed-Why:
Awaiting confirmation that git-base-1.9.4nb1 builds and works for OP.


From: venture37 <venture37@geeklan.co.uk>
To: gnats-bugs@NetBSD.org, schmonz@NetBSD.org, 
 darwin-pkg-people@netbsd.org, pkgsrc-bugs@netbsd.org, 
 gnats-admin@netbsd.org
Cc: 
Subject: Re: pkg/49051 (Unbreak devel/git-base on Mac OS X Tiger)
Date: Sat, 02 Aug 2014 02:06:57 +0100

 -----BEGIN PGP SIGNED MESSAGE-----
 Hash: SHA1

 This fixed the initial build issue, what follows is the install stage
 breaking when running a pbulk as an unprivileged user as tar tries to
 set ownership information of files.

 (cd blt && /usr/bin/tar cf - .) | \
 (cd
 '/tmp/devel/git-base/work/.destdir/usr/pkg/share/git-core/templates'
 && umask 022 && /usr/bin/tar xof -)
 /usr/bin/tar: ./branches: Cannot change ownership to uid 503, gid 0:
 Operation not permitted
 /usr/bin/tar: ./description: Cannot change ownership to uid 503, gid
 0: Operation not permitted
 /usr/bin/tar: ./hooks/applypatch-msg.sample: Cannot change ownership
 to uid 503, gid 0: Operation not permitted
 /usr/bin/tar: ./hooks/commit-msg.sample: Cannot change ownership to
 uid 503, gid 0: Operation not permitted
 /usr/bin/tar: ./hooks/post-update.sample: Cannot change ownership to
 uid 503, gid 0: Operation not permitted
 /usr/bin/tar: ./hooks/pre-applypatch.sample: Cannot change ownership
 to uid 503, gid 0: Operation not permitted
 /usr/bin/tar: ./hooks/pre-commit.sample: Cannot change ownership to
 uid 503, gid 0: Operation not permitted
 /usr/bin/tar: ./hooks/pre-push.sample: Cannot change ownership to uid
 503, gid 0: Operation not permitted
 /usr/bin/tar: ./hooks/pre-rebase.sample: Cannot change ownership to
 uid 503, gid 0: Operation not permitted
 /usr/bin/tar: ./hooks/prepare-commit-msg.sample: Cannot change
 ownership to uid 503, gid 0: Operation not permitted
 /usr/bin/tar: ./hooks/update.sample: Cannot change ownership to uid
 503, gid 0: Operation not permitted
 /usr/bin/tar: ./hooks: Cannot change ownership to uid 503, gid 0:
 Operation not permitted
 /usr/bin/tar: ./info/exclude: Cannot change ownership to uid 503, gid
 0: Operation not permitted
 /usr/bin/tar: ./info: Cannot change ownership to uid 503, gid 0:
 Operation not permitted
 /usr/bin/tar: Error exit delayed from previous errors
 Makefile:64: recipe for target 'install' failed
 gmake[1]: *** [install] Error 2
 gmake[1]: Leaving directory
 '/private/tmp/devel/git-base/work/git-1.9.4/templates'
 Makefile:2335: recipe for target 'install' failed
 gmake: *** [install] Error 2
 *** Error code 2





 Patch below fixes this


 cvs diff: Diffing patches
 Index: distinfo
 ===================================================================
 RCS file: /cvsroot/pkgsrc/devel/git-base/distinfo,v
 retrieving revision 1.15
 diff -u -r1.15 distinfo
 - --- distinfo    1 Aug 2014 19:18:39 -0000       1.15
 +++ distinfo    2 Aug 2014 00:58:27 -0000
 @@ -3,7 +3,7 @@
  SHA1 (git-1.9.4.tar.xz) = a91059d0065d82c6c2db6d69b56033a01b10eac8
  RMD160 (git-1.9.4.tar.xz) = 742b8d73fa205b34b2c2843260d94787099b6030
  Size (git-1.9.4.tar.xz) = 3387180 bytes
 - -SHA1 (patch-aa) = 62170081fcf3831ba7316b5914657063c668a80b
 +SHA1 (patch-aa) = db795ad7258bd47ce26a4dc8d18a9886d74f3f5c
  SHA1 (patch-ac) = 376cdd1c58b143c820ff6395987a8a77cf9b52ba
  SHA1 (patch-ae) = 9bc2e6c7f0a8fbc385b6ffda638d3245a62dc5ca
  SHA1 (patch-af) = d1aae6d9b15f7932912a97457d8a95364b685b07
 Index: patches/patch-aa
 ===================================================================
 RCS file: /cvsroot/pkgsrc/devel/git-base/patches/patch-aa,v
 retrieving revision 1.3
 diff -u -r1.3 patch-aa
 - --- patches/patch-aa    1 Aug 2014 19:18:39 -0000       1.3
 +++ patches/patch-aa    2 Aug 2014 00:58:27 -0000
 @@ -36,7 +36,12 @@

   export DIFF TAR INSTALL DESTDIR SHELL_PATH

 - -@@ -2353,7 +2347,6 @@ ifndef NO_GETTEXT
 +@@ -2349,11 +2343,10 @@ install: all
 + ifndef NO_GETTEXT
 +       $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(localedir_SQ)'
 +       (cd po/build/locale && $(TAR) cf - .) | \
 +-      (cd '$(DESTDIR_SQ)$(localedir_SQ)' && umask 022 && $(TAR) xof -)
 ++      (cd '$(DESTDIR_SQ)$(localedir_SQ)' && umask 022 && $(TAR) xf -)
   endif
   ifndef NO_PERL
         $(MAKE) -C perl prefix='$(prefix_SQ)' DESTDIR='$(DESTDIR_SQ)'
 install
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

 iQIcBAEBAgAGBQJT3DmwAAoJENE/+DdOy3tCAtkP/jCfRVahg5hu8djJA897pYWg
 xSbR6bnGy4GdZTk0uXyDrqxL+iWxpcpGwHLeKRSCSXQmmEA6jqEnM5V2+19WrM/Q
 +TQcegdUrw+HuJ/rQuVdzpSrybQd0/UYNKmYcngctrFCmHfUFXaOId3wCwNbsCUq
 uEJEYHpezdhLFsBrwa3XQNMrmHcVgGRSO/PAoGJl0qnEspu3m6ueese9yFXtAotg
 DprVTcmPPOMwUA4CEHhWCoFgdpUmFX5Kk2nUFDXePtBdiIiNg/lb4Dc8RjxavfVA
 UhqQWlRpPoxQyRdSB2zmqryP1mYjQcgGPNApqJRo1n15DXTJAL8u9/5aBKchOTIJ
 CU2j+MiecTBsrGXYvxsUVVex0l8d05kaCWDJSvQXm8fvSh8AKn8UIEFMlHPO1I7S
 FkOhibm6HeabcrMmA5gFispp9tCAilIg+P6GeEWTZD8d3RCRu+V36pjcQoXuCUb9
 4xBnalLfFsji3VRrUi5IXFfr9mIyLzvlG30CZJLuRSJJkrniiDvyEdRWWQ/EMe0d
 Dob09hzpqCHyX3nJREO3YASZRlmlTSdw61zlSD/VHFhv9X7BVxfK32WTLEZIomQ8
 GeJPYAtyf+ZPIQiqG8Qn1143Q0ZhHu/cjFQ1Yp1X41ki+28b0oq8xYqDVBhKyHUL
 vfS8mQGhVRMZ4YZvdMEq
 =73Sn
 -----END PGP SIGNATURE-----

From: Venture37 <venture37@geeklan.co.uk>
To: gnats-bugs@NetBSD.org, schmonz@NetBSD.org, gnats-admin@netbsd.org, 
 pkgsrc-bugs@netbsd.org
Cc: 
Subject: Re: pkg/49051 (Unbreak devel/git-base on Mac OS X Tiger)
Date: Sun, 10 Aug 2014 18:03:58 +0100

 Tried building git-base on another G4 running Tiger, same failure, this 
 second diff is needed.

From: venture37 <venture37@geeklan.co.uk>
To: gnats-bugs@NetBSD.org, schmonz@NetBSD.org, gnats-admin@netbsd.org, 
 pkgsrc-bugs@netbsd.org
Cc: 
Subject: Re: pkg/49051 (Unbreak devel/git-base on Mac OS X Tiger)
Date: Mon, 18 Aug 2014 00:09:41 +0100

 On 10/08/2014 18:10, Venture37 wrote:
 > Tried building git-base on another G4 running Tiger, same failure,
 > this second diff is needed.

 Confirmed on a new system, again, exhibiting the same behaviour

 /usr/bin/tar: ./bg/LC_MESSAGES/git.mo: Cannot change ownership to uid
 502, gid 20: Operation not permitted
 /usr/bin/tar: ./bg/LC_MESSAGES: Cannot change ownership to uid 502, gid
 20: Operation not permitted



 Sevan

From: "Benny Siegert" <bsiegert@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/49051 CVS commit: pkgsrc/devel/git-base
Date: Thu, 20 Nov 2014 21:43:10 +0000

 Module Name:	pkgsrc
 Committed By:	bsiegert
 Date:		Thu Nov 20 21:43:10 UTC 2014

 Modified Files:
 	pkgsrc/devel/git-base: distinfo
 	pkgsrc/devel/git-base/patches: patch-aa

 Log Message:
 Do not attempt to set ownership of some files, this breaks unprivileged
 builds on Mac OS X Tiger.

 Patch provided by Sevan Janiyan in PR pkg/49051.


 To generate a diff of this commit:
 cvs rdiff -u -r1.18 -r1.19 pkgsrc/devel/git-base/distinfo
 cvs rdiff -u -r1.3 -r1.4 pkgsrc/devel/git-base/patches/patch-aa

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: feedback->closed
State-Changed-By: bsiegert@NetBSD.org
State-Changed-When: Thu, 20 Nov 2014 21:54:32 +0000
State-Changed-Why:
Patch applied, thanks!


>Unformatted:

Home	PR Database Search