NetBSD Problem Report #49062

From oster@cs.usask.ca  Fri Aug  1 19:29:29 2014
Return-Path: <oster@cs.usask.ca>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 4568FA891A
	for <gnats-bugs@gnats.NetBSD.org>; Fri,  1 Aug 2014 19:29:29 +0000 (UTC)
Message-Id: <20140801192924.BC65887D4D@mickey.usask.ca>
Date: Fri,  1 Aug 2014 13:29:24 -0600 (CST)
From: oster@netbsd.org
Reply-To: oster@netbsd.org
To: gnats-bugs@gnats.NetBSD.org
Subject: mail/thunderbird fails to build on NetBSD-6.1.4/amd64
X-Send-Pr-Version: 3.95

>Number:         49062
>Category:       pkg
>Synopsis:       mail/thunderbird fails to build on NetBSD-6.1.4/amd64
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Aug 01 19:30:00 +0000 2014
>Closed-Date:    Wed Sep 04 22:30:56 +0000 2019
>Last-Modified:  Wed Sep 04 22:30:56 +0000 2019
>Originator:     Greg Oster
>Release:        NetBSD 6.1.4
>Organization:
>Environment:


System: NetBSD mickey 6.1.4 NetBSD 6.1.4 (QUAD) #0: Mon Apr 14 12:36:07 CST 2014 oster@quad:/u1/builds/build249/src/obj/amd64/u1/builds/build249/src/sys/arch/amd64/compile/QUAD amd64
Architecture: x86_64
Machine: amd64
>Description:

misc/thunderbird fails to build on NetBSD-6.1.4/amd64 with the following error:

...

===> Overriding tools for thunderbird-31.0
===> Extracting for thunderbird-31.0
===> Patching for thunderbird-31.0
=> Applying pkgsrc patches for thunderbird-31.0
No such line 315 in input file, ignoring
===> Creating toolchain wrappers for thunderbird-31.0
src=/usr/X11R7/lib/pkgconfig/fixesproto.pc  dst=/usr/pkgsrc/mail/thunderbird/work.mickey/.buildlink/lib/pkgconfig/fixesext.pc;  /bin/mkdir -p /usr/pkgsrc/mail/thunderbird/work.mickey/.buildlink/lib/pkgconfig;  if test -f ${src}; then  /bin/ln -sf ${src} ${dst};  fi
src=/usr/X11R7/lib/pkgconfig/compositeproto.pc  dst=/usr/pkgsrc/mail/thunderbird

...

c++ -o nsMailGNOMEIntegration.o -c -I../../../mozilla/dist/stl_wrappers -I../../../mozilla/dist/system_wrappers -include /usr/pkgsrc/mail/thunderbird/work.mickey/comm-esr31/mozilla/config/gcc_hidden.h -DMOZ_APP_NAME=\"thunderbird\" -DMOZ_GLUE_IN_PROGRAM -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEXPORT_XPT_API -DEXPORT_XPTC_API -D_IMPL_NS_GFX -D_IMPL_NS_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET -DIMPL_THEBES  -DOSTYPE=\"NetBSD6.1\" -DOSARCH=NetBSD -DNO_NSPR_10_SUPPORT  -I/usr/pkgsrc/mail/thunderbird/work.mickey/comm-esr31/mail/components/shell -I. -I../../../mozilla/dist/include -I../../../mozilla/dist/include/nsprpub  -I/usr/pkg/include/nspr -I/usr/pkg/include/nss/nss -I/usr/pkg/include/nss -I/usr/pkg/include/nspr   -I/usr/pkgsrc/mail/thunderbird/work.mickey/build/mozilla/dist/include  -I/usr/pkg/include/pixman-1    -fPIC -DPIC -I/usr/pkg/include -I/usr/include -I/usr/pkg/include/nspr -I/usr/pkg/include/nss/nss -I/usr/X11R7/include -I/usr/X11R7/include/libdrm -I/usr/X11R7/include/free
 type2 -Wall -Wpointer-arith -Woverloaded-virtual -Werror=return-type -Werror=int-to-pointer-cast -Wtype-limits -Wempty-body -Wsign-compare -Wno-invalid-offsetof -Wcast-align -O2 -I/usr/pkg/include -I/usr/include -I/usr/pkg/include/nspr -I/usr/pkg/include/nss/nss -I/usr/X11R7/include -I/usr/X11R7/include/libdrm -I/usr/X11R7/include/freetype2 -fno-exceptions -fno-strict-aliasing -Dunix -fno-rtti -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -pipe  -DNDEBUG -DTRIMMED -g -O2 -fomit-frame-pointer -pthread -D_REENTRANT -I/usr/pkg/include/gtk-2.0 -I/usr/pkg/include/gtk-unix-print-2.0 -I/usr/pkg/include/gtk-2.0 -I/usr/pkg/include/atk-1.0 -I/usr/pkg/include/gtk-2.0 -I/usr/pkg/lib/gtk-2.0/include -I/usr/pkg/include/pango-1.0 -I/usr/pkg/include/harfbuzz -I/usr/pkg/include/pango-1.0 -I/usr/pkg/include/glib/gio-unix-2.0/ -I/usr/X11R7/include -I/usr/pkg/include/gdk-pixbuf-2.0 -I/usr/pkg/include/libpng16 -I/usr/pkg/include/glib/glib-2.0 -I/usr/pkg/lib/glib-2.0/include -I/usr/pkg/in
 clude -I/usr/pkg/include/cairo -I/usr/pkg/include/pixman-1 -I/usr/pkg/include -I/usr/X11R7/include/freetype2 -I/usr/X11R7/include -I/usr/X11R7/include/freetype2 -I/usr/X11R7/include -I/usr/pkg/include/libpng16 -I/usr/X11R7/include   -I/usr/pkg/include -I/usr/include -I/usr/pkg/include/nspr -I/usr/pkg/include/nss/nss -I/usr/X11R7/include -I/usr/X11R7/include/libdrm -I/usr/X11R7/include/freetype2 -DMOZILLA_CLIENT -include ../../../mozilla/mozilla-config.h -MD -MP -MF .deps/nsMailGNOMEIntegration.o.pp /usr/pkgsrc/mail/thunderbird/work.mickey/comm-esr31/mail/components/shell/nsMailGNOMEIntegration.cpp
/usr/pkgsrc/mail/thunderbird/work.mickey/comm-esr31/mail/components/shell/nsMailGNOMEIntegration.cpp:64:1: error: narrowing conversion of 'mozilla::ArrayLength [with T = const char* const, long unsigned int N = 1ul, size_t = long unsigned int](((const char* const (&)[1])(& sMailProtocols)))' from 'size_t' to 'unsigned int' inside { }
/usr/pkgsrc/mail/thunderbird/work.mickey/comm-esr31/mail/components/shell/nsMailGNOMEIntegration.cpp:64:1: error: narrowing conversion of 'mozilla::ArrayLength [with T = const char* const, long unsigned int N = 3ul, size_t = long unsigned int](((const char* const (&)[3])(& sNewsProtocols)))' from 'size_t' to 'unsigned int' inside { }
/usr/pkgsrc/mail/thunderbird/work.mickey/comm-esr31/mail/components/shell/nsMailGNOMEIntegration.cpp:64:1: error: narrowing conversion of 'mozilla::ArrayLength [with T = const char* const, long unsigned int N = 1ul, size_t = long unsigned int](((const char* const (&)[1])(& sFeedProtocols)))' from 'size_t' to 'unsigned int' inside { }
/usr/pkgsrc/mail/thunderbird/work.mickey/comm-esr31/config/rules.mk:960: recipe for target 'nsMailGNOMEIntegration.o' failed
gmake[4]: *** [nsMailGNOMEIntegration.o] Error 1
gmake[4]: *** Waiting for unfinished jobs....
gmake[4]: Leaving directory '/usr/pkgsrc/mail/thunderbird/work.mickey/build/mail/components/shell'
/usr/pkgsrc/mail/thunderbird/work.mickey/comm-esr31/config/recurse.mk:44: recipe for target 'libs' failed
gmake[3]: *** [libs] Error 2
gmake[3]: Leaving directory '/usr/pkgsrc/mail/thunderbird/work.mickey/build/mail/components'
/usr/pkgsrc/mail/thunderbird/work.mickey/comm-esr31/mozilla/config/recurse.mk:153: recipe for target 'libs' failed
gmake[2]: *** [libs] Error 2
gmake[2]: Leaving directory '/usr/pkgsrc/mail/thunderbird/work.mickey/build/mozilla'
/usr/pkgsrc/mail/thunderbird/work.mickey/comm-esr31/mozilla/config/rules.mk:592: recipe for target 'default' failed
gmake[1]: *** [default] Error 2
gmake[1]: Leaving directory '/usr/pkgsrc/mail/thunderbird/work.mickey/build/mozilla'
Makefile:52: recipe for target 'default' failed
gmake: *** [default] Error 2
*** Error code 2

Stop.
make: stopped in /usr/pkgsrc/mail/thunderbird
*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/mail/thunderbird



I included the patching portion of this, as I suspect it might be related.


>How-To-Repeat:

	cd /usr/pkgsrc/mail/thunderbird
        make install


>Fix:
	please.  thanks.

>Release-Note:

>Audit-Trail:
From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/49062: mail/thunderbird fails to build on NetBSD-6.1.4/amd64
Date: Fri, 8 Aug 2014 05:38:13 +0000

 On Fri, Aug 01, 2014 at 07:30:00PM +0000, oster@netbsd.org wrote:
  > => Applying pkgsrc patches for thunderbird-31.0
  > No such line 315 in input file, ignoring

 Can you try this with PKG_DEVELOPER set so you can see which patch it
 comes from? None of the patches seem to contain a reference to line 315.

 (I don't have the distfile to try it myself)

 -- 
 David A. Holland
 dholland@netbsd.org

From: Greg Oster <oster@cs.usask.ca>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/49062: mail/thunderbird fails to build on
 NetBSD-6.1.4/amd64
Date: Fri, 8 Aug 2014 09:44:18 -0600

 On Fri,  8 Aug 2014 05:40:01 +0000 (UTC)
 David Holland <dholland-pbugs@netbsd.org> wrote:

 > The following reply was made to PR pkg/49062; it has been noted by
 > GNATS.
 > 
 > From: David Holland <dholland-pbugs@netbsd.org>
 > To: gnats-bugs@NetBSD.org
 > Cc: 
 > Subject: Re: pkg/49062: mail/thunderbird fails to build on
 > NetBSD-6.1.4/amd64 Date: Fri, 8 Aug 2014 05:38:13 +0000
 > 
 >  On Fri, Aug 01, 2014 at 07:30:00PM +0000, oster@netbsd.org wrote:
 >   > => Applying pkgsrc patches for thunderbird-31.0
 >   > No such line 315 in input file, ignoring
 >  
 >  Can you try this with PKG_DEVELOPER set so you can see which patch it
 >  comes from? None of the patches seem to contain a reference to line
 > 315. 
 >  (I don't have the distfile to try it myself)

 That error comes from here:

 => Applying pkgsrc
 patch /usr/pkgsrc/mail/thunderbird/patches/patch-mozilla_ipc_chromium_src_base_process__util.h
 Hmm...  Looks like a unified diff to me... The text leading up to this
 was: --------------------------
 |$NetBSD: patch-mozilla_ipc_chromium_src_base_process__util.h,v 1.5
 2013/11/12 20:50:51 ryoon Exp $ |
 |--- mozilla/ipc/chromium/src/base/process_util.h.orig  2013-10-23
 22:09:00.000000000 +0000 |+++
 mozilla/ipc/chromium/src/base/process_util.h --------------------------
 Patching file mozilla/ipc/chromium/src/base/process_util.h using Plan
 A... Hunk #1 succeeded at 13.
 Hunk #2 succeeded at 32.
 No such line 315 in input file, ignoring
 Hunk #3 succeeded at 252 (offset -67 lines).
 done

 which is this part of the patch:

 @@ -316,7 +319,7 @@ class NamedProcessIterator {
  #if defined(OS_WIN)
    HANDLE snapshot_;
    bool started_iteration_;
 -#elif defined(OS_LINUX) || defined(__GLIBC__)
 +#elif defined(OS_LINUX) || defined(__GLIBC__) || defined(OS_SOLARIS)
    DIR *procfs_dir_;
  #elif defined(OS_BSD)
    std::vector<ProcessEntry> content;

 But that part of the file occurs around line 255, and really isn't
 related to the NetBSD build... 

 A bit more digging reveals that in:

 /usr/pkgsrc/mail/thunderbird/work.mickey/comm-esr31/mail/components/shell/nsMailGNOMEIntegration.cpp

 we find at line 43:

 struct AppTypeAssociation {
   uint16_t type;
   const char * const *protocols;
   unsigned int protocolsLength;
   const char *mimeType;
   const char *extensions;
 };

 If I change protocolsLength to size_t, then thunderbird builds, and
 seems to work fine...

 Later...

 Greg Oster

State-Changed-From-To: open->closed
State-Changed-By: maya@NetBSD.org
State-Changed-When: Wed, 04 Sep 2019 22:30:56 +0000
State-Changed-Why:
Closing as stale: the relevant code has changed significantly. Assuming fixed. Sorry your patch was not applied t the time.


>Unformatted:

Home	PR Database Search