NetBSD Problem Report #49082

From www@NetBSD.org  Thu Aug  7 02:16:41 2014
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 3672EA9996
	for <gnats-bugs@gnats.NetBSD.org>; Thu,  7 Aug 2014 02:16:41 +0000 (UTC)
Message-Id: <20140807021639.CF739A9997@mollari.NetBSD.org>
Date: Thu,  7 Aug 2014 02:16:39 +0000 (UTC)
From: venture37@geeklan.co.uk
Reply-To: venture37@geeklan.co.uk
To: gnats-bugs@NetBSD.org
Subject: Unbreak lang/tcl on OS X Tiger
X-Send-Pr-Version: www-1.0

>Number:         49082
>Category:       pkg
>Synopsis:       Unbreak lang/tcl on OS X Tiger
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    dholland
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Aug 07 02:20:00 +0000 2014
>Closed-Date:    Sun May 01 04:27:21 +0000 2016
>Last-Modified:  Sun May 01 04:27:21 +0000 2016
>Originator:     Sevan Janiyan
>Release:        pkgsrc-current
>Organization:
>Environment:
Darwin 8.11.0 Darwin Kernel Version 8.11.0: Wed Oct 10 18:26:00 PDT 2007; 
root:xnu-792.24.17~1/RELEASE_PPC Power Macintosh powerpc
>Description:
TCL includes its own copy of sqlite, apply the same flags as databases/sqlite3 to handle building on Tiger as  it doesn't have gethostuuid(2) and lacks the zone memory allocator
>How-To-Repeat:

>Fix:
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/lang/tcl/Makefile,v
retrieving revision 1.77
diff -u -r1.77 Makefile
--- Makefile    13 Mar 2014 11:08:51 -0000      1.77
+++ Makefile    7 Aug 2014 02:13:33 -0000
@@ -36,6 +36,13 @@
 CONFIGURE_ARGS+=       --enable-64bit
 .endif

+# Darwin < 9 (Mac OS X < 10.5 "Leopard") doesn't have gethostuuid(2)
+# and lacks the zone memory allocator
+.if !empty(MACHINE_PLATFORM:MDarwin-[0-8].*-*)
+CFLAGS+=              -DSQLITE_ENABLE_LOCKING_STYLE=0
+CPPFLAGS+=             -DSQLITE_WITHOUT_ZONEMALLOC
+.endif
+
 SUBST_CLASSES+=                tcl-config
 SUBST_STAGE.tcl-config=        post-build
 SUBST_FILES.tcl-config=        unix/tclConfig.sh

>Release-Note:

>Audit-Trail:
From: Thomas Klausner <wiz@NetBSD.org>
To: NetBSD bugtracking <gnats-bugs@NetBSD.org>
Cc: 
Subject: Re: pkg/49082: Unbreak lang/tcl on OS X Tiger
Date: Thu, 7 Aug 2014 08:41:34 +0200

 On Thu, Aug 07, 2014 at 02:20:00AM +0000, venture37@geeklan.co.uk wrote:
 > TCL includes its own copy of sqlite

 Can we make it use pkgsrc's version instead?
  Thomas

From: venture37 <venture37@geeklan.co.uk>
To: gnats-bugs@NetBSD.org, pkg-manager@netbsd.org, 
 gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Cc: 
Subject: Re: pkg/49082: Unbreak lang/tcl on OS X Tiger
Date: Thu, 07 Aug 2014 15:02:08 +0100

 -----BEGIN PGP SIGNED MESSAGE-----
 Hash: SHA1

 On 07/08/2014 07:45, Thomas Klausner wrote:
 > Can we make it use pkgsrc's version instead?

 sure, the sqlite3 extension has a --with-system-sqlite option, will
 get it tested out & follow up with a new diff.
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

 iQIcBAEBAgAGBQJT44bgAAoJENE/+DdOy3tC8k0P/1PmnWnOQ+1Wt9GqHkTpaa3I
 m2+aUQEa8Pv1EGPVQYeCFz/OQzbznnKR0LwhDw4mRXVDzs56+xCOLZiIoddleeap
 YUIjXTMmAxxmR3DRHT0gJMK4Wl9psz82903Y7s/qXFNWpXwQpEPieS8a9qfZsWez
 zb7s1nHJJ1AU8RLfhlEd5yn2YO7JiyR0tUrwFjnvvg64q5Beq+9yendT4QmMBBlJ
 BQA9LgGcQYlLesXzGhvLVBPDMWsg745AEjdNj2yZA/OiylFBPXaDRcI8mjhzADih
 /hKKOnhjn2iewZlzZmHGFv1gBd5piVReXLwY44tdHfSDGeHYkmwhJkz4uYb37ofc
 O6LpVUHuMtSj94o2P9EOq/yKm0w70Ag44byVscgoC1Co/BiKX7IvIswWbmMgLMJd
 bg9Cl4Lr7ao1Nbg/Kyf0aZcHpWYaHP4/0HvpRKAGexc8ukDsncQcsMSYcBUnhHSt
 Msb3HRiBC3B+Id5NkL83A54HrSbbMQnTfqQshjZWZ72JlqfGdj9hLLDaGVlYAe9c
 FzvYV9fHUV44ld3GtSfLgMbzt39+atOZTKgzf6L9Gr1tVPiy453gIQcnq0U1lu9o
 IOaHeKZWijjjK8NKEmGTVmQFKb5fp4yhjm9vg5FCjjjsfSge9DmnwNEz8yC+E6IM
 biCZOQ5Df+qHmtkOIPwm
 =4pJh
 -----END PGP SIGNATURE-----

From: venture37 <venture37@geeklan.co.uk>
To: gnats-bugs@NetBSD.org, pkg-manager@netbsd.org, 
 gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Cc: 
Subject: Re: pkg/49082: Unbreak lang/tcl on OS X Tiger
Date: Fri, 08 Aug 2014 02:38:35 +0100

 On 07/08/2014 15:05, venture37 wrote:
 >  sure, the sqlite3 extension has a --with-system-sqlite option, will
 >  get it tested out & follow up with a new diff.
 >  

 looking in work/tcl8.6.1/pkgs/sqlite3.8.0/configure I found

 #--------------------------------------------------------------------
 # The --with-system-sqlite causes the TCL bindings to SQLite to use
 # the system shared library for SQLite rather than statically linking
 # against its own private copy.  This is dangerous and leads to
 # undersirable dependences and is not recommended.
 # Patchs from rmax.
 #--------------------------------------------------------------------


 Probably best to stick with building the private copy?



 Sevan

From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/49082: Unbreak lang/tcl on OS X Tiger
Date: Fri, 8 Aug 2014 05:20:58 +0000

 On Fri, Aug 08, 2014 at 01:40:01AM +0000, venture37 wrote:
  >  looking in work/tcl8.6.1/pkgs/sqlite3.8.0/configure I found
  >  
  >  #--------------------------------------------------------------------
  >  # The --with-system-sqlite causes the TCL bindings to SQLite to use
  >  # the system shared library for SQLite rather than statically linking
  >  # against its own private copy.  This is dangerous and leads to
  >  # undersirable dependences and is not recommended.
  >  # Patchs from rmax.
  >  #--------------------------------------------------------------------
  >  
  >  
  >  Probably best to stick with building the private copy?

 Would be nice if they bothered to explain why they think it's
 dangerous...

 -- 
 David A. Holland
 dholland@netbsd.org

From: venture37 <venture37@geeklan.co.uk>
To: gnats-bugs@NetBSD.org, pkg-manager@netbsd.org, 
 gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Cc: 
Subject: Re: pkg/49082: Unbreak lang/tcl on OS X Tiger
Date: Wed, 08 Oct 2014 01:54:55 +0100

 On 08/08/2014 06:25, David Holland wrote:
 >  On Fri, Aug 08, 2014 at 01:40:01AM +0000, venture37 wrote:
 >   >  looking in work/tcl8.6.1/pkgs/sqlite3.8.0/configure I found
 >   >  
 >   >  #--------------------------------------------------------------------
 >   >  # The --with-system-sqlite causes the TCL bindings to SQLite to use
 >   >  # the system shared library for SQLite rather than statically linking
 >   >  # against its own private copy.  This is dangerous and leads to
 >   >  # undersirable dependences and is not recommended.
 >   >  # Patchs from rmax.
 >   >  #--------------------------------------------------------------------
 >   >  
 >   >  
 >   >  Probably best to stick with building the private copy?
 >  
 >  Would be nice if they bothered to explain why they think it's
 >  dangerous...

 Looks like it's a generic warning so that tcl is isolated from system
 upgrades.

 Response from devs on IRC:
 "simply put, you don't control the system sqlite or when it gets
 upgraded or possibly breaking the interfaces you're using."

 So TCL could be switched to use --with-system-sqlite.

 I'll follow up with a new patch later this week.

From: venture37 <venture37@geeklan.co.uk>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/49082: Unbreak lang/tcl on OS X Tiger
Date: Thu, 30 Oct 2014 17:04:50 +0000

 Just to keep things up to date, building lang/tcl --with-system-sqlite
 results in the prebuilt sqlite binary being bundled with the package.

From: Thomas Klausner <wiz@NetBSD.org>
To: NetBSD bugtracking <gnats-bugs@NetBSD.org>
Cc: 
Subject: Re: pkg/49082: Unbreak lang/tcl on OS X Tiger
Date: Wed, 10 Dec 2014 14:04:55 +0100

 On Thu, Oct 30, 2014 at 05:10:05PM +0000, venture37 wrote:
 >  Just to keep things up to date, building lang/tcl --with-system-sqlite
 >  results in the prebuilt sqlite binary being bundled with the package.

 Just to make sure I understand correctly: the tcl binary package then
 contains the file bin/sqlite3 from the sqlite3 package?

 If so, then I think that's really not correct and should be changed.
  Thomas

From: Sevan <venture37@geeklan.co.uk>
To: "gnats-bugs@NetBSD.org" <gnats-bugs@NetBSD.org>
Cc: "pkg-manager@netbsd.org" <pkg-manager@netbsd.org>,
 "gnats-admin@netbsd.org" <gnats-admin@netbsd.org>,
 "pkgsrc-bugs@netbsd.org" <pkgsrc-bugs@netbsd.org>
Subject: Re: pkg/49082: Unbreak lang/tcl on OS X Tiger
Date: Wed, 10 Dec 2014 13:14:06 +0000

 > On 10 Dec 2014, at 13:05, Thomas Klausner <wiz@NetBSD.org> wrote:
 > 
 > Just to make sure I understand correctly: the tcl binary package then
 > contains the file bin/sqlite3 from the sqlite3 package?


 Correct :/

From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/49082: Unbreak lang/tcl on OS X Tiger
Date: Wed, 10 Dec 2014 16:57:50 +0000

 On Wed, Dec 10, 2014 at 01:05:01PM +0000, Thomas Klausner wrote:
  >  On Thu, Oct 30, 2014 at 05:10:05PM +0000, venture37 wrote:
  >  >  Just to keep things up to date, building lang/tcl --with-system-sqlite
  >  >  results in the prebuilt sqlite binary being bundled with the package.
  >  
  >  Just to make sure I understand correctly: the tcl binary package then
  >  contains the file bin/sqlite3 from the sqlite3 package?
  >  
  >  If so, then I think that's really not correct and should be changed.

 Yes, that's what I've been thinking.

 (haven't had time to tackle it)

 -- 
 David A. Holland
 dholland@netbsd.org

Responsible-Changed-From-To: pkg-manager->dholland
Responsible-Changed-By: bsiegert@NetBSD.org
Responsible-Changed-When: Sat, 04 Jul 2015 11:55:42 +0000
Responsible-Changed-Why:
Sevan says that he understands you were going to fix it.
Is that right?


From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/49082 (Unbreak lang/tcl on OS X Tiger)
Date: Mon, 6 Jul 2015 04:51:15 +0000

 On Sat, Jul 04, 2015 at 11:55:42AM +0000, bsiegert@NetBSD.org wrote:
  > Sevan says that he understands you were going to fix it.
  > Is that right?

 I was? Well, I can look at it...

 ...cannot repeat the problem. I added

    CONFIGURE_ARGS+= --with-system-sqlite
    .include "../../databases/sqlite3/buildlink3.mk"

 to lang/tcl/Makefile and the resulting tcl package does not have
 anything named '*sql*' in it that appears to be copied from /usr.
 (This is on netbsd with native sqlite.)

 There is a usr/pkg/lib/sqlite3.8.8.3/libsqlite3.8.8.3.so, but that
 appears to be the tcl plugin library; it is linked to
 /usr/lib/libsqlite3.so.1 and is not the same as it.

 (Why tcl sprinkles its plugins outside of /usr/pkg/lib/tcl* is beyond
 me, but that's upstream's problem until it conflicts with something we
 care about.)

 I also can't find anything in the build system in the distfile that
 would have the effect described. Setting --with-system-sqlite replaces
 an include of the sqlite amalgamation .c file with <sqlite.h> and adds
 -lsqlite3, and doesn't appear to have any other effect at all that I
 can find.

 -- 
 David A. Holland
 dholland@netbsd.org

From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/49082 CVS commit: pkgsrc/lang/tcl
Date: Fri, 10 Jul 2015 18:48:22 +0000

 Module Name:	pkgsrc
 Committed By:	dholland
 Date:		Fri Jul 10 18:48:22 UTC 2015

 Modified Files:
 	pkgsrc/lang/tcl: Makefile

 Log Message:
 Use pkgsrc sqlite instead of included copy. PKGREVISION -> 2.
 PR 49082.


 To generate a diff of this commit:
 cvs rdiff -u -r1.79 -r1.80 pkgsrc/lang/tcl/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->feedback
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Fri, 10 Jul 2015 18:51:53 +0000
State-Changed-Why:
Changed to use pkgsrc sqlite; cannot find any trace of the problem where
it copies the .so file, so please check if it's still happening for you.


From: Hauke Fath <hf@spg.tu-darmstadt.de>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/49082 (Unbreak lang/tcl on OS X Tiger) 
Date: Thu, 27 Aug 2015 15:28:33 +0200

 FTR, undoing this change, i.e. reverting lang/tcl/Makefile to 1.79, 
 fixes the build problem from PR pkg/50170.

 hauke

From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/49082 (Unbreak lang/tcl on OS X Tiger)
Date: Mon, 1 Feb 2016 08:45:55 +0000

 On Thu, Aug 27, 2015 at 01:35:00PM +0000, Hauke Fath wrote:
  > The following reply was made to PR pkg/49082; it has been noted by GNATS.
  > 
  > From: Hauke Fath <hf@spg.tu-darmstadt.de>
  > To: gnats-bugs@netbsd.org
  > Cc: 
  > Subject: Re: pkg/49082 (Unbreak lang/tcl on OS X Tiger) 
  > Date: Thu, 27 Aug 2015 15:28:33 +0200
  > 
  >  FTR, undoing this change, i.e. reverting lang/tcl/Makefile to 1.79, 
  >  fixes the buikd problem from PR pkg/50170.

 50170 was fixed properly some time back; tcl should be working since.
 Still having problems?

 -- 
 David A. Holland
 dholland@netbsd.org

State-Changed-From-To: feedback->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sun, 01 May 2016 04:27:21 +0000
State-Changed-Why:
Fixed some time back.


>Unformatted:

Home	PR Database Search