NetBSD Problem Report #49122

From www@NetBSD.org  Sun Aug 17 09:42:03 2014
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 968B4ADABE
	for <gnats-bugs@gnats.NetBSD.org>; Sun, 17 Aug 2014 09:42:03 +0000 (UTC)
Message-Id: <20140817094202.0D165ADBA6@mollari.NetBSD.org>
Date: Sun, 17 Aug 2014 09:42:02 +0000 (UTC)
From: henning.petersen@t-online.de
Reply-To: henning.petersen@t-online.de
To: gnats-bugs@NetBSD.org
Subject: Missing cmd in printf (abtn.c)
X-Send-Pr-Version: www-1.0

>Number:         49122
>Category:       port-macppc
>Synopsis:       Missing cmd in printf (abtn.c)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    port-macppc-maintainer
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Aug 17 09:45:00 +0000 2014
>Closed-Date:    Sun Aug 17 10:02:07 +0000 2014
>Last-Modified:  Sun Aug 17 10:05:01 +0000 2014
>Originator:     Henning Petersen
>Release:        
>Organization:
>Environment:
>Description:
Missing parameter in printf.
>How-To-Repeat:

>Fix:
diff -u -p -r1.19 abtn.c
--- sys/arch/macppc/dev/abtn.c	27 Oct 2012 17:18:00 -0000	1.19
+++ sys/arch/macppc/dev/abtn.c	17 Aug 2014 09:23:30 -0000
@@ -192,6 +192,6 @@ abtn_adbcomplete(uint8_t *buffer, uint8_

 	default:
 		printf("%s: unknown button 0x%x\n",
-		       device_xname(sc->sc_dev));
+		       device_xname(sc->sc_dev), cmd);
 	}
 }

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Sun, 17 Aug 2014 10:02:07 +0000
State-Changed-Why:
Fixed, thanks.


From: "Thomas Klausner" <wiz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/49122 CVS commit: src/sys/arch/macppc/dev
Date: Sun, 17 Aug 2014 10:01:49 +0000

 Module Name:	src
 Committed By:	wiz
 Date:		Sun Aug 17 10:01:49 UTC 2014

 Modified Files:
 	src/sys/arch/macppc/dev: abtn.c

 Log Message:
 Add missing parameter in printf. From Henning Petersen in PR 49122.


 To generate a diff of this commit:
 cvs rdiff -u -r1.19 -r1.20 src/sys/arch/macppc/dev/abtn.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search