NetBSD Problem Report #49129

From iamleot@gmail.com  Tue Aug 19 23:06:39 2014
Return-Path: <iamleot@gmail.com>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 30DC6AE2D6
	for <gnats-bugs@gnats.netbsd.org>; Tue, 19 Aug 2014 23:06:39 +0000 (UTC)
Message-Id: <53f3d878.88afc20a.75f7.ffffebb4@mx.google.com>
Date: Tue, 19 Aug 2014 16:06:32 -0700 (PDT)
From: Leonardo Taccari <iamleot@gmail.com>
Reply-To: Leonardo Taccari <iamleot@gmail.com>
To: gnats-bugs@gnats.NetBSD.org
Subject: Update news/slrn to 1.0.1
X-Send-Pr-Version: 3.95

>Number:         49129
>Category:       pkg
>Synopsis:       Update news/slrn to 1.0.1
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Tue Aug 19 23:10:00 +0000 2014
>Closed-Date:    Sat Aug 23 09:36:03 +0000 2014
>Last-Modified:  Sat Aug 23 09:36:03 +0000 2014
>Originator:     Leonardo Taccari
>Release:        NetBSD 6.1.4
>Organization:
The NetBSD community
>Environment:


System: NetBSD foobar 6.1.4 NetBSD 6.1.4 (EEEPC900) #2: Sun Jun 29 02:00:06 CEST 2014 leot@:):/usr/src/sys/arch/i386/compile/EEEPC900 i386
Architecture: i386
Machine: i386
>Description:
news/slrn in pkgsrc (0.9.9) is not the latest stable version (1.0.1).
>How-To-Repeat:
$ cd pkgsrc/news/slrn
$ make show-var VARNAME=DISTNAME
>Fix:
Please apply the following (trivial) patches.

While here I've also tried to clean up it a bit, removing a workaround that was
needed for NetBSD 1.3.2 (if someone still use it I'm sure she will also able to
fix the problem herself or can lurk in the CVS logs to reapply it ;)), updated
MASTER_SITES and improved the DESCR(iption) (stolen from the doc/manual.txt).
Please also note that patches/patch-ag is no longer needed because it was
applied upstream.

I will also attach a possible commit message.

Thanks for your attention!


-------------------------8<---------------------8<----------------------------
Update news/slrn to 1.0.1.

pkgsrc changes:
 o Update DESCR and MASTER_SITES
 o Remove a Ye Olde Workaround needed for NetBSD 1.3.2.

changes (for a complete list please read ${WRKSRC}/changes.txt):
1.0.0:
 o Misc bug fixing

0.9.9p1:
 o Misc bug fixing
 o Man page improvements
 o Add --with-non-gnu-iconv configuration option
 o Added support for an optional argument to the replace_article function
   that dictates if the article should be mime processed.
 o Added initial support for multipart mime messages.
   See macros/mime.sl for additional information.
 o Added "replace_cooked_article", which is like to "replace_article", but
   does not affect the raw lines. mime.sl was updated to use this.
 o Added a top-level win32 directory containing scripts for building
   slrn using MinGW on a Windows system.  See doc/INSTALL.w32 for
   details.
 o New config variable: "wrap_width", which sets the width that will trigger wrapping.
-------------------------8<---------------------8<----------------------------


-------------------------8<---------------------8<----------------------------
Index: DESCR
===================================================================
RCS file: /cvsroot/pkgsrc/news/slrn/DESCR,v
retrieving revision 1.1
diff -u -r1.1 DESCR
--- DESCR	31 Oct 2001 21:03:50 -0000	1.1
+++ DESCR	19 Aug 2014 22:45:27 -0000
@@ -1,4 +1,9 @@
-Slrn is a terminal based newsreader by John E. Davis <davis@space.mit.edu>.
-It supports threads and is highly customizable through S-Lang functions.
-
-In this package, there is only support for NNTP, not for local spool.
+slrn ('S-Lang read news') is a newsreader, i.e. a program that accesses a
+newsserver to read messages from the Internet News service (also known as
+'Usenet'). It runs in console mode on various Unix-like systems (including
+Linux), 32-bit Windows, OS/2, BeOS and VMS. Beside the usual features of a
+newsreader slrn supports scoring rules to highlight, sort or kill articles
+based on information from their header. It is highly customizable, allows
+free key-bindings and can easily be extended using the sophisticated
+S-Lang macro language. Offline reading is possible by using either
+slrnpull (shipped with slrn) or a local newsserver (like leafnode or INN).
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/news/slrn/Makefile,v
retrieving revision 1.58
diff -u -r1.58 Makefile
--- Makefile	12 Feb 2014 23:18:28 -0000	1.58
+++ Makefile	19 Aug 2014 22:45:27 -0000
@@ -1,9 +1,8 @@
 # $NetBSD: Makefile,v 1.58 2014/02/12 23:18:28 tron Exp $

-DISTNAME=	slrn-0.9.9p1
-PKGREVISION=	10
+DISTNAME=	slrn-1.0.1
 CATEGORIES=	news
-MASTER_SITES=	ftp://space.mit.edu/pub/davis/slrn/
+MASTER_SITES=	${MASTER_SITE_SOURCEFORGE:=slrn/}

 MAINTAINER=	pkgsrc-users@NetBSD.org
 HOMEPAGE=	http://slrn.sourceforge.net/
@@ -25,12 +24,6 @@
 .include "options.mk"
 .include "../../mk/bsd.prefs.mk"

-# the next is a workaround, as 1.3.2 install doesn't like -c and -d
-# together
-.if ${OPSYS} == "NetBSD" && ${OS_VERSION} == "1.3.2"
-CONFIGURE_ENV+=		INSTALL=/usr/bin/install
-.endif
-
 LDFLAGS.Linux+=	-ldl
 LDFLAGS.SunOS+=	-lsocket -lnsl

Index: PLIST
===================================================================
RCS file: /cvsroot/pkgsrc/news/slrn/PLIST,v
retrieving revision 1.10
diff -u -r1.10 PLIST
--- PLIST	14 Jun 2009 18:10:07 -0000	1.10
+++ PLIST	19 Aug 2014 22:45:27 -0000
@@ -1,4 +1,4 @@
-@comment $NetBSD: PLIST,v 1.10 2009/06/14 18:10:07 joerg Exp $
+@comment $NetBSD$
 bin/slrn
 bin/slrnpull
 man/man1/slrn.1
@@ -46,6 +46,8 @@
 share/slrn/slang/gsort.sl
 share/slrn/slang/ispell.sl
 share/slrn/slang/latin2.sl
+share/slrn/slang/mailcap.sl
+share/slrn/slang/mime.sl
 share/slrn/slang/multipart.sl
 share/slrn/slang/nn.sl
 share/slrn/slang/posthook.sl
Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/news/slrn/distinfo,v
retrieving revision 1.15
diff -u -r1.15 distinfo
--- distinfo	18 Feb 2013 23:29:23 -0000	1.15
+++ distinfo	19 Aug 2014 22:45:27 -0000
@@ -1,8 +1,7 @@
 $NetBSD: distinfo,v 1.15 2013/02/18 23:29:23 dholland Exp $

-SHA1 (slrn-0.9.9p1.tar.gz) = f14d88eda39b78bd2f098f211d4a1c363c0fe924
-RMD160 (slrn-0.9.9p1.tar.gz) = 9e614d12c30f72a4ccde90fe557495d86d44b368
-Size (slrn-0.9.9p1.tar.gz) = 1535032 bytes
-SHA1 (patch-af) = 0dbe90431bf4f4e7b8cec6c23da1ce7458a2ca38
-SHA1 (patch-ag) = 81f1b6d75d707049726d5b8dbedec1b7a4ded9ac
-SHA1 (patch-src_slrnfeat.hin) = 9d6fd3419146c264eed35bdb607f8fd1bb3bb656
+SHA1 (slrn-1.0.1.tar.gz) = 9ad41ec3894d2b6b1ae8f158e994a8f138540baa
+RMD160 (slrn-1.0.1.tar.gz) = 4a1aa5b3a209e8aac50df0e5557eabfe22b13622
+Size (slrn-1.0.1.tar.gz) = 1529545 bytes
+SHA1 (patch-af) = 7b9507c68cefa913ebeb0e44c4ca0ad70956a3bd
+SHA1 (patch-src_slrnfeat.hin) = a115a2f7de61acd5c296fb3696a3cb97226ea121
Index: patches/patch-af
===================================================================
RCS file: /cvsroot/pkgsrc/news/slrn/patches/patch-af,v
retrieving revision 1.1
diff -u -r1.1 patch-af
--- patches/patch-af	4 Sep 2008 16:15:34 -0000	1.1
+++ patches/patch-af	19 Aug 2014 22:45:27 -0000
@@ -1,5 +1,7 @@
 $NetBSD: patch-af,v 1.1 2008/09/04 16:15:34 is Exp $

+Directly use INSTALL_DATA as ${mkdir_p}.
+
 --- po/Makefile.in.in.orig	2008-02-11 19:04:23.000000000 +0100
 +++ po/Makefile.in.in
 @@ -46,7 +46,7 @@ INSTALL_DATA = @INSTALL_DATA@
Index: patches/patch-ag
===================================================================
RCS file: patches/patch-ag
diff -N patches/patch-ag
--- patches/patch-ag	21 Nov 2008 14:43:56 -0000	1.1
+++ /dev/null	1 Jan 1970 00:00:00 -0000
@@ -1,9 +0,0 @@
-$NetBSD: patch-ag,v 1.1 2008/11/21 14:43:56 is Exp $
-
---- doc/slrn.1.orig	2008-02-10 18:01:00.000000000 +0100
-+++ doc/slrn.1
-@@ -1,4 +1,3 @@
--
- .\"
- .\" This manpage has been completely rewritten by Matthias Friedrich
- .\" <matt@mafr.de> based on the slrn reference manual
Index: patches/patch-src_slrnfeat.hin
===================================================================
RCS file: /cvsroot/pkgsrc/news/slrn/patches/patch-src_slrnfeat.hin,v
retrieving revision 1.1
diff -u -r1.1 patch-src_slrnfeat.hin
--- patches/patch-src_slrnfeat.hin	18 Feb 2013 23:29:23 -0000	1.1
+++ patches/patch-src_slrnfeat.hin	19 Aug 2014 22:45:27 -0000
@@ -1,5 +1,8 @@
 $NetBSD: patch-src_slrnfeat.hin,v 1.1 2013/02/18 23:29:23 dholland Exp $

+Fix compiled-in default path to sendmail; it should be /usr/sbin/sendmail
+on essentially all even halfway modern systems.
+
 --- src/slrnfeat.hin~	2008-02-09 18:32:17.000000000 +0000
 +++ src/slrnfeat.hin
 @@ -179,7 +179,7 @@

>Release-Note:

>Audit-Trail:
From: "OBATA Akio" <obache@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/49129 CVS commit: pkgsrc/news/slrn
Date: Sat, 23 Aug 2014 09:34:49 +0000

 Module Name:	pkgsrc
 Committed By:	obache
 Date:		Sat Aug 23 09:34:49 UTC 2014

 Modified Files:
 	pkgsrc/news/slrn: DESCR Makefile PLIST distinfo options.mk
 	pkgsrc/news/slrn/patches: patch-af patch-src_slrnfeat.hin
 Removed Files:
 	pkgsrc/news/slrn/patches: patch-ag

 Log Message:
 Update slrn to 1.0.1.
 Based on PR pkg/49129 by Leonardo Taccari.

 Changes since 1.0.0
 1. An issue with the wrap_width variable was fixed.

 Changes since 0.9.9p1
 1. src/charset.c: Avoid using CODESET if it is not defined.
 2. doc/slrn.1: Remove blank line at top of file. (Ignatios Souvatzis)
 3. src/Makefile.in: /bin/sh on solaris does not like empty lists in a
    for loop causing make install to fail.  Workaround added
    (Petr Sumbera).
 4. src/mime.c: rewrote much of the email address encoding/decoding so
    that only comment fields in email addresses are encoded/decoded.
    slrn is also smarted in encoding/decoding other headers (based on
    patch from Robert Grimm).
 5. autoconf/Makefile.in: Added dependencies such that if the
    Makefile.in and config.in files have been modified, the user is
    told to re-run the configure script.
 6. Updated the copyright years to 2009.
 7. src/mime.c: Omit the mime headers if the content is pure 7bit.
    Also, if mime-headers already exist, do not add append additional
    ones.
 8. configure: Added the configuration option --with-non-gnu-iconv that
    can be used to indicate that local version of iconv is not
    compatible with GNU iconv (Piotr 'aniou' Meyer).
 9. src/charset.c: Upon failure, slrn_test_convert_lines will return the line
    that caused it to fail.
 10. src/charset.c: If the --debug option is given, slrn will write the
     strings that iconv failed to convert to the log file.
 11. src/post.c: Skip long line checks between verbatim marks. (Robert
     Grimm).
 12. src/nntplib.h: Removed duplicate declarations of nntp_server_cmd
     and nntp_server_vcmd. (Li Hong).
 13. src/decode.c: If an output file already exists, create a new one
     by appending an integer to the name.
 14. src/slrn.c: work around a SLang_getkey bug that arises when the
     underlying read system call is interrupted, and the interrupt hook
     creates a different read descriptor.
 15. src/misc.c: All error messages (including slang tracebacks) are
     logged to the --debug output file.
 16. src/art.c,etc: If an article has invalid headers, clear the error
     but give the article an initial score of -1000.  This number may
     be customized using the "invalid_header_score" variable.
 17. src/mime.c: In slrn_mime_process_article, decode headers even if
     Content-Type is not understood and metamail is needed.
 18. src/art.c: Avoid a buffer overflow when reconstructing huge
     threads.  Thanks to Robert Grimm for finding the problem.
 19. src/version.c: %d format was used to print a long integer.
 20. src/nntplib.c: slrn user "narke" discovered that his server will
     disconnect if an attempt is made to post an empty body.  slrn does
     this after authenticating with the server to verify that posting
     is possible.  As a work-around, the response comment from the
     AUTHINFO command is parsed.
 21. src/sltcp.c: Add support for gnutls logging functions.
 22. src/chkslang.c: Fixed a sscanf format issue involving long long
     integers.
 23. src/sltcp.c: Change 21 needed #ifdef SLTCP_HAS_GNUTLS_SUPPORT.
 24. src/nntplib.c: A comparison in #20 should have used != instead of
     ==.
 25. doc/slrn.rc: "utf8" changed to "utf-8" (Thomas Wiegner).
 26. src/art_misc.c: Increased the search range for a pgp signature.
 27. src/misc.c: The rline_update callback function was not handling
     the case where no prompt (prompt==NULL) was associated with the
     readline object.  (M. G. Berberich)
 28. src/vfile.c: Add explicit void* to char* cast for better C++
     compliance.
 29. doc/tm/: Updated the Makefile and rebuilt the docs
 30. src/interp.c, art.c: Added support for an optional argument to the
     replace_article function that dictates if the article should be
     mime processed.
 31. src/*: Updated copyright year and trimmed extra whitespace.
 32. macros/mime.sl: Added initial support for multipart mime messages.
     See macros/mime.sl for additional information.
 33. macros/mime.sl;src/*.c: More support for processing multipart mime
     messages, including the ability to save/view the various parts of
     a message.
 34. src/misc.c:generic_read_input: If point is negative, regard it as
     an offset from the end of the string.  Changes were also made to
     the callers of this function accordingly.
 35. macros/mailcap.sl: If an executable does not exist on the search
     path, skip the mailcap entry.
 36. src/interp.c: Added "replace_cooked_article", which is like
     to "replace_article", but does not affect the raw lines.  mime.sl
     was updated to use this.
 37. macros/mime.sl: Added an option to the browse menu that permits
     the full raw article to be viewed.
 38. macros/mime.sl: Added a more informative message when a mime
     article is encountered.
 39. src/mime.c: A couple of strncmp calls used the wrong length (Patched
     by Thomas Wiegner).
 40. macros/mime.sl: The boundary subkeyword was not being detected in a
     case-insensitive way.  Also the wrong filename was mentioned in
     the usage comments. (Christian Ebert)
 41. macros/mime.sl: Add an option to view all parts of a mime
     multipart message.
 42. Added a top-level win32 directory containing scripts for building
     slrn using MinGW on a Windows system.  See doc/INSTALL.w32 for
     details.
 43. src/*.c: Various win32-specific tweaks to avoid some warnings
     generated by MinGW's gcc.
 44. win32/msinstall.sl: Use $prefix/share/man instead of $prefix/man
     for the directory where man pages are installed.
 45. doc/THANKS updated.
 46. updated autoconf/config.guess and autoconf/config.sub
 47. doc/THANKS rearranged.
 48. src/art_misc.c: New config variable: "wrap_width", which sets the
     width that will trigger wrapping.
 49. doc/: Updated txt docs from slrn doc project's svn repos.
 50. Version 1.0 released [Dec 21, 2012].


 To generate a diff of this commit:
 cvs rdiff -u -r1.1 -r1.2 pkgsrc/news/slrn/DESCR pkgsrc/news/slrn/options.mk
 cvs rdiff -u -r1.58 -r1.59 pkgsrc/news/slrn/Makefile
 cvs rdiff -u -r1.10 -r1.11 pkgsrc/news/slrn/PLIST
 cvs rdiff -u -r1.15 -r1.16 pkgsrc/news/slrn/distinfo
 cvs rdiff -u -r1.1 -r1.2 pkgsrc/news/slrn/patches/patch-af \
     pkgsrc/news/slrn/patches/patch-src_slrnfeat.hin
 cvs rdiff -u -r1.1 -r0 pkgsrc/news/slrn/patches/patch-ag

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: obache@NetBSD.org
State-Changed-When: Sat, 23 Aug 2014 09:36:03 +0000
State-Changed-Why:
Updated.  Thanks!


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2014 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.