NetBSD Problem Report #49189

From www@NetBSD.org  Wed Sep 10 16:28:12 2014
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 391B3CD1ED
	for <gnats-bugs@gnats.NetBSD.org>; Wed, 10 Sep 2014 16:28:12 +0000 (UTC)
Message-Id: <20140910162810.DD4F2CD201@mollari.NetBSD.org>
Date: Wed, 10 Sep 2014 16:28:10 +0000 (UTC)
From: uklaus@hgb-leipzig.de
Reply-To: uklaus@hgb-leipzig.de
To: gnats-bugs@NetBSD.org
Subject: Fixing broken DNS lookups in spamassassin
X-Send-Pr-Version: www-1.0

>Number:         49189
>Category:       pkg
>Synopsis:       Fixing broken DNS lookups in spamassassin
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    tron
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Sep 10 16:30:00 +0000 2014
>Closed-Date:    Fri Oct 10 17:50:28 +0000 2014
>Last-Modified:  Fri Oct 10 17:50:28 +0000 2014
>Originator:     Uwe Klaus
>Release:        pkgsrc-current
>Organization:
>Environment:
>Description:
net/p5-Net-DNS update to version 0.79 breaks DNS lookups in mail/spamassassin

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=7057

Net::DNS version 0.76 changed the field name holding a set of nameservers
in a Net::DNS::Resolver object: it used to be 'nameservers',
but is now split into two fields: 'nameserver4' and 'nameserver6'.

Mail/SpamAssassin/DnsResolver.pm relied on the internal field name
of a Net::DNS::Resolver object to obtain a default list of
recursive name servers, so the change in Net::DNS broke that.

>How-To-Repeat:

>Fix:
Proposed patch:

--- Mail/SpamAssassin/DnsResolver.pm.orig       2014-05-07 17:54:29 +0200
+++ Mail/SpamAssassin/DnsResolver.pm    2014-06-18 02:13:32 +0200
@@ -205,6 +205,8 @@
     dbg("dns: servers set by config to: %s", join(', ',@ns_addr_port));
   } elsif ($res) {  # default as provided by Net::DNS, e.g. /etc/resolv.conf
-    @ns_addr_port = map(untaint_var("[$_]:" . $res->{port}),
-                        @{$res->{nameservers}});
+    my @ns = $res->UNIVERSAL::can('nameservers') ? $res->nameservers
+                                                 : @{$res->{nameservers}};
+    my $port = $res->UNIVERSAL::can('port') ? $res->port : $res->{port};
+    @ns_addr_port = map(untaint_var("[$_]:" . $port), @ns);
     dbg("dns: servers obtained from Net::DNS : %s", join(', ',@ns_addr_port));
   }

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->tron
Responsible-Changed-By: tron@NetBSD.org
Responsible-Changed-When: Fri, 10 Oct 2014 09:23:38 +0000
Responsible-Changed-Why:
I've already fixed this problem:

http://mail-index.netbsd.org/pkgsrc-changes/2014/10/01/msg111958.html


State-Changed-From-To: open->pending-pullups
State-Changed-By: tron@NetBSD.org
State-Changed-When: Fri, 10 Oct 2014 09:23:38 +0000
State-Changed-Why:
The fix still needs to be pulled up into the "pkgsrc-2014Q3" branch.


State-Changed-From-To: pending-pullups->closed
State-Changed-By: tron@NetBSD.org
State-Changed-When: Fri, 10 Oct 2014 17:50:28 +0000
State-Changed-Why:
The change has been pulled up:

http://mail-index.netbsd.org/pkgsrc-changes/2014/10/10/msg112459.html


>Unformatted:

Home	PR Database Search