NetBSD Problem Report #49262

From bjjl@netvm.pocketservices.de  Thu Oct  9 06:34:08 2014
Return-Path: <bjjl@netvm.pocketservices.de>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 0681FA6608
	for <gnats-bugs@gnats.NetBSD.org>; Thu,  9 Oct 2014 06:34:08 +0000 (UTC)
Message-Id: <20141007073628.4B36B18BA1F@netvm.pocketservices.de>
Date: Tue,  7 Oct 2014 09:36:28 +0200 (CEST)
From: bl@pocketservices.de
To: gnats-bugs@gnats.NetBSD.org
Subject: Firefox compile fails at AString.o
X-Send-Pr-Version: 3.95

>Number:         49262
>Category:       pkg
>Synopsis:       Firefox compile fails at AString.o
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    ryoon
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Oct 09 06:35:00 +0000 2014
>Closed-Date:    Thu Dec 31 07:38:34 +0000 2015
>Last-Modified:  Thu Dec 31 07:38:34 +0000 2015
>Originator:     Benjamin Lorenz
>Release:        NetBSD 6.1_STABLE
>Organization:
>Environment:


System: NetBSD netvm.pocketservices.de 6.1_STABLE NetBSD 6.1_STABLE (GENERIC) #0: Mon Jul 28 17:58:37 CEST 2014 root@netvm.pocketservices.de:/usr/obj/sys/arch/i386/compile/GENERIC i386
Architecture: i386
Machine: i386
>Description:
netvm$ pwd
/usr/pkg/src/www/firefox
netvm$ head distinfo 
$NetBSD: distinfo,v 1.160 2014/10/05 01:59:08 ryoon Exp $

SHA1 (firefox-32.0.3.source.tar.bz2) = 1f831147365478e353212714038e812ca3e9fe42
RMD160 (firefox-32.0.3.source.tar.bz2) = f09e2cc92a35f0f3e88079d063c22bf16215327a

Compile error:

In file included from /usr/include/ctype.h:74:0,
                 from ../../dist/system_wrappers/ctype.h:3,
                 from /usr/pkg/src/www/firefox/work/mozilla-release/media/libstagefright/frameworks/av/media/libstagefright/foundation/AString.cpp:17:
/usr/pkg/src/www/firefox/work/mozilla-release/media/libstagefright/frameworks/av/include/media/stagefright/foundation/AString.h:78:10: error: expected unqualified-id before 'int'
     void tolower();
>How-To-Repeat:

>Fix:


>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->ryoon
Responsible-Changed-By: ryoon@NetBSD.org
Responsible-Changed-When: Sat, 11 Oct 2014 18:42:40 +0000
Responsible-Changed-Why:
mine


From: "Ryo ONODERA" <ryoon@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/49262 CVS commit: pkgsrc/www/firefox
Date: Sat, 18 Oct 2014 17:56:35 +0000

 Module Name:	pkgsrc
 Committed By:	ryoon
 Date:		Sat Oct 18 17:56:35 UTC 2014

 Modified Files:
 	pkgsrc/www/firefox: distinfo mozilla-common.mk
 Added Files:
 	pkgsrc/www/firefox/patches:
 	    patch-media_libstagefright_frameworks_av_include_media_stagefright_foundation_AString.h

 Log Message:
 Fix build under NetBSD 6.

 * Avoid conflict of tolower function, Thank you, tsutsui@ (PR pkg/49262).
 * GCC 4.6 is required to support nullptr at least.


 To generate a diff of this commit:
 cvs rdiff -u -r1.163 -r1.164 pkgsrc/www/firefox/distinfo
 cvs rdiff -u -r1.44 -r1.45 pkgsrc/www/firefox/mozilla-common.mk
 cvs rdiff -u -r0 -r1.1 \
     pkgsrc/www/firefox/patches/patch-media_libstagefright_frameworks_av_include_media_stagefright_foundation_AString.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->feedback
State-Changed-By: ryoon@NetBSD.org
State-Changed-When: Sun, 19 Oct 2014 01:31:03 +0000
State-Changed-Why:
Please try latest www/firefox.


From: "John D. Baker" <jdbaker@mylinuxisp.com>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/49262 (Firefox compile fails at AString.o)
Date: Fri, 18 Dec 2015 14:19:31 -0600 (CST)

 As of pkgsrc-HEAD frozen prior to the pkgsrc-2015Q4 branch (firefox-43.0),
 this problem is still observed.  It did NOT occur in pkgsrc-2015Q3
 (firefox-41.0).

 $ uname -a
 NetBSD verthandi 6.1_STABLE NetBSD 6.1_STABLE (VERTHANDI) #0: Wed Dec 16 01:27:44 CST 2015  sysop@x3650.technoskunk.fur:/r0/build/netbsd-6/obj/i386/sys/arch/i386/compile/VERTHANDI i386

 [...]
 In file included from /usr/include/ctype.h:74:0,
                  from ../../dist/system_wrappers/ctype.h:3,
                  from ../../dist/include/nsCharTraits.h:10,
                  from ../../dist/include/nsAlgorithm.h:10,
                  from ../../dist/include/nsTArray.h:25,
                  from /d0/build/pkgsrc/www/firefox/work/firefox-43.0/media/libstagefright/frameworks/av/include/media/stagefright/MediaSource.h:26,
                  from /d0/build/pkgsrc/www/firefox/work/firefox-43.0/media/libstagefright/frameworks/av/media/libstagefright/MediaSource.cpp:17,
                  from /d0/build/pkgsrc/www/firefox/work/build/media/libstagefright/Unified_cpp_media_libstagefright1.cpp:2:
 /d0/build/pkgsrc/www/firefox/work/firefox-43.0/media/libstagefright/frameworks/av/include/media/stagefright/foundation/AString.h:78:10: error: expected unqualified-id before 'int'
      void tolower();
           ^
 /d0/build/pkgsrc/www/firefox/work/firefox-43.0/media/libstagefright/frameworks/av/include/media/stagefright/foundation/AString.h:78:10: error: expected ')' before 'int'
 /d0/build/pkgsrc/www/firefox/work/firefox-43.0/media/libstagefright/frameworks/av/include/media/stagefright/foundation/AString.h:78:10: error: expected ')' before 'int'
 In file included from /d0/build/pkgsrc/www/firefox/work/build/media/libstagefright/Unified_cpp_media_libstagefright1.cpp:65:0:
 /d0/build/pkgsrc/www/firefox/work/firefox-43.0/media/libstagefright/frameworks/av/media/libstagefright/foundation/AString.cpp:312:23: error: no 'void stagefright::AString::tolower()' member function declared in class 'stagefright::AString'
  void AString::tolower() {
                        ^
 /d0/build/pkgsrc/www/firefox/work/firefox-43.0/config/rules.mk:959: recipe for target 'Unified_cpp_media_libstagefright1.o' failed
 gmake[3]: *** [Unified_cpp_media_libstagefright1.o] Error 1
 gmake[3]: Leaving directory '/d0/build/pkgsrc/www/firefox/work/build/media/libstagefright'
 /d0/build/pkgsrc/www/firefox/work/firefox-43.0/config/recurse.mk:71: recipe for target 'media/libstagefright/target' failed
 gmake[2]: *** [media/libstagefright/target] Error 2
 gmake[2]: Leaving directory '/d0/build/pkgsrc/www/firefox/work/build'
 /d0/build/pkgsrc/www/firefox/work/firefox-43.0/config/recurse.mk:32: recipe for target 'compile' failed
 gmake[1]: *** [compile] Error 2
 gmake[1]: Leaving directory '/d0/build/pkgsrc/www/firefox/work/build'
 /d0/build/pkgsrc/www/firefox/work/firefox-43.0/config/rules.mk:549: recipe for target 'all' failed
 gmake: *** [all] Error 2
 *** Error code 2

 Stop.
 make: stopped in /x/pkgsrc/www/firefox
 *** Error code 1

 Stop.
 make: stopped in /x/pkgsrc/www/firefox


 -- 
 |/"\ John D. Baker, KN5UKS               NetBSD     Darwin/MacOS X
 |\ / jdbaker[snail]mylinuxisp[flyspeck]com    OpenBSD            FreeBSD
 | X  No HTML/proprietary data in email.   BSD just sits there and works!
 |/ \ GPGkeyID:  D703 4A7E 479F 63F8 D3F4  BD99 9572 8F23 E4AD 1645

From: Joerg Sonnenberger <joerg@britannica.bec.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/49262 (Firefox compile fails at AString.o)
Date: Fri, 18 Dec 2015 23:24:06 +0100

 On Fri, Dec 18, 2015 at 10:00:01PM +0000, John D. Baker wrote:
 >  /d0/build/pkgsrc/www/firefox/work/firefox-43.0/media/libstagefright/frameworks/av/include/media/stagefright/foundation/AString.h:78:10: error: expected unqualified-id before 'int'
 >       void tolower();
 >            ^

 Include <cctype> first, that makes the macros disappear.

 Joerg

From: "John D. Baker" <jdbaker@mylinuxisp.com>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/49262 (Firefox compile fails at AString.o)
Date: Sun, 20 Dec 2015 04:08:11 -0600 (CST)

 As of this commit:

   http://mail-index.netbsd.org/pkgsrc-changes/2015/12/18/msg133887.html

 firefox-43.0 builds successfully on my netbsd-6/i386 system.

 Thanks.

 -- 
 |/"\ John D. Baker, KN5UKS               NetBSD     Darwin/MacOS X
 |\ / jdbaker[snail]mylinuxisp[flyspeck]com    OpenBSD            FreeBSD
 | X  No HTML/proprietary data in email.   BSD just sits there and works!
 |/ \ GPGkeyID:  D703 4A7E 479F 63F8 D3F4  BD99 9572 8F23 E4AD 1645

State-Changed-From-To: feedback->closed
State-Changed-By: ryoon@NetBSD.org
State-Changed-When: Thu, 31 Dec 2015 07:38:34 +0000
State-Changed-Why:
confirmed fixed


>Unformatted:

Home	PR Database Search