NetBSD Problem Report #49300

From www@NetBSD.org  Tue Oct 21 19:21:07 2014
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id BBA91A65EB
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 21 Oct 2014 19:21:07 +0000 (UTC)
Message-Id: <20141021192105.9DF1EA668C@mollari.NetBSD.org>
Date: Tue, 21 Oct 2014 19:21:05 +0000 (UTC)
From: steven43126@gmail.com
Reply-To: steven43126@gmail.com
To: gnats-bugs@NetBSD.org
Subject: Submission to add an options to www/nginx to enable the geoip module
X-Send-Pr-Version: www-1.0

>Number:         49300
>Category:       pkg
>Synopsis:       Submission to add an options to www/nginx to enable the geoip module
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    osa
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Tue Oct 21 19:25:00 +0000 2014
>Closed-Date:    Mon Apr 24 17:28:57 +0000 2023
>Last-Modified:  Mon Apr 24 17:28:57 +0000 2023
>Originator:     Steven Williamson
>Release:        trunk
>Organization:
FreeAgent
>Environment:

>Description:
Patches attached to add the geoip option to www/nginx. Iv'e also added the geoip option as a suggested default as building nginx with the option provides extra functionality but does not have a negative affect if it is not used/enabled in configuration.

The option allows www/nginx to create variables for country/city/org for requests if configured with a geoip database. 
>How-To-Repeat:


>Fix:
Subject: [PATCH] Add geoip option and set it as a suggested option

---
 www/nginx/options.mk | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/www/nginx/options.mk b/www/nginx/options.mk
index 02d6f59..5d50e41 100644
--- a/www/nginx/options.mk
+++ b/www/nginx/options.mk
@@ -5,8 +5,8 @@ PKG_SUPPORTED_OPTIONS=	dav flv gtools inet6 luajit mail-proxy memcache naxsi \
 			pcre push realip ssl sub uwsgi image-filter upload \
 			debug status nginx-autodetect-cflags spdy echo \
 			set-misc headers-more array-var encrypted-session \
-			form-input perl
-PKG_SUGGESTED_OPTIONS=	inet6 pcre ssl
+			form-input perl geoip
+PKG_SUGGESTED_OPTIONS=	inet6 pcre ssl geoip

 PLIST_VARS+=		naxsi perl uwsgi

@@ -75,6 +75,11 @@ DISTFILES+=			${NAXSI_DISTFILE}
 CONFIGURE_ARGS+=	--with-http_realip_module
 .endif

+.if !empty(PKG_OPTIONS:Mgeoip)
+.include "../../net/GeoIP/buildlink3.mk"
+CONFIGURE_ARGS+=	--with-http_geoip_module
+.endif
+
 .if !empty(PKG_OPTIONS:Minet6)
 CONFIGURE_ARGS+=	--with-ipv6
 .endif
--

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->joerg
Responsible-Changed-By: wiz@NetBSD.org
Responsible-Changed-When: Tue, 21 Oct 2014 21:40:11 +0000
Responsible-Changed-Why:
Over to maintainer.


Responsible-Changed-From-To: joerg->osa
Responsible-Changed-By: osa@NetBSD.org
Responsible-Changed-When: Mon, 24 Apr 2023 16:43:20 +0000
Responsible-Changed-Why:
I'll take it.


State-Changed-From-To: open->closed
State-Changed-By: osa@NetBSD.org
State-Changed-When: Mon, 24 Apr 2023 17:28:57 +0000
State-Changed-Why:
The original geoip module depends on a library from MaxMind and that
library is available in the pkgsrc.  However, that library is
deprecated, https://github.com/maxmind/geoip-api-c.  Also, geoip2
third-party module was added to www/nginx* packages.  Personally,
I see no reasons to add this module to the build.  In case I missed
something please feel free to re-open this PR.
Thanks for the report!



>Unformatted:

Home	PR Database Search