NetBSD Problem Report #49343

From www@NetBSD.org  Fri Oct 31 05:52:11 2014
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id EF247A65E1
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 31 Oct 2014 05:52:11 +0000 (UTC)
Message-Id: <20141031055210.74481A66A8@mollari.NetBSD.org>
Date: Fri, 31 Oct 2014 05:52:10 +0000 (UTC)
From: richard@NetBSD.org
Reply-To: richard@NetBSD.org
To: gnats-bugs@NetBSD.org
Subject: libpurple with option 'perl' fails during packaging when Purple.bs is empty
X-Send-Pr-Version: www-1.0

>Number:         49343
>Category:       pkg
>Synopsis:       libpurple with option 'perl' fails during packaging when Purple.bs is empty
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Oct 31 05:55:00 +0000 2014
>Closed-Date:    Sat Dec 27 02:35:10 +0000 2014
>Last-Modified:  Sat Dec 27 05:25:00 +0000 2014
>Originator:     Richard PALO
>Release:        pkgsrc current
>Organization:
>Environment:
SunOS omnis 5.11 illumos-gate-abbb445 i86pc i386 i86pc

>Description:
With the following options (namely 'perl') for chat/libpurple:

>These options are enabled by default:
>	dbus farsight gnome gstreamer
>
>These options are currently enabled:
>	dbus farsight gnome gstreamer perl sasl

The build fails with:
>=> Checking file-check results for libpurple-2.10.9nb3
>ERROR: ************************************************************
>ERROR: The following files are in the PLIST but not in /tmp/pkgsrc/chat/libpurple/work/.destdir/opt/local:
>ERROR:         /tmp/pkgsrc/chat/libpurple/work/.destdir/opt/local/lib/purple-2/perl/auto/Purple/Purple.bs
>*** Error code 1



>How-To-Repeat:

>Fix:
pidgin-2.10.9/libpurple/plugins/perl/common/Makefile has the following 'dynamic' installation snippet:
>$(INST_DYNAMIC): $(OBJECT) $(MYEXTLIB) >$(INST_ARCHAUTODIR)$(DFSEP).exists $(EXPORT_LIST) $(PERL_ARCHIVE) >$(PERL_ARCHIVE_AFTER) $(INST_DYNAMIC_DEP)
>    $(RM_F) $@
>    $(LD)  $(LDDLFLAGS) $(LDFROM) $(OTHERLDFLAGS) -o $@ $(MYEXTLIB) \
>      $(PERL_ARCHIVE) $(LDLOADLIBS) $(PERL_ARCHIVE_AFTER) >$(EXPORT_LIST)    \
>      $(INST_DYNAMIC_FIX)
>    $(CHMOD) $(PERM_RWX) $@
>    $(NOECHO) $(RM_RF) $(BOOTSTRAP)
>    - $(CP_NONEMPTY) $(BOOTSTRAP) $(INST_BOOT) $(PERM_RW)

where CP_NONEMPTY is defined as:
>CP_NONEMPTY = $(ABSPERLRUN) -MExtUtils::Command::MM -e 'cp_nonempty' --

Perhaps adding a variable for PLIST testing for Purple.bs being present is a solution. Currently PLIST uses the following for Purple.bs:
>${PLIST.perl}lib/purple-2/perl/auto/Purple/Purple.bs

>Release-Note:

>Audit-Trail:
From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/49343: libpurple with option 'perl' fails during packaging
 when Purple.bs is empty
Date: Sat, 22 Nov 2014 19:52:49 +0000

 On Fri, Oct 31, 2014 at 05:55:00AM +0000, richard@NetBSD.org wrote:
  > pidgin-2.10.9/libpurple/plugins/perl/common/Makefile has the
  > following 'dynamic' installation snippet:
  > >$(INST_DYNAMIC): $(OBJECT) $(MYEXTLIB) >$(INST_ARCHAUTODIR)$(DFSEP).exists $(EXPORT_LIST) $(PERL_ARCHIVE) >$(PERL_ARCHIVE_AFTER) $(INST_DYNAMIC_DEP)
  > >    $(RM_F) $@
  > >    $(LD)  $(LDDLFLAGS) $(LDFROM) $(OTHERLDFLAGS) -o $@ $(MYEXTLIB) \
  > >      $(PERL_ARCHIVE) $(LDLOADLIBS) $(PERL_ARCHIVE_AFTER) >$(EXPORT_LIST)    \
  > >      $(INST_DYNAMIC_FIX)
  > >    $(CHMOD) $(PERM_RWX) $@
  > >    $(NOECHO) $(RM_RF) $(BOOTSTRAP)
  > >    - $(CP_NONEMPTY) $(BOOTSTRAP) $(INST_BOOT) $(PERM_RW)
  > 
  > where CP_NONEMPTY is defined as:
  > >CP_NONEMPTY = $(ABSPERLRUN) -MExtUtils::Command::MM -e 'cp_nonempty' --
  > 
  > Perhaps adding a variable for PLIST testing for Purple.bs being
  > present is a solution. Currently PLIST uses the following for
  > Purple.bs:
  > >${PLIST.perl}lib/purple-2/perl/auto/Purple/Purple.bs

 Would it be wrong to patch it to always install Purple.bs even if it's
 empty? (I have no idea what the file is or what it does...)

 -- 
 David A. Holland
 dholland@netbsd.org

From: Filip Hajny <filip@joyent.com>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/49343: libpurple with option 'perl' fails during packaging when Purple.bs is empty
Date: Sun, 23 Nov 2014 13:48:15 +0100

 22. 11. 2014 v 20:55, David Holland <dholland-pbugs@netbsd.org>:
 >=20
 > The following reply was made to PR pkg/49343; it has been noted by =
 GNATS.
 >=20
 > From: David Holland <dholland-pbugs@netbsd.org>
 > To: gnats-bugs@NetBSD.org
 > Cc:=20
 > Subject: Re: pkg/49343: libpurple with option 'perl' fails during =
 packaging
 > when Purple.bs is empty
 > Date: Sat, 22 Nov 2014 19:52:49 +0000
 >=20
 > On Fri, Oct 31, 2014 at 05:55:00AM +0000, richard@NetBSD.org wrote:
 >> pidgin-2.10.9/libpurple/plugins/perl/common/Makefile has the
 >> following 'dynamic' installation snippet:
 >>> $(INST_DYNAMIC): $(OBJECT) $(MYEXTLIB) =
 >$(INST_ARCHAUTODIR)$(DFSEP).exists $(EXPORT_LIST) $(PERL_ARCHIVE) =
 >$(PERL_ARCHIVE_AFTER) $(INST_DYNAMIC_DEP)
 >>>   $(RM_F) $@
 >>>   $(LD)  $(LDDLFLAGS) $(LDFROM) $(OTHERLDFLAGS) -o $@ $(MYEXTLIB) \
 >>>     $(PERL_ARCHIVE) $(LDLOADLIBS) $(PERL_ARCHIVE_AFTER) =
 >$(EXPORT_LIST)    \
 >>>     $(INST_DYNAMIC_FIX)
 >>>   $(CHMOD) $(PERM_RWX) $@
 >>>   $(NOECHO) $(RM_RF) $(BOOTSTRAP)
 >>>   - $(CP_NONEMPTY) $(BOOTSTRAP) $(INST_BOOT) $(PERM_RW)
 >>=20
 >> where CP_NONEMPTY is defined as:
 >>> CP_NONEMPTY =3D $(ABSPERLRUN) -MExtUtils::Command::MM -e =
 'cp_nonempty' --
 >>=20
 >> Perhaps adding a variable for PLIST testing for Purple.bs being
 >> present is a solution. Currently PLIST uses the following for
 >> Purple.bs:
 >>> ${PLIST.perl}lib/purple-2/perl/auto/Purple/Purple.bs
 >=20
 > Would it be wrong to patch it to always install Purple.bs even if it's
 > empty? (I have no idea what the file is or what it does=E2=80=A6)

 Starting with Perl 5.20, the .bs files are no longer generated if empty. =
 No need to carry such in PLIST anymore.

 -F=

From: "OBATA Akio" <obata@lins.jp>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/49343: libpurple with option 'perl' fails during packaging
 when Purple.bs is empty
Date: Sat, 06 Dec 2014 20:23:09 +0900

 On Fri, 31 Oct 2014 14:55:00 +0900, <richard@netbsd.org> wrote:

 > Perhaps adding a variable for PLIST testing for Purple.bs being present is a solution. Currently PLIST uses the following for Purple.bs:
 >> ${PLIST.perl}lib/purple-2/perl/auto/Purple/Purple.bs

 How about manager PLIST with lang/perl5/packlist.mk ?

 -- 
 OBATA Akio / obata@lins.jp

From: "OBATA Akio" <obache@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/49343 CVS commit: pkgsrc/chat/libpurple
Date: Sun, 7 Dec 2014 08:42:07 +0000

 Module Name:	pkgsrc
 Committed By:	obache
 Date:		Sun Dec  7 08:42:07 UTC 2014

 Modified Files:
 	pkgsrc/chat/libpurple: PLIST options.mk

 Log Message:
 Use packlist for most of perl related PLIST.
 Resolve PR pkg/49343.


 To generate a diff of this commit:
 cvs rdiff -u -r1.28 -r1.29 pkgsrc/chat/libpurple/PLIST
 cvs rdiff -u -r1.26 -r1.27 pkgsrc/chat/libpurple/options.mk

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Richard PALO <richard@netbsd.org>
To: gnats-bugs@netbsd.org, pkgsrc-bugs@netbsd.org
Cc: 
Subject: Re: PR/49343 CVS commit: pkgsrc/chat/libpurple
Date: Thu, 11 Dec 2014 10:58:15 +0100

 Le 07/12/14 09:45, OBATA Akio a écrit :
 > The following reply was made to PR pkg/49343; it has been noted by GNATS.
 >
 > From: "OBATA Akio" <obache@netbsd.org>
 > To: gnats-bugs@gnats.NetBSD.org
 > Cc:
 > Subject: PR/49343 CVS commit: pkgsrc/chat/libpurple
 > Date: Sun, 7 Dec 2014 08:42:07 +0000
 >
 >   Module Name:	pkgsrc
 >   Committed By:	obache
 >   Date:		Sun Dec  7 08:42:07 UTC 2014
 >
 >   Modified Files:
 >   	pkgsrc/chat/libpurple: PLIST options.mk
 >
 >   Log Message:
 >   Use packlist for most of perl related PLIST.
 >   Resolve PR pkg/49343.
 >
 >
 >   To generate a diff of this commit:
 >   cvs rdiff -u -r1.28 -r1.29 pkgsrc/chat/libpurple/PLIST
 >   cvs rdiff -u -r1.26 -r1.27 pkgsrc/chat/libpurple/options.mk
 >
 >   Please note that diffs are not public domain; they are subject to the
 >   copyright notices on the relevant files.
 >
 >

 This seemed to get over the perl issue, although the following was 
 needed to build (at least on SunOS i386 with gcc49) :
 > diff --git a/chat/libpurple/Makefile.common b/chat/libpurple/Makefile.common
 > index 6a07464..3dc5889 100644
 > --- a/chat/libpurple/Makefile.common
 > +++ b/chat/libpurple/Makefile.common
 > @@ -21,6 +21,9 @@ USE_PKGLOCALEDIR=     yes
 >  USE_TOOLS+=            pkg-config gmake
 >  GNU_CONFIGURE=         yes
 >
 > +CPPFLAGS.SunOS+=       -D__EXTENSIONS__
 > +CFLAGS.SunOS+=         -Wno-error=implicit-function-declaration
 > +
 >  PATCHDIR=              ${.CURDIR}/../../chat/libpurple/patches
 >  DISTINFO_FILE?=                ${.CURDIR}/../../chat/libpurple/distinfo


From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/49343 CVS commit: pkgsrc/chat/libpurple
Date: Sat, 27 Dec 2014 02:21:26 +0000

 Module Name:	pkgsrc
 Committed By:	dholland
 Date:		Sat Dec 27 02:21:26 UTC 2014

 Modified Files:
 	pkgsrc/chat/libpurple: Makefile.common

 Log Message:
 Add CPPFLAGS/CFLAGS.SunOS per followup to PR 49343.


 To generate a diff of this commit:
 cvs rdiff -u -r1.43 -r1.44 pkgsrc/chat/libpurple/Makefile.common

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sat, 27 Dec 2014 02:35:10 +0000
State-Changed-Why:
I committed the last bit. Let me know if it turns out not to work...


From: Richard PALO <richard@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: PR/49343 CVS commit: pkgsrc/chat/libpurple
Date: Sat, 27 Dec 2014 06:24:14 +0100

 -----BEGIN PGP SIGNED MESSAGE-----
 Hash: SHA1

 Le 27/12/14 03:25, David A. Holland a écrit :
 > The following reply was made to PR pkg/49343; it has been noted by GNATS.
 > 
 > From: "David A. Holland" <dholland@netbsd.org>
 > To: gnats-bugs@gnats.NetBSD.org
 > Cc: 
 > Subject: PR/49343 CVS commit: pkgsrc/chat/libpurple
 > Date: Sat, 27 Dec 2014 02:21:26 +0000
 > 
 >  Module Name:	pkgsrc
 >  Committed By:	dholland
 >  Date:		Sat Dec 27 02:21:26 UTC 2014
 >  
 >  Modified Files:
 >  	pkgsrc/chat/libpurple: Makefile.common
 >  
 >  Log Message:
 >  Add CPPFLAGS/CFLAGS.SunOS per followup to PR 49343.
 >  
 >  
 >  To generate a diff of this commit:
 >  cvs rdiff -u -r1.43 -r1.44 pkgsrc/chat/libpurple/Makefile.common
 >  
 >  Please note that diffs are not public domain; they are subject to the
 >  copyright notices on the relevant files.
 >  
 > 
 > 

 Thanks Dave! This is fine.
 best wishes...
 richard
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1
 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

 iQEcBAEBAgAGBQJUnkJ+AAoJECAB22fHtp27mYgH+QEJj761maj6h+lLDryx2WO9
 VeK7GFNn1VVKbm+Wc6rxet5m54X7pRqB7F8NuioXwzb6j7Ws0bMMjlFy2CuEJnff
 Yy3AQ+XDxNt0prusz5gUzaSY3RimeYXUAtx14nwF5TKLWTob4CJkx4PeSrjq9HgV
 +Tj/amV9G7MgY8yRBu0R1cX0NvxxsHYZaJxu++MaQln9L/ApxaQH2xbqziKH+hXk
 qgcqXhSpp5zk1A/Y8AlaxhaUpYsW0Ku8VoyGS+ys0ogO3Ag5o0RYIB5mGoUAeGuj
 eK7E+khJy7afro4cQwiHqVPnmD7gaoTZkKOG6310u6kSuMzbjSrODIDm0js61b0=
 =cdXF
 -----END PGP SIGNATURE-----

>Unformatted:

Home	PR Database Search