NetBSD Problem Report #49382

From www@NetBSD.org  Tue Nov 11 19:47:14 2014
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 8BC9CA6649
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 11 Nov 2014 19:47:14 +0000 (UTC)
Message-Id: <20141111194713.067DCA6688@mollari.NetBSD.org>
Date: Tue, 11 Nov 2014 19:47:13 +0000 (UTC)
From: pr@i3enedek.neomailbox.net
Reply-To: pr@i3enedek.neomailbox.net
To: gnats-bugs@NetBSD.org
Subject: cad/xcircuit fails to build
X-Send-Pr-Version: www-1.0

>Number:         49382
>Notify-List:    shaun@inerd.com
>Category:       pkg
>Synopsis:       cad/xcircuit fails to build
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Nov 11 19:50:00 +0000 2014
>Closed-Date:    Mon Dec 15 22:43:56 +0000 2014
>Last-Modified:  Sat Dec 27 22:40:23 +0000 2014
>Originator:     Ben Gergely
>Release:        current
>Organization:
>Environment:
NetBSD 7.99.1 i386
>Description:
Xcircuit seems to have some issue around building to do with the tcl wrapper, I've patched up the bits that fail to compile and updated the make file to fetch version 3.7.57 but cant figure out fixing Makefile.in.

The install phase problem is to do with making the binary and $(INTERP_PATH):

741         $(MAKE) lib/tcl/xcircuit${SHDLIB_EXT}
742         $(MAKE) lib/$(INTERP_PATH)/$(WRAPPER_SH)
743         $(MAKE) lib/$(INTERP_PATH)/$(WRAPPER_INIT)
744         $(MAKE) xcircexec$(EXEEXT)

maybe replacing INTERP_PATH with the path e.g. tcl as in line 741 might work in some places

dropping tcl as the build target creates a working binary, but with a loss of functionality
BUILD_TARGET=   tcl
INSTALL_TARGET= install-tcl

The compile time issues are also tcl related.

>How-To-Repeat:
cd /usr/pkgsrc/cad/xcircuit ; make
>Fix:
don't build with tcl with a loss of functionality:

BUILD_TARGET=   tcl
INSTALL_TARGET= install-tcl

if also bumping the version to xcircuit-3.7.57 (might as well) apply these patches:
$NetBSD$

--- menucalls.c.orig    2013-01-01 17:24:44.000000000 +0000
+++ menucalls.c
@@ -62,9 +62,7 @@ extern Tcl_Interp *xcinterp;
 /* Local Variable definitions                                          */
 /*----------------------------------------------------------------------*/

-#ifdef TCL_WRAPPER
 u_short *fontnumbers;
-#endif
 u_char nfontnumbers;

 /*----------------------------------------------*/
$NetBSD$

--- xcircuit.c.orig     2013-01-01 17:24:44.000000000 +0000
+++ xcircuit.c
@@ -114,9 +114,7 @@ xcIntervalId printtime_id;
 short beeper;
 short fontcount;
 fontinfo *fonts;
-#ifdef TCL_WRAPPER
 short   popups;      /* total number of popup widgets on the screen */
-#endif

 /*----------------------------------------------------------------------*/
 /* Externally defined variables                                               */






>Release-Note:

>Audit-Trail:
	Added maintainer to Notify-List.
From: "OBATA Akio" <obache@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/49382 CVS commit: pkgsrc/cad/xcircuit
Date: Mon, 15 Dec 2014 08:58:52 +0000

 Module Name:	pkgsrc
 Committed By:	obache
 Date:		Mon Dec 15 08:58:52 UTC 2014

 Modified Files:
 	pkgsrc/cad/xcircuit: Makefile distinfo
 	pkgsrc/cad/xcircuit/patches: patch-aa patch-ab

 Log Message:
 Change Tcl/Tk library name matching to pkgsrc naming, to be found correctly.
 Resolve PR pkg/49382.


 To generate a diff of this commit:
 cvs rdiff -u -r1.41 -r1.42 pkgsrc/cad/xcircuit/Makefile
 cvs rdiff -u -r1.15 -r1.16 pkgsrc/cad/xcircuit/distinfo
 cvs rdiff -u -r1.10 -r1.11 pkgsrc/cad/xcircuit/patches/patch-aa
 cvs rdiff -u -r1.11 -r1.12 pkgsrc/cad/xcircuit/patches/patch-ab

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->feedback
State-Changed-By: obache@NetBSD.org
State-Changed-When: Mon, 15 Dec 2014 09:06:53 +0000
State-Changed-Why:
fixed?


From: Benedek Gergely <i3enedek@neomailbox.net>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/49382 (cad/xcircuit fails to build)
Date: Mon, 15 Dec 2014 21:53:10 +0000

 Yeah it's all good now, cheers.

State-Changed-From-To: feedback->Closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Mon, 15 Dec 2014 22:43:56 +0000
State-Changed-Why:
Confirmed fixed, thanks!


From: Shaun Amott <shaun@inerd.com>
To: gnats-bugs@NetBSD.org
Cc: pkg-manager@netbsd.org, pkgsrc-bugs@netbsd.org, gnats-admin@netbsd.org,
	obache@NetBSD.org, pr@i3enedek.neomailbox.net
Subject: Re: pkg/49382 (cad/xcircuit fails to build)
Date: Mon, 15 Dec 2014 22:26:28 +0000

 On Mon, Dec 15, 2014 at 09:06:53AM +0000, obache@NetBSD.org wrote:
 > Synopsis: cad/xcircuit fails to build
 > 
 > State-Changed-From-To: open->feedback
 > State-Changed-By: obache@NetBSD.org
 > State-Changed-When: Mon, 15 Dec 2014 09:06:53 +0000
 > State-Changed-Why:
 > fixed?
 > 

 I haven't got time to maintain this port any more (actually, I forgot I
 was even set as maintainer). Could you reset the port for me?

 Shaun

From: "OBATA Akio" <obache@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/49382 CVS commit: pkgsrc/cad/xcircuit
Date: Wed, 17 Dec 2014 06:35:13 +0000

 Module Name:	pkgsrc
 Committed By:	obache
 Date:		Wed Dec 17 06:35:13 UTC 2014

 Modified Files:
 	pkgsrc/cad/xcircuit: Makefile

 Log Message:
 Reset MAINTAINER, requested in PR pkg/49382.


 To generate a diff of this commit:
 cvs rdiff -u -r1.43 -r1.44 pkgsrc/cad/xcircuit/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: Closed->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sat, 27 Dec 2014 22:40:23 +0000
State-Changed-Why:
use right spelling


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2014 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.