NetBSD Problem Report #49475

From www@NetBSD.org  Tue Dec 16 03:10:38 2014
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 1DB49A6562
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 16 Dec 2014 03:10:38 +0000 (UTC)
Message-Id: <20141216031037.11A74A6567@mollari.NetBSD.org>
Date: Tue, 16 Dec 2014 03:10:37 +0000 (UTC)
From: venture37@geeklan.co.uk
Reply-To: venture37@geeklan.co.uk
To: gnats-bugs@NetBSD.org
Subject: Unbreak devel/commit-patch
X-Send-Pr-Version: www-1.0

>Number:         49475
>Category:       pkg
>Synopsis:       Unbreak devel/commit-patch
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Dec 16 03:15:00 +0000 2014
>Closed-Date:    Fri Dec 26 21:31:06 +0000 2014
>Last-Modified:  Fri Dec 26 21:31:06 +0000 2014
>Originator:     Sevan Janiyan
>Release:        pkgsrc-current
>Organization:
>Environment:
Darwin 8.11.0 Darwin Kernel Version 8.11.0: Wed Oct 10 18:26:00 PDT 2007; root:xnu-792.24.17~1/RELEASE_PPC Power Macintosh powerpc
>Description:
-a for cp is the same as -pPR, older operating systems may not support -a e.g Darwin 8
>How-To-Repeat:

>Fix:
ndex: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/devel/commit-patch/distinfo,v
retrieving revision 1.1
diff -u -r1.1 distinfo
--- distinfo    9 Aug 2014 23:49:53 -0000       1.1
+++ distinfo    16 Dec 2014 03:07:58 -0000
@@ -3,4 +3,4 @@
 SHA1 (commit-patch-2.5.tar.gz) = 9d41c31adaa6f8a70296b8105736661bba7ef55e
 RMD160 (commit-patch-2.5.tar.gz) = ac1193b785bd6bc271254e192ced869967bc87db
 Size (commit-patch-2.5.tar.gz) = 20200 bytes
-SHA1 (patch-Makefile) = 6b0a4f274f325e186465398dfa35e43ca305f7cd
+SHA1 (patch-Makefile) = e907cdafe4ac1085a4328fad695239cc74de28ff
Index: patches/patch-Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/devel/commit-patch/patches/patch-Makefile,v
retrieving revision 1.1
diff -u -r1.1 patch-Makefile
--- patches/patch-Makefile      9 Aug 2014 23:49:53 -0000       1.1
+++ patches/patch-Makefile      16 Dec 2014 03:07:58 -0000
@@ -1,6 +1,7 @@
-$NetBSD: patch-Makefile,v 1.1 2014/08/09 23:49:53 wiz Exp $
+$NetBSD$

 Fix man page installation path.
+-a is the same as -pPR, older operating systems may not support -a

 --- Makefile.orig      2013-05-16 02:28:56.000000000 +0000
 +++ Makefile
@@ -12,8 +13,11 @@
 +      mkdir -p "$(PREFIX)/${PKGMANDIR}/man1"
        mkdir -p "$(PREFIX)/share/emacs/site-lisp"
        mkdir -p "$(PREFIX)/share/doc/commit-patch"
-       cp -a $(BIN)   "$(PREFIX)/bin"
+-      cp -a $(BIN)   "$(PREFIX)/bin"
 -      cp -a $(MAN)   "$(PREFIX)/share/man/man1"
-+      cp -a $(MAN)   "$(PREFIX)/${PKGMANDIR}/man1"
-       cp -a $(ELISP) "$(PREFIX)/share/emacs/site-lisp"
-       cp -a $(DOC)   "$(PREFIX)/share/doc/commit-patch"
+-      cp -a $(ELISP) "$(PREFIX)/share/emacs/site-lisp"
+-      cp -a $(DOC)   "$(PREFIX)/share/doc/commit-patch"
++      cp -pPR $(BIN)   "$(PREFIX)/bin"
++      cp -pPR $(MAN)   "$(PREFIX)/${PKGMANDIR}/man1"
++      cp -pPR $(ELISP) "$(PREFIX)/share/emacs/site-lisp"
++      cp -pPR $(DOC)   "$(PREFIX)/share/doc/commit-patch"

>Release-Note:

>Audit-Trail:
From: Thomas Klausner <wiz@NetBSD.org>
To: NetBSD bugtracking <gnats-bugs@NetBSD.org>
Cc: 
Subject: Re: pkg/49475: Unbreak devel/commit-patch
Date: Tue, 16 Dec 2014 09:59:01 +0100

 On Tue, Dec 16, 2014 at 03:15:00AM +0000, venture37@geeklan.co.uk wrote:
 > >Number:         49475
 > >Category:       pkg
 > >Synopsis:       Unbreak devel/commit-patch
 > >Confidential:   no
 > >Severity:       non-critical
 > >Priority:       low
 > >Responsible:    pkg-manager
 > >State:          open
 > >Class:          sw-bug
 > >Submitter-Id:   net
 > >Arrival-Date:   Tue Dec 16 03:15:00 +0000 2014
 > >Originator:     Sevan Janiyan
 > >Release:        pkgsrc-current
 > >Organization:
 > >Environment:
 > Darwin 8.11.0 Darwin Kernel Version 8.11.0: Wed Oct 10 18:26:00 PDT 2007; root:xnu-792.24.17~1/RELEASE_PPC Power Macintosh powerpc
 > >Description:
 > -a for cp is the same as -pPR, older operating systems may not support -a e.g Darwin 8

 If you change the install target anyway, why not make it use the
 appropriate BSD_INSTALL_* commands? Those'll also set permissions
 correctly, and are set by pkgsrc.
  Thomas

From: "OBATA Akio" <obata@lins.jp>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/49475: Unbreak devel/commit-patch
Date: Tue, 16 Dec 2014 18:20:39 +0900

 On Tue, 16 Dec 2014 18:00:01 +0900, Thomas Klausner <wiz@netbsd.org> wrote:

 >  > -a for cp is the same as -pPR, older operating systems may not support -a e.g Darwin 8
 > If you change the install target anyway, why not make it use the
 >  appropriate BSD_INSTALL_* commands? Those'll also set permissions
 >  correctly, and are set by pkgsrc.

 BSD_INSTALL_* may not help it because "-R" means many files must be installed recursively.

 -- 
 OBATA Akio / obata@lins.jp

From: "OBATA Akio" <obache@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/49475 CVS commit: pkgsrc/devel/commit-patch
Date: Wed, 17 Dec 2014 06:08:13 +0000

 Module Name:	pkgsrc
 Committed By:	obache
 Date:		Wed Dec 17 06:08:13 UTC 2014

 Modified Files:
 	pkgsrc/devel/commit-patch: distinfo
 	pkgsrc/devel/commit-patch/patches: patch-Makefile

 Log Message:
 "-a" option for cp(1) is not portable, use standard combination "-RpP" instead.
 PR pkg/49475 by Sevan Janiyan.


 To generate a diff of this commit:
 cvs rdiff -u -r1.1 -r1.2 pkgsrc/devel/commit-patch/distinfo
 cvs rdiff -u -r1.1 -r1.2 pkgsrc/devel/commit-patch/patches/patch-Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Fri, 26 Dec 2014 21:31:06 +0000
State-Changed-Why:
fixed, thanks


>Unformatted:

Home	PR Database Search