NetBSD Problem Report #49762

From www@NetBSD.org  Fri Mar 20 05:54:49 2015
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 2ECD6A65B7
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 20 Mar 2015 05:54:49 +0000 (UTC)
Message-Id: <20150320055447.834A0A65B9@mollari.NetBSD.org>
Date: Fri, 20 Mar 2015 05:54:47 +0000 (UTC)
From: bnjf+netbsd@bnjf.id.au
Reply-To: bnjf+netbsd@bnjf.id.au
To: gnats-bugs@NetBSD.org
Subject: archivers/zoo won't build on Solaris
X-Send-Pr-Version: www-1.0

>Number:         49762
>Category:       pkg
>Synopsis:       archivers/zoo won't build on Solaris
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    jperkin
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Mar 20 05:55:00 +0000 2015
>Last-Modified:  Fri Sep 21 12:10:13 +0000 2018
>Originator:     Brad Forschinger
>Release:        2014Q4
>Organization:
>Environment:
SunOS x 5.10 Generic_Virtual sun4u sparc SUNW,SPARC-Enterprise
>Description:
"bsd.c", line 83: undefined struct/union member: tm_gmtoff
>How-To-Repeat:

>Fix:

From ctime(3c):

...
extern time_t timezone, altzone;
...
alternate time zone. The external variable timezone contains
the  difference,  in seconds, between UTC and local standard
time.  The external variable daylight indicates whether time
...

--- bsd.c.orig  Fri Mar 20 16:49:52 2015
+++ bsd.c       Fri Mar 20 16:50:02 2015
@@ -78,9 +78,13 @@
    struct tm *tm;
        if (retval != INV_VALUE)                                 /* if have cached value, return it */
                return retval;
+#if 0
        time(&lt);
        tm = localtime(&lt);
        retval = -tm->tm_gmtoff;
+#else
+       retval = timezone;
+#endif
        return retval;
 }


>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->solaris-pkg-people
Responsible-Changed-By: wiz@NetBSD.org
Responsible-Changed-When: Fri, 20 Mar 2015 06:52:32 +0000
Responsible-Changed-Why:
Solaris pkgsrc problem


From: Jonathan Perkin <jperkin@pkgsrc.org>
To: gnats-bugs@NetBSD.org
Cc: solaris-pkg-people@NetBSD.org, pkg-manager@netbsd.org,
	pkgsrc-bugs@netbsd.org, gnats-admin@netbsd.org, wiz@NetBSD.org,
	bnjf+netbsd@bnjf.id.au
Subject: Re: pkg/49762 (archivers/zoo won't build on Solaris)
Date: Thu, 26 Mar 2015 09:28:00 +0000

 The build was fixed in current back in January, though with a different
 fix which doesn't take into consideration the offset.  Could you try your
 change with the most recent version and report back whether it works?

 Thanks.

 -- 
 Jonathan Perkin       www.perkin.org.uk
 github.com/jperkin  twitter.com/jperkin

From: Brad Forschinger <bnjf@bnjf.id.au>
To: Jonathan Perkin <jperkin@pkgsrc.org>
Cc: gnats-bugs@netbsd.org, solaris-pkg-people@netbsd.org, 
	pkg-manager@netbsd.org, pkgsrc-bugs@netbsd.org, gnats-admin@netbsd.org, 
	wiz@netbsd.org, bnjf+netbsd@bnjf.id.au
Subject: Re: pkg/49762 (archivers/zoo won't build on Solaris)
Date: Fri, 27 Mar 2015 12:14:05 +1100

 zoo-2.10.1nb4 built OK!

 On Thu, Mar 26, 2015 at 8:28 PM, Jonathan Perkin <jperkin@pkgsrc.org> wrote:
 > The build was fixed in current back in January, though with a different
 > fix which doesn't take into consideration the offset.  Could you try your
 > change with the most recent version and report back whether it works?
 >
 > Thanks.
 >
 > --
 > Jonathan Perkin       www.perkin.org.uk
 > github.com/jperkin  twitter.com/jperkin

From: Brad Forschinger <bnjf@bnjf.id.au>
To: Jonathan Perkin <jperkin@pkgsrc.org>
Cc: gnats-bugs@netbsd.org, solaris-pkg-people@netbsd.org, 
	pkg-manager@netbsd.org, pkgsrc-bugs@netbsd.org, gnats-admin@netbsd.org, 
	wiz@netbsd.org, bnjf+netbsd@bnjf.id.au
Subject: Re: pkg/49762 (archivers/zoo won't build on Solaris)
Date: Fri, 27 Mar 2015 12:18:10 +1100

 I just saw the patch-ab

 +#if defined(__sun)
 +       retval = 0;
 +#else

 not sure if ignoring the tz is the best approach, you can get it from
 "extern time_t timezone;".  perhaps:

 +#if defined(__sun)
 +       retval = timezone;
 +#else

 ?


 On Fri, Mar 27, 2015 at 12:14 PM, Brad Forschinger <bnjf@bnjf.id.au> wrote:
 > zoo-2.10.1nb4 built OK!
 >
 > On Thu, Mar 26, 2015 at 8:28 PM, Jonathan Perkin <jperkin@pkgsrc.org> wrote:
 >> The build was fixed in current back in January, though with a different
 >> fix which doesn't take into consideration the offset.  Could you try your
 >> change with the most recent version and report back whether it works?
 >>
 >> Thanks.
 >>
 >> --
 >> Jonathan Perkin       www.perkin.org.uk
 >> github.com/jperkin  twitter.com/jperkin

Responsible-Changed-From-To: solaris-pkg-people->jperkin
Responsible-Changed-By: maya@NetBSD.org
Responsible-Changed-When: Fri, 21 Sep 2018 12:10:13 +0000
Responsible-Changed-Why:
there was a suggestion to improve the patch, do you think it is reasonable?


>Unformatted:

Home	PR Database Search