NetBSD Problem Report #49770

From www@NetBSD.org  Sat Mar 21 20:22:10 2015
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id A6CFEA6553
	for <gnats-bugs@gnats.NetBSD.org>; Sat, 21 Mar 2015 20:22:10 +0000 (UTC)
Message-Id: <20150321202209.62C76A6567@mollari.NetBSD.org>
Date: Sat, 21 Mar 2015 20:22:09 +0000 (UTC)
From: kjw@doglet.ca
Reply-To: kjw@doglet.ca
To: gnats-bugs@NetBSD.org
Subject: update archive/gsharutils to 4.15, make tests pass
X-Send-Pr-Version: www-1.0

>Number:         49770
>Category:       pkg
>Synopsis:       update archive/gsharutils to 4.15, make tests pass
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    hiramatsu
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sat Mar 21 20:25:00 +0000 2015
>Closed-Date:    Tue Apr 07 22:11:21 +0000 2015
>Last-Modified:  Tue Apr 07 22:11:21 +0000 2015
>Originator:     kj Woolley
>Release:        current
>Organization:
>Environment:
all
>Description:
The attached patch:

- updates archivers/gsharutils to 4.15 from 4.13.5
- changes distinfo to use SHA256 instead of SHA1
- removes --disable-uucode from configure options

The last point merits a bit more explanation. With --disable-uucode given, the tests fail. I wasn't able to find a reason for including --disable-uucode in Makefile's CVS history. If there's a good reason it should be there, feel free to close out the PR and I'll create a new one without that change.
>How-To-Repeat:
bmake package && cd work/* && bmake check
>Fix:
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/archivers/gsharutils/Makefile,v
retrieving revision 1.52
diff -r1.52 Makefile
3c3
< DISTNAME=     sharutils-4.13.5
---
> DISTNAME=     sharutils-4.15
22d21
< CONFIGURE_ARGS+=      --disable-uucode
Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/archivers/gsharutils/distinfo,v
retrieving revision 1.19
diff -r1.19 distinfo
3,5c3,5
< SHA1 (sharutils-4.13.5.tar.gz) = 60868635dff4c36f6ccc7be89b53a591938fa3b2
< RMD160 (sharutils-4.13.5.tar.gz) = 9f59fca8d3ec5e98ba61b7a330fa90a1d02f997d
< Size (sharutils-4.13.5.tar.gz) = 2045022 bytes
---
> SHA256 (sharutils-4.15.tar.gz) = fc9c8fde88d7c4450849730f1f56fc7c2f3801714d05a0c5877cdc59ab305999
> RMD160 (sharutils-4.15.tar.gz) = fd8b1ebe41b1df398eef53513e2e5b5b53e8bbac
> Size (sharutils-4.15.tar.gz) = 2196398 bytes

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->hiramatsu
Responsible-Changed-By: hiramatsu@NetBSD.org
Responsible-Changed-When: Sun, 05 Apr 2015 16:07:15 +0000
Responsible-Changed-Why:
I will look into this.


From: HIRAMATSU Yoshifumi <hiramatsu@NetBSD.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/49770: update archive/gsharutils to 4.15, make tests pass
Date: Mon, 06 Apr 2015 01:05:58 +0900

 Hello,

 On Sun, 22 Mar 2015 05:25:00 +0900,
 > The attached patch:
 > 
 > - updates archivers/gsharutils to 4.15 from 4.13.5
 > - changes distinfo to use SHA256 instead of SHA1
 > - removes --disable-uucode from configure options
 > 
 > The last point merits a bit more explanation. With --disable-uucode given, the tests fail. I wasn't able to find a reason for including --disable-uucode in Makefile's CVS history. If there's a good reason it should be there, feel free to close out the PR and I'll create a new one without that change.

 Thank you for creating this patch, I'm going to commit it in a few days.

 I will change two points, however.

 1. I will use SHA1 checksum.

    SHA256 is considered better than SHA1 because of collision probability,
    and pkgsrc accepts SHA256.
    But other packages use SHA1, I will use SHA1 for consistency.

 2. PLIST needs update too.

    Because we will enable uuencode, PLIST also should be updated.

    kjw, do you define "PKG_DEVELOPER=yes" in your mk.conf?
    When you have PKG_DEVELOPER=yes pkgsrc performs sanity checks during
    build and install, and I noticed the PLIST issue by the checks.

    If you work on more packages, it will really help.

 Kind regards,
 HIRAMATSU, Yoshifumi

From: "Hiramatsu Yoshifumi" <hiramatsu@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/49770 CVS commit: pkgsrc/archivers/gsharutils
Date: Tue, 7 Apr 2015 22:08:36 +0000

 Module Name:	pkgsrc
 Committed By:	hiramatsu
 Date:		Tue Apr  7 22:08:36 UTC 2015

 Modified Files:
 	pkgsrc/archivers/gsharutils: Makefile PLIST distinfo
 Added Files:
 	pkgsrc/archivers/gsharutils/patches: patch-lib_fseeko.c

 Log Message:
 Update archivers/gsharutils to 4.15.

 This update is provided from kj Woolley in PR 49770,
 with a patch by me for NetBSD 6.

 Changes from previous:

 Version 4.15 - February 2015, by Bruce Korb

 * shar will no longer choke on 64 bit windows
 * unshar has a compiler warning fix
 * Happy 2015 copyright
 * PO file updates

 Version 4.14.2 - December 2014, by Bruce Korb

 * translation updates
 * use ftello, fseeko and fflush
 * augment copyright marks in shar.c and shar-std.def
 * Happy 2014 copyright dates
 * fix up man pages (use newer doc generation code)

 Version 4.14 - October 2013, by Bruce Korb

 * documentation, obscure usage, FSF address


 To generate a diff of this commit:
 cvs rdiff -u -r1.52 -r1.53 pkgsrc/archivers/gsharutils/Makefile
 cvs rdiff -u -r1.11 -r1.12 pkgsrc/archivers/gsharutils/PLIST
 cvs rdiff -u -r1.19 -r1.20 pkgsrc/archivers/gsharutils/distinfo
 cvs rdiff -u -r0 -r1.1 pkgsrc/archivers/gsharutils/patches/patch-lib_fseeko.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: hiramatsu@NetBSD.org
State-Changed-When: Tue, 07 Apr 2015 22:11:21 +0000
State-Changed-Why:
Update committed.
Thanks for the PR.


>Unformatted:

Home	PR Database Search