NetBSD Problem Report #49784

From enami@sm.sony.co.jp  Wed Mar 25 23:14:47 2015
Return-Path: <enami@sm.sony.co.jp>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 0C16AA5B2E
	for <gnats-bugs@gnats.netbsd.org>; Wed, 25 Mar 2015 23:14:47 +0000 (UTC)
Message-Id: <20150325224648.6AB3710A85@sigtrap.sm.sony.co.jp>
Date: Thu, 26 Mar 2015 07:46:48 +0900 (JST)
From: enami tsugutomo <tsugutomo.enami@jp.sony.com>
Reply-To: tsugutomo.enami@jp.sony.com
To: gnats-bugs@gnats.NetBSD.org
Subject: pkgsrc/mail/isync (mbsync) dumps core while calling freeaddrinfo
X-Send-Pr-Version: 3.95

>Number:         49784
>Notify-List:    tonio@NetBSD.org
>Category:       pkg
>Synopsis:       mbsync dumps core while calling freeaddrinfo
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    bsiegert
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Mar 25 23:15:00 +0000 2015
>Closed-Date:    Sat Jul 04 15:57:32 +0000 2015
>Last-Modified:  Wed Jul 08 19:55:00 +0000 2015
>Originator:     enami tsugutomo
>Release:        NetBSD 6.1_STABLE
>Organization:
>Environment:
System: NetBSD sigtrap.sm.sony.co.jp 6.1_STABLE NetBSD 6.1_STABLE (GENERIC) #60: Mon Jan 5 11:29:11 JST 2015 enami@sigtrap.sm.sony.co.jp:/home/enami/src/netbsd-6/obj.amd64/sys/arch/amd64/compile/GENERIC amd64
Architecture: x86_64
Machine: amd64
>Description:
mbsync command from pkgsrc/mail/isync dump core when it calls freeaddrinfo.
>How-To-Repeat:
Setup mbsync and try to run.

enami@sigtrap% gdb -q mbsync mbsync.core 
Reading symbols from /usr/pkg/bin/mbsync...(no debugging symbols found)...done.
[New process 1]
Core was generated by `mbsync'.
Program terminated with signal 11, Segmentation fault.
#0  0x00007f7ff6ab614f in freeaddrinfo () from /usr/lib/libc.so.12
(gdb) bt
#0  0x00007f7ff6ab614f in freeaddrinfo () from /usr/lib/libc.so.12
#1  0x000000000040b48f in ?? ()
#2  0x000000000040c055 in ?? ()
#3  0x0000000000403bed in ?? ()
#4  0x00000000004047bc in ?? ()
#5  0x00000000004033c2 in ?? ()
#6  0x00007f7ff7ffa000 in ?? ()
#7  0x0000000000000003 in ?? ()
#8  0x00007f7ffffffe30 in ?? ()
#9  0x00007f7ffffffe37 in ?? ()
#10 0x00007f7ffffffe3a in ?? ()
#11 0x0000000000000000 in ?? ()
(gdb) 
>Fix:
Following change work for me (isync 1.1.2 also has this problem, btw):

--- src/socket.c.orig	2014-11-08 12:19:59.000000000 +0000
+++ src/socket.c
@@ -477,7 +477,10 @@ static void
 socket_connected( conn_t *conn )
 {
 #ifdef HAVE_IPV6
-	freeaddrinfo( conn->addrs );
+	if ( conn->addrs ) {
+		freeaddrinfo( conn->addrs );
+		conn->addrs = NULL;
+	}
 #endif
 	conf_fd( conn->fd, 0, POLLIN );
 	conn->state = SCK_READY;
@@ -488,7 +491,10 @@ static void
 socket_connect_bail( conn_t *conn )
 {
 #ifdef HAVE_IPV6
-	freeaddrinfo( conn->addrs );
+	if ( conn->addrs ) {
+		freeaddrinfo( conn->addrs );
+		conn->addrs = NULL;
+	}
 #endif
 	free( conn->name );
 	conn->name = 0;

>Release-Note:

>Audit-Trail:

From: "Benny Siegert" <bsiegert@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/49784 CVS commit: pkgsrc/mail/isync
Date: Sat, 4 Jul 2015 15:52:51 +0000

 Module Name:	pkgsrc
 Committed By:	bsiegert
 Date:		Sat Jul  4 15:52:51 UTC 2015

 Modified Files:
 	pkgsrc/mail/isync: Makefile distinfo
 Added Files:
 	pkgsrc/mail/isync/patches: patch-src_socket.c

 Log Message:
 Fix crashing bug in mbsync on NetBSD 6. From Enami Tsugutumo in
 PR pkg/49784.


 To generate a diff of this commit:
 cvs rdiff -u -r1.36 -r1.37 pkgsrc/mail/isync/Makefile
 cvs rdiff -u -r1.13 -r1.14 pkgsrc/mail/isync/distinfo
 cvs rdiff -u -r0 -r1.3 pkgsrc/mail/isync/patches/patch-src_socket.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

Responsible-Changed-From-To: pkg-manager->bsiegert
Responsible-Changed-By: bsiegert@NetBSD.org
Responsible-Changed-When: Sat, 04 Jul 2015 15:57:32 +0000
Responsible-Changed-Why:


State-Changed-From-To: open->closed
State-Changed-By: bsiegert@NetBSD.org
State-Changed-When: Sat, 04 Jul 2015 15:57:32 +0000
State-Changed-Why:
Committed, thanks!


From: "Matthias Scheler" <tron@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/49784 CVS commit: [pkgsrc-2015Q2] pkgsrc/mail/isync
Date: Wed, 8 Jul 2015 19:51:35 +0000

 Module Name:	pkgsrc
 Committed By:	tron
 Date:		Wed Jul  8 19:51:35 UTC 2015

 Modified Files:
 	pkgsrc/mail/isync [pkgsrc-2015Q2]: Makefile distinfo
 Added Files:
 	pkgsrc/mail/isync/patches [pkgsrc-2015Q2]: patch-src_socket.c

 Log Message:
 Pullup ticket #4760 - requested by bsiegert
 mail/isync: bug fix patch

 Revisions pulled up:
 - mail/isync/Makefile                                           1.37
 - mail/isync/distinfo                                           1.14
 - mail/isync/patches/patch-src_socket.c                         1.3

 ---
    Module Name:    pkgsrc
    Committed By:   bsiegert
    Date:           Sat Jul  4 15:52:51 UTC 2015

    Modified Files:
            pkgsrc/mail/isync: Makefile distinfo
    Added Files:
            pkgsrc/mail/isync/patches: patch-src_socket.c

    Log Message:
    Fix crashing bug in mbsync on NetBSD 6. From Enami Tsugutumo in
    PR pkg/49784.


 To generate a diff of this commit:
 cvs rdiff -u -r1.36 -r1.36.6.1 pkgsrc/mail/isync/Makefile
 cvs rdiff -u -r1.13 -r1.13.10.1 pkgsrc/mail/isync/distinfo
 cvs rdiff -u -r0 -r1.3.2.2 pkgsrc/mail/isync/patches/patch-src_socket.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search