NetBSD Problem Report #49787

From www@NetBSD.org  Thu Mar 26 04:11:04 2015
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id B20A9A654B
	for <gnats-bugs@gnats.NetBSD.org>; Thu, 26 Mar 2015 04:11:04 +0000 (UTC)
Message-Id: <20150326041103.222B5A6552@mollari.NetBSD.org>
Date: Thu, 26 Mar 2015 04:11:03 +0000 (UTC)
From: bnjf+netbsd@bnjf.id.au
Reply-To: bnjf+netbsd@bnjf.id.au
To: gnats-bugs@NetBSD.org
Subject: lang/guile won't build on Solaris
X-Send-Pr-Version: www-1.0

>Number:         49787
>Category:       pkg
>Synopsis:       lang/guile won't build on Solaris
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    maya
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Mar 26 04:15:00 +0000 2015
>Closed-Date:    Thu Nov 10 09:27:43 +0000 2016
>Last-Modified:  Thu Nov 10 09:30:00 +0000 2016
>Originator:     Brad Forschinger
>Release:        2014Q4
>Organization:
>Environment:
SunOS x 5.10 Generic_Virtual sun4u sparc SUNW,SPARC-Enterprise
cc: Sun C 5.12 SunOS_sparc Patch 148917-08 2014/09/10

>Description:

gmake[3]: Entering directory `/usr/pkgsrc/lang/guile/work/guile-1.8.8/libguile'
source='gc_os_dep.c' object='libguile_la-gc_os_dep.lo' libtool=yes \
DEPDIR=.deps depmode=none /usr/pkg/bin/pdksh ../build-aux/depcomp \
/usr/pkg/bin/pdksh ../libtool  --tag=CC   --mode=compile cc -DHAVE_CONFIG_H   -I.. -I.. -I.. -I/usr/pkg/include -I/usr/include -I/usr/pkg/include -I/usr/include -D_REENTRANT  -pthread  -O -I. -pthrea
d -I/usr/pkg/include -I/usr/include -c -o libguile_la-gc_os_dep.lo `test -f 'gc_os_dep.c' || echo './'`gc_os_dep.c
libtool: compile:  cc -DHAVE_CONFIG_H -I.. -I/usr/pkgsrc/lang/guile/work/.buildlink/include -D_REENTRANT -pthread -O -I. -pthread -c gc_os_dep.c  -KPIC -DPIC -o .libs/libguile_la-gc_os_dep.o
"gc_os_dep.c", line 1938: undefined symbol: USERLIMIT
cc: acomp failed for gc_os_dep.c
gmake[3]: *** [libguile_la-gc_os_dep.lo] Error 1

>How-To-Repeat:

>Fix:

--- gc_os_dep.c.orig    Thu Mar 26 15:07:39 2015
+++ gc_os_dep.c Thu Mar 26 15:08:05 2015
@@ -720,9 +720,6 @@
 /*      but reportedly breaks under 2.8.  It appears that the stack     */
 /*      base is a property of the executable, so this should not break  */
 /*      old executables.                                                */
-/*      HEURISTIC2 probably works, but this appears to be preferable.   */
-#       include <sys/vm.h>
-#       define STACKBOTTOM ((ptr_t) USRSTACK)
 #      ifndef USE_MMAP
 #          define USE_MMAP
 #      endif

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->solaris-pkg-people
Responsible-Changed-By: wiz@NetBSD.org
Responsible-Changed-When: Thu, 26 Mar 2015 08:05:59 +0000
Responsible-Changed-Why:
Solaris pkgsrc problem.


Responsible-Changed-From-To: solaris-pkg-people->maya
Responsible-Changed-By: maya@NetBSD.org
Responsible-Changed-When: Thu, 10 Nov 2016 09:27:43 +0000
Responsible-Changed-Why:
I went down this rabbit hole already


State-Changed-From-To: open->closed
State-Changed-By: maya@NetBSD.org
State-Changed-When: Thu, 10 Nov 2016 09:27:43 +0000
State-Changed-Why:
I've applied your change as-is, and the package hasn't been updated since.
I'm assuming it works now as you've tested the same. let me know if it turns to not work.


From: "Maya Rashish" <maya@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/49787 CVS commit: pkgsrc/lang/guile
Date: Thu, 10 Nov 2016 09:26:21 +0000

 Module Name:	pkgsrc
 Committed By:	maya
 Date:		Thu Nov 10 09:26:21 UTC 2016

 Modified Files:
 	pkgsrc/lang/guile: distinfo
 	pkgsrc/lang/guile/patches: patch-ae

 Log Message:
 guile: SunOS specific changes - don't declare STACKBOTTOM unless
 USERLIMIT is given.

 From Brad Forschinger in PR pkg/49787

 Also from both boehm-gc commit, where there is a longer description of issues
 in issue #122:
 https://github.com/ivmai/bdwgc/issues/122
 https://github.com/ivmai/bdwgc/commit/81cae56522e601fc2e9e9bab08c87d1302c118fb

 we have the additions here (adding the definition of STACKBOTTOM if USERLIMIT
 otherwise use HEURISTIC2), but not the removal of the first part, which
 declares STACKBOTTOM unconditionally.

 Reportedly fixes build on SunOS 5.10 sun4u.


 To generate a diff of this commit:
 cvs rdiff -u -r1.49 -r1.50 pkgsrc/lang/guile/distinfo
 cvs rdiff -u -r1.17 -r1.18 pkgsrc/lang/guile/patches/patch-ae

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2014 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.