NetBSD Problem Report #49852

From www@NetBSD.org  Fri Apr 24 15:34:42 2015
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id C789FA654C
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 24 Apr 2015 15:34:41 +0000 (UTC)
Message-Id: <20150424153440.611FFA654F@mollari.NetBSD.org>
Date: Fri, 24 Apr 2015 15:34:40 +0000 (UTC)
From: alex-b@opus-b.com
Reply-To: alex-b@opus-b.com
To: gnats-bugs@NetBSD.org
Subject: net/socat on Darwin/MacOS X build wrongly fails due to "No acceptable compiler found"
X-Send-Pr-Version: www-1.0

>Number:         49852
>Category:       pkg
>Synopsis:       net/socat on Darwin/MacOS X build wrongly fails due to "No acceptable compiler found"
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Apr 24 15:35:00 +0000 2015
>Closed-Date:    Sun Apr 26 17:36:49 +0000 2015
>Last-Modified:  Tue Apr 28 10:35:00 +0000 2015
>Originator:     Alexander Borkowski
>Release:        pkgsrc-2015Q1 2015-04-25
>Organization:
>Environment:
Darwin nostromo.opus-b.com 11.4.2 Darwin Kernel Version 11.4.2: Thu Aug 23 16:25:48 PDT 2012; root:xnu-1699.32.7~1/RELEASE_X86_64 x86_64
>Description:
A build attempt of net/socat on Darwin/MacOS X aborts with the following messages:

ERROR: This package is only available for these compilers: gcc.
ERROR: This package has set PKG_FAIL_REASON:
ERROR: No acceptable compiler found for socat-1.7.2.4.

The reason is that in the Makefile for that package it says:

ONLY_FOR_COMPILER= gcc # uses -Werror in the configure script

and bootstrap set

PKGSRC_COMPILER= clang

in etc/mk.conf.

I manually added clang to ONLY_FOR_COMPILER in the Makefile and the package builds, installs and works ok so far. Regarding the -Werror comment, clang has that as well.
>How-To-Repeat:
Attempt to build pkgsrc package net/socat on Darwin/MacOS X.

>Fix:
Edit pkgsrc package net/socat Makefile to add clang to the ONLY_FOR_COMPILER variable.

>Release-Note:

>Audit-Trail:
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/49852 CVS commit: pkgsrc/net/socat
Date: Sat, 25 Apr 2015 23:31:23 +0000

 Module Name:	pkgsrc
 Committed By:	dholland
 Date:		Sat Apr 25 23:31:23 UTC 2015

 Modified Files:
 	pkgsrc/net/socat: Makefile

 Log Message:
 Add clang to ONLY_FOR_COMPILER per PR 49852 from Alexander Borkowski.

 (XXX: shouldn't the wrappers be taking care of -Werror for compilers
 that don't understand it?)


 To generate a diff of this commit:
 cvs rdiff -u -r1.32 -r1.33 pkgsrc/net/socat/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Joerg Sonnenberger <joerg@britannica.bec.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: PR/49852 CVS commit: pkgsrc/net/socat
Date: Sun, 26 Apr 2015 13:15:26 +0200

 On Sat, Apr 25, 2015 at 11:35:00PM +0000, David A. Holland wrote:
 > The following reply was made to PR pkg/49852; it has been noted by GNATS.
 > 
 > From: "David A. Holland" <dholland@netbsd.org>
 > To: gnats-bugs@gnats.NetBSD.org
 > Cc: 
 > Subject: PR/49852 CVS commit: pkgsrc/net/socat
 > Date: Sat, 25 Apr 2015 23:31:23 +0000
 > 
 >  Module Name:	pkgsrc
 >  Committed By:	dholland
 >  Date:		Sat Apr 25 23:31:23 UTC 2015
 >  
 >  Modified Files:
 >  	pkgsrc/net/socat: Makefile
 >  
 >  Log Message:
 >  Add clang to ONLY_FOR_COMPILER per PR 49852 from Alexander Borkowski.
 >  
 >  (XXX: shouldn't the wrappers be taking care of -Werror for compilers
 >  that don't understand it?)

 I've removed it. It shouldn't have been added in first place. You are
 right that just dropping it or translating it into whatever flag the
 compiler has is a much better approach.

 Joerg

From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: PR/49852 CVS commit: pkgsrc/net/socat
Date: Sun, 26 Apr 2015 17:32:25 +0000

 On Sun, Apr 26, 2015 at 11:20:01AM +0000, Joerg Sonnenberger wrote:
  >  >  Modified Files:
  >  >  	pkgsrc/net/socat: Makefile
  >  >  
  >  >  Log Message:
  >  >  Add clang to ONLY_FOR_COMPILER per PR 49852 from Alexander Borkowski.
  >  >  
  >  >  (XXX: shouldn't the wrappers be taking care of -Werror for compilers
  >  >  that don't understand it?)
  >  
  >  I've removed it. It shouldn't have been added in first place. You are
  >  right that just dropping it or translating it into whatever flag the
  >  compiler has is a much better approach.

 Someone added it because it was breaking *something*; maybe it would
 have been a good idea to find out what and sort it out before
 rebreaking the package. :-p

 -- 
 David A. Holland
 dholland@netbsd.org

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sun, 26 Apr 2015 17:36:49 +0000
State-Changed-Why:
In any case the issue is fixed.


From: Joerg Sonnenberger <joerg@britannica.bec.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: PR/49852 CVS commit: pkgsrc/net/socat
Date: Sun, 26 Apr 2015 20:17:49 +0200

 On Sun, Apr 26, 2015 at 05:35:00PM +0000, David Holland wrote:
 > The following reply was made to PR pkg/49852; it has been noted by GNATS.
 > 
 > From: David Holland <dholland-pbugs@netbsd.org>
 > To: gnats-bugs@NetBSD.org
 > Cc: 
 > Subject: Re: PR/49852 CVS commit: pkgsrc/net/socat
 > Date: Sun, 26 Apr 2015 17:32:25 +0000
 > 
 >  On Sun, Apr 26, 2015 at 11:20:01AM +0000, Joerg Sonnenberger wrote:
 >   >  >  Modified Files:
 >   >  >  	pkgsrc/net/socat: Makefile
 >   >  >  
 >   >  >  Log Message:
 >   >  >  Add clang to ONLY_FOR_COMPILER per PR 49852 from Alexander Borkowski.
 >   >  >  
 >   >  >  (XXX: shouldn't the wrappers be taking care of -Werror for compilers
 >   >  >  that don't understand it?)
 >   >  
 >   >  I've removed it. It shouldn't have been added in first place. You are
 >   >  right that just dropping it or translating it into whatever flag the
 >   >  compiler has is a much better approach.
 >  
 >  Someone added it because it was breaking *something*; maybe it would
 >  have been a good idea to find out what and sort it out before
 >  rebreaking the package. :-p

 Setting ONLY_FOR_COMPILER is not really going to fix that something, at
 best it will hide the issue behind "this is not supported".

 Joerg

From: "Matthias Scheler" <tron@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/49852 CVS commit: [pkgsrc-2015Q1] pkgsrc/net/socat
Date: Mon, 27 Apr 2015 22:02:37 +0000

 Module Name:	pkgsrc
 Committed By:	tron
 Date:		Mon Apr 27 22:02:37 UTC 2015

 Modified Files:
 	pkgsrc/net/socat [pkgsrc-2015Q1]: Makefile

 Log Message:
 Pullup ticket #4689 - requested by dholland
 net/socat: build fix

 Revisions pulled up:
 - net/socat/Makefile                                            1.33

 ---
    Module Name:	pkgsrc
    Committed By:	dholland
    Date:		Sat Apr 25 23:31:23 UTC 2015

    Modified Files:
    	pkgsrc/net/socat: Makefile

    Log Message:
    Add clang to ONLY_FOR_COMPILER per PR 49852 from Alexander Borkowski.

    (XXX: shouldn't the wrappers be taking care of -Werror for compilers
    that don't understand it?)


 To generate a diff of this commit:
 cvs rdiff -u -r1.32 -r1.32.6.1 pkgsrc/net/socat/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: PR/49852 CVS commit: pkgsrc/net/socat
Date: Tue, 28 Apr 2015 10:32:36 +0000

 On Sun, Apr 26, 2015 at 06:20:01PM +0000, Joerg Sonnenberger wrote:
  >  >  Someone added it because it was breaking *something*; maybe it would
  >  >  have been a good idea to find out what and sort it out before
  >  >  rebreaking the package. :-p
  >  
  >  Setting ONLY_FOR_COMPILER is not really going to fix that something, at
  >  best it will hide the issue behind "this is not supported".

 Sure, but now we're open-loop waiting for someone to notice something
 wrong somewhere else.

 Of course the cvs history just says "only for gcc", and that was in
 2008, so probably the information's lost anyway.

 -- 
 David A. Holland
 dholland@netbsd.org

>Unformatted:

Home	PR Database Search