NetBSD Problem Report #49878

From www@NetBSD.org  Tue May  5 11:01:10 2015
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 4FF01A654C
	for <gnats-bugs@gnats.NetBSD.org>; Tue,  5 May 2015 11:01:10 +0000 (UTC)
Message-Id: <20150505110109.384C5A65B7@mollari.NetBSD.org>
Date: Tue,  5 May 2015 11:01:09 +0000 (UTC)
From: hponeill@me.com
Reply-To: hponeill@me.com
To: gnats-bugs@NetBSD.org
Subject: xfe fails to build 
X-Send-Pr-Version: www-1.0

>Number:         49878
>Category:       pkg
>Synopsis:       xfe fails to build
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue May 05 11:05:00 +0000 2015
>Closed-Date:    Wed Aug 26 11:34:59 +0000 2015
>Last-Modified:  Wed Aug 26 11:35:01 +0000 2015
>Originator:     Paul ONeill
>Release:        pkgsrc 2015Q1
>Organization:
>Environment:
NetBSD 6.1.2 (GENERIC) i386
>Description:
trying to build xfe results in the configure error 
ftheader.h not found

ftheader is part of the freetype2 package
>How-To-Repeat:
try to build xfe from source
>Fix:
editing the configure script line 4235

change "config/ftheader.h"
to "freetype/config/ftheader.h"

will allow xfe to build but this may not be an appropriate fix.

>Release-Note:

>Audit-Trail:
From: Leonardo Taccari <iamleot@gmail.com>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/49878: xfe fails to build
Date: Wed, 06 May 2015 20:14:30 +0200

 Hello Paul and the entire pkgsrc community,

 hponeill@me.com writes:
 > [...]
 > >Environment:
 > NetBSD 6.1.2 (GENERIC) i386
 > >Description:
 > trying to build xfe results in the configure error =

 > ftheader.h not found
 > =

 > ftheader is part of the freetype2 package
 > >How-To-Repeat:
 > try to build xfe from source
 > >Fix:
 > editing the configure script line 4235
 > =

 > change "config/ftheader.h"
 > to "freetype/config/ftheader.h"
 > =

 > will allow xfe to build but this may not be an appropriate fix.
 I have investigated a bit regarding this problem... Looking at the xfe
 changelog it seems that they discussed and applied the change in xfe bug
 #192:

  http://sourceforge.net/p/xfe/bugs/192/

 The problem affects older version of freetype2 (e.g. here on
 NetBSD-current and also on NetBSD 7.0_BETA the path for ftheader.h is
 correct). But as you pointed out it still works also with older version
 of freetype2 so IMHO we should not force to depends on pkgsrc version
 graphics/freetype2. Also bump PKGREVISION.

 I will attach patches to fix this issue inline in this email. While here
 I have also added LICENSE and squashed various pkgtools/pkglint
 warnings.


 Paul, can you try it and let us know if it works correctly please (I
 have only tested it on NetBSD-current and pkgsrc-current)?


 Ciao,
 L.


 -------------------8<-----------------8<-----------------8<---------------=
 ----
 Index: Makefile
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 RCS file: /cvsroot/pkgsrc/sysutils/xfe/Makefile,v
 retrieving revision 1.48
 diff -u -r1.48 Makefile
 --- Makefile	25 Apr 2015 14:24:56 -0000	1.48
 +++ Makefile	6 May 2015 18:12:03 -0000
 @@ -1,13 +1,14 @@
  # $NetBSD: Makefile,v 1.48 2015/04/25 14:24:56 tnn Exp $
  =

  DISTNAME=3D	xfe-1.40
 -PKGREVISION=3D	1
 +PKGREVISION=3D	2
  CATEGORIES=3D	sysutils
  MASTER_SITES=3D	${MASTER_SITE_SOURCEFORGE:=3Dxfe/}
  =

  MAINTAINER=3D	pkgsrc-users@NetBSD.org
  HOMEPAGE=3D	http://roland65.free.fr/xfe/
  COMMENT=3D	Fast MS-Explorer like filemanager for X
 +LICENSE=3D	gnu-gpl-v2
  =

  USE_LANGUAGES=3D		c c++
  USE_PKGLOCALEDIR=3D	yes
 @@ -25,6 +26,7 @@
  =

  .include "../../converters/libiconv/buildlink3.mk"
  .include "../../devel/gettext-lib/buildlink3.mk"
 +.include "../../sysutils/desktop-file-utils/desktopdb.mk"
  .include "../../x11/fox/buildlink3.mk"
  .include "../../mk/pthread.buildlink3.mk"
  .include "../../mk/bsd.pkg.mk"
 Index: distinfo
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 RCS file: /cvsroot/pkgsrc/sysutils/xfe/distinfo,v
 retrieving revision 1.12
 diff -u -r1.12 distinfo
 --- distinfo	15 Feb 2015 14:09:38 -0000	1.12
 +++ distinfo	6 May 2015 18:12:03 -0000
 @@ -4,5 +4,5 @@
  RMD160 (xfe-1.40.tar.gz) =3D a2add3bdac71706da9ea791d88bc96cbcdc3afb3
  Size (xfe-1.40.tar.gz) =3D 2574477 bytes
  SHA1 (patch-ac) =3D 001140df584ef01d52e0737a57e0babbc574a0b4
 -SHA1 (patch-configure) =3D 1eb11db5286e4cf3b3829a5a2370c9d4acb2d1a5
 +SHA1 (patch-configure) =3D 406757b915cbd266bc9e4dfd2402f6676c976ee6
  SHA1 (patch-src_main.cpp) =3D 2e875f4235b7e4c22ad5a0c236144bdd549fb8a1
 Index: patches/patch-configure
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 RCS file: /cvsroot/pkgsrc/sysutils/xfe/patches/patch-configure,v
 retrieving revision 1.1
 diff -u -r1.1 patch-configure
 --- patches/patch-configure	15 Feb 2015 14:09:38 -0000	1.1
 +++ patches/patch-configure	6 May 2015 18:12:03 -0000
 @@ -1,8 +1,24 @@
 -$NetBSD: patch-configure,v 1.1 2015/02/15 14:09:38 ryoon Exp $
 +$NetBSD$
 +
 +o Older freetype2 versions have a different path for ftheader.h, also che=
 ck for
 +  it in order to avoid forcing dependency to the pkgsrc version of
 +  graphics/freetype2. For more information please give a look to pkg/4987=
 8.
 +o test(1) does not support the "=3D=3D" operator. Use the "=3D" operator =
 to compare if
 +  two strings are identical.
  =

  --- configure.orig	2014-12-05 14:51:58.000000000 +0000
  +++ configure
 -@@ -16194,7 +16194,7 @@ echo "=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 +@@ -14233,7 +14233,9 @@ done
 + 	  CPPFLAGS=3D"$freetype_cflags $CPPFLAGS"
 + 	fi
 + 	ac_fn_cxx_check_header_mongrel "$LINENO" "config/ftheader.h" "ac_cv_hea=
 der_config_ftheader_h" "$ac_includes_default"
 ++	ac_fn_cxx_check_header_mongrel "$LINENO" "freetype/config/ftheader.h" "=
 ac_cv_header_freetype_config_ftheader_h" "$ac_includes_default"
 + if test "x$ac_cv_header_config_ftheader_h" =3D xyes; then :
 ++elif test "x$ac_cv_header_freetype_config_ftheader_h" =3D xyes; then :
 + =

 + else
 +   as_fn_error $? "\"ftheader.h not found\"" "$LINENO" 5
 +@@ -16194,7 +16196,7 @@ echo "=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
   =

   =

   # Warning message about Xft support

State-Changed-From-To: open->feedback
State-Changed-By: bsiegert@NetBSD.org
State-Changed-When: Sun, 28 Jun 2015 15:03:18 +0000
State-Changed-Why:
Paul, could you test if the patch from Leonardo fixes the issue?


From: Leonardo Taccari <iamleot@gmail.com>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/49878 (xfe fails to build)
Date: Mon, 29 Jun 2015 17:16:47 +0200

 Dear Benny and Paul,

 bsiegert@NetBSD.org writes:
 > Synopsis: xfe fails to build
 > =

 > State-Changed-From-To: open->feedback
 > State-Changed-By: bsiegert@NetBSD.org
 > State-Changed-When: Sun, 28 Jun 2015 15:03:18 +0000
 > State-Changed-Why:
 > Paul, could you test if the patch from Leonardo fixes the issue?
 gnats (or my MUA) probably added some noises to the patch (AFAIK the
 originator and all the responsables of the PR get a "good" email anyway
 while others[0] no). In case of problems I have (re)published here the
 same patch:

  https://gist.githubusercontent.com/iamleot/7adea6bb77a3b98e8700/raw/05477=
 f89d401da69e3dec0b982a40e50e5d941bf/patch-xfe


 Ciao,
 L.

 [0]: http://mail-index.netbsd.org/pkgsrc-bugs/2015/05/06/msg056721.html

State-Changed-From-To: feedback->closed
State-Changed-By: leot@NetBSD.org
State-Changed-When: Wed, 26 Aug 2015 11:34:59 +0000
State-Changed-Why:
xfe-1.40nb2 works also with older freetype2 versions. Thank you Paul for the PR!


From: "Leonardo Taccari" <leot@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/49878 CVS commit: pkgsrc/sysutils/xfe
Date: Wed, 26 Aug 2015 11:31:02 +0000

 Module Name:	pkgsrc
 Committed By:	leot
 Date:		Wed Aug 26 11:31:02 UTC 2015

 Modified Files:
 	pkgsrc/sysutils/xfe: Makefile distinfo
 	pkgsrc/sysutils/xfe/patches: patch-configure

 Log Message:
 Fix a configure problem with older freetype2 versions (and while here add
 LICENSE and fix a warning reported by pkglint(1)).
 Reported by Paul ONeill in PR pkg/49878. This closes PR pkg/49878.


 To generate a diff of this commit:
 cvs rdiff -u -r1.48 -r1.49 pkgsrc/sysutils/xfe/Makefile
 cvs rdiff -u -r1.12 -r1.13 pkgsrc/sysutils/xfe/distinfo
 cvs rdiff -u -r1.1 -r1.2 pkgsrc/sysutils/xfe/patches/patch-configure

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search