NetBSD Problem Report #49935

From www@NetBSD.org  Sat May 30 18:55:18 2015
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 56538A654F
	for <gnats-bugs@gnats.NetBSD.org>; Sat, 30 May 2015 18:55:18 +0000 (UTC)
Message-Id: <20150530185516.69513A65C0@mollari.NetBSD.org>
Date: Sat, 30 May 2015 18:55:16 +0000 (UTC)
From: m4j0rd0m0@gmail.com
Reply-To: m4j0rd0m0@gmail.com
To: gnats-bugs@NetBSD.org
Subject: missing break in vsbus.c
X-Send-Pr-Version: www-1.0

>Number:         49935
>Category:       port-vax
>Synopsis:       missing break in vsbus.c
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    abs
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat May 30 19:00:00 +0000 2015
>Closed-Date:    Sun May 31 07:13:00 +0000 2015
>Last-Modified:  Fri Jun 19 17:25:00 +0000 2015
>Originator:     Felix Deichmann
>Release:        7.0_BETA
>Organization:
>Environment:
7.0_BETA (GENERIC.201505300950Z) vax
>Description:
A switch case in vsbus.c for VS4000/60 and VS4000/VLC is probably missing a break (or, less probable, not documenting a fall-through).

a.)
The case above for VAX49 and VAX53 it is very similar and *has* a break statement.

b.)
Looking at the changes by revision 1.23 -> 1.24 of vsbus.c, it is quite obvious that refactoring introduced ambiguity, although the following default case contained only statements with the same effect.
But in later revisions more and differing code was added to the default case...

Without extensively testing it, an affected machine (VS4000/60) seems to be fine with and without the break statement though.
>How-To-Repeat:
n/a
>Fix:
--- vsbus.c.rev1.60	Sat May 30 20:50:45 2015
+++ vsbus.c	Sat May 30 20:52:08 2015
@@ -138,6 +138,7 @@
 		sc->sc_intclr = (char *)sc->sc_vsregs + 15;
 		sc->sc_intmsk = (char *)sc->sc_vsregs + 12;
 		vsbus_dma_init(sc, 32768);
+		break;
 #endif

 	default:

>Release-Note:

>Audit-Trail:
From: "David Brownlee" <abs@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/49935 CVS commit: src/sys/arch/vax/vsa
Date: Sun, 31 May 2015 07:04:18 +0000

 Module Name:	src
 Committed By:	abs
 Date:		Sun May 31 07:04:18 UTC 2015

 Modified Files:
 	src/sys/arch/vax/vsa: vsbus.c

 Log Message:
 Add missing break - from Felix Deichmann in PR port-vax/49935


 To generate a diff of this commit:
 cvs rdiff -u -r1.60 -r1.61 src/sys/arch/vax/vsa/vsbus.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

Responsible-Changed-From-To: port-vax-maintainer->abs
Responsible-Changed-By: abs@NetBSD.org
Responsible-Changed-When: Sun, 31 May 2015 07:13:00 +0000
Responsible-Changed-Why:


State-Changed-From-To: open->closed
State-Changed-By: abs@NetBSD.org
State-Changed-When: Sun, 31 May 2015 07:13:00 +0000
State-Changed-Why:
Patch applied & pullups being sent for netbsd-7 and netbsd-6 - thanks!


From: "Stephen Borrill" <sborrill@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/49935 CVS commit: [netbsd-7] src/sys/arch/vax/vsa
Date: Tue, 2 Jun 2015 10:14:22 +0000

 Module Name:	src
 Committed By:	sborrill
 Date:		Tue Jun  2 10:14:22 UTC 2015

 Modified Files:
 	src/sys/arch/vax/vsa [netbsd-7]: vsbus.c

 Log Message:
 Pull up the following revisions(s) (requested by abs in ticket #817):
 	sys/arch/vax/vsa/vsbus.c:	revision 1.61

 Fix VAX46 and VAX48 vsbus attach config. Addresses PR port-vax/49935.


 To generate a diff of this commit:
 cvs rdiff -u -r1.60 -r1.60.14.1 src/sys/arch/vax/vsa/vsbus.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Soren Jacobsen" <snj@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/49935 CVS commit: [netbsd-6] src/sys/arch/vax/vsa
Date: Fri, 19 Jun 2015 17:23:12 +0000

 Module Name:	src
 Committed By:	snj
 Date:		Fri Jun 19 17:23:12 UTC 2015

 Modified Files:
 	src/sys/arch/vax/vsa [netbsd-6]: vsbus.c

 Log Message:
 Pull up following revision(s) (requested by abs in ticket #1303):
 	sys/arch/vax/vsa/vsbus.c: revision 1.61
 Add missing break - from Felix Deichmann in PR port-vax/49935


 To generate a diff of this commit:
 cvs rdiff -u -r1.59 -r1.59.14.1 src/sys/arch/vax/vsa/vsbus.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search