NetBSD Problem Report #50196

From www@NetBSD.org  Thu Sep  3 08:10:29 2015
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 89DABA5B2E
	for <gnats-bugs@gnats.NetBSD.org>; Thu,  3 Sep 2015 08:10:29 +0000 (UTC)
Message-Id: <20150903081028.A6AFBA654F@mollari.NetBSD.org>
Date: Thu,  3 Sep 2015 08:10:28 +0000 (UTC)
From: henning.petersen@t-online.de
Reply-To: henning.petersen@t-online.de
To: gnats-bugs@NetBSD.org
Subject: Assigment twice in delete_invite.
X-Send-Pr-Version: www-1.0

>Number:         50196
>Category:       bin
>Synopsis:       Assigment twice in delete_invite.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Sep 03 08:15:00 +0000 2015
>Closed-Date:    Thu Sep 03 08:21:04 +0000 2015
>Last-Modified:  Thu Sep 03 08:21:04 +0000 2015
>Originator:     Henning Petersen
>Release:        -current
>Organization:
>Environment:
>Description:
Table is assigned twice in delete_invite.
>How-To-Repeat:

>Fix:
diff -u -p -r1.10 table.c
--- libexec/talkd/table.c	16 Mar 2009 01:13:38 -0000	1.10
+++ libexec/talkd/table.c	30 Aug 2015 11:50:34 -0000
@@ -199,7 +199,6 @@ delete_invite(uint32_t id_num)
 {
 	TABLE_ENTRY *ptr;

-	ptr = table;
 	if (debug)
 		syslog(LOG_DEBUG, "delete_invite(%"PRIu32")", id_num);
 	for (ptr = table; ptr != NIL; ptr = ptr->next) {

>Release-Note:

>Audit-Trail:
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/50196 CVS commit: src/libexec/talkd
Date: Thu, 3 Sep 2015 08:16:36 +0000

 Module Name:	src
 Committed By:	dholland
 Date:		Thu Sep  3 08:16:36 UTC 2015

 Modified Files:
 	src/libexec/talkd: table.c

 Log Message:
 Remove dead assignment; from Henning Petersen in PR 50196.


 To generate a diff of this commit:
 cvs rdiff -u -r1.10 -r1.11 src/libexec/talkd/table.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Thu, 03 Sep 2015 08:21:04 +0000
State-Changed-Why:
fixed, thanks


>Unformatted:

Home	PR Database Search