NetBSD Problem Report #50301

From www@NetBSD.org  Mon Oct  5 06:35:03 2015
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 8FF6EA64EF
	for <gnats-bugs@gnats.NetBSD.org>; Mon,  5 Oct 2015 06:35:03 +0000 (UTC)
Message-Id: <20151005063502.7CB2EA6555@mollari.NetBSD.org>
Date: Mon,  5 Oct 2015 06:35:02 +0000 (UTC)
From: joachim.kuebart@gmail.com
Reply-To: joachim.kuebart@gmail.com
To: gnats-bugs@NetBSD.org
Subject: Build release broken on platforms without spawn.h
X-Send-Pr-Version: www-1.0

>Number:         50301
>Category:       bin
>Synopsis:       Build release broken on platforms without spawn.h
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    bin-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Oct 05 06:40:00 +0000 2015
>Closed-Date:    Wed Jul 21 04:33:17 +0000 2021
>Last-Modified:  Wed Jul 21 04:33:17 +0000 2021
>Originator:     Joachim Kuebart
>Release:        NetBSD-7
>Organization:
>Environment:
NetBSD yacht 5.99.23 NetBSD 5.99.23 (YACHT) #0: Mon Jan 18 19:22:39 CEST 2010  joki@yacht:/usr/obj/amd64/usr/src/sys/arch/amd64/compile/YACHT amd64

>Description:
Building release (specifically, building tools for usr.bin/xinstall) is currently broken on platforms without spawn.h, such as previous versions of NetBSD like the one listed.

>How-To-Repeat:
cd /usr/src && build.sh tools

>Fix:
Apply the following to usr.bin/xinstall/Makefile to assume avoid relying on spawn.h while building tools:

Index: Makefile
===================================================================
RCS file: /pub/NetBSD-CVS/src/usr.bin/xinstall/Makefile,v
retrieving revision 1.25
diff -p -U8 -r1.25 Makefile
--- Makefile	17 Jun 2015 15:34:08 -0000	1.25
+++ Makefile	5 Oct 2015 06:31:58 -0000
@@ -7,19 +7,19 @@ PROG=	xinstall
 SRCS=	xinstall.c getid.c metachar.c
 MAN=	install.1

 .PATH:		${NETBSDSRCDIR}/usr.bin/make
 CPPFLAGS+=	-I${NETBSDSRCDIR}/usr.bin/make

 .PATH:		${NETBSDSRCDIR}/usr.sbin/mtree
 CPPFLAGS+=	-I${NETBSDSRCDIR}/usr.sbin/mtree
-CPPFLAGS+=	-DHAVE_POSIX_SPAWN

 .if (${HOSTPROG:U} == "")
+CPPFLAGS+=	-DHAVE_POSIX_SPAWN
 DPADD+= ${LIBUTIL}
 LDADD+= -lutil
 .endif

 COPTS.xinstall.c += -Wno-format-nonliteral


 PROGNAME=install

>Release-Note:

>Audit-Trail:
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/50301 CVS commit: src/usr.bin/xinstall
Date: Sat, 10 Oct 2015 22:54:03 +0000

 Module Name:	src
 Committed By:	dholland
 Date:		Sat Oct 10 22:54:03 UTC 2015

 Modified Files:
 	src/usr.bin/xinstall: Makefile

 Log Message:
 Don't assume HAVE_POSIX_SPAWN when building a host prog. From Joachim
 Kuebart in PR 50301. needs pullup-7


 To generate a diff of this commit:
 cvs rdiff -u -r1.25 -r1.26 src/usr.bin/xinstall/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Wed, 21 Jul 2021 04:33:17 +0000
State-Changed-Why:
I fixed it in 2015, and pullup-7 is no longer relevant


>Unformatted:

Home	PR Database Search