NetBSD Problem Report #50376

From www@NetBSD.org  Wed Oct 28 19:52:47 2015
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 44ACAA5674
	for <gnats-bugs@gnats.NetBSD.org>; Wed, 28 Oct 2015 19:52:47 +0000 (UTC)
Message-Id: <20151028195246.4C9F9A64EF@mollari.NetBSD.org>
Date: Wed, 28 Oct 2015 19:52:46 +0000 (UTC)
From: schaecsn@gmx.net
Reply-To: schaecsn@gmx.net
To: gnats-bugs@NetBSD.org
Subject: /usr/pkg/bin hardcoded in several patches
X-Send-Pr-Version: www-1.0

>Number:         50376
>Category:       pkg
>Synopsis:       /usr/pkg/bin hardcoded in several patches
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Oct 28 19:55:00 +0000 2015
>Last-Modified:  Wed Oct 28 21:40:00 +0000 2015
>Originator:     Stefan Schaeckeler
>Release:        NetBSD-7.0 pkgsrc-201503
>Organization:
>Environment:
NetBSD t60p 7.0 NetBSD 7.0 (GENERIC) #0: Sat Sep 26 20:21:41 PDT 2015  root@t60p:/usr/obj/sys/arch/i386/compile/GENERIC i386
>Description:
My packages reside not under /usr/pkg/ but /usr/local/. Unfortunately, several patches hardcode paths to /usr/pkg making the builds fail

I was running into this particular problem with sysutils/strace (patch-av /usr/pkg/bin/perl -w).


There are probably many more such issues:

:/usr/pkgsrc# find . -name patch* -exec grep "/usr/pkg/bin" \{} /dev/null \; | wc
      24     105    2376

:/usr/pkgsrc# find . -name patch* -exec grep "/usr/pkg/sbin" \{} /dev/null \; | wc
       8      27     799

>How-To-Repeat:

>Fix:

>Audit-Trail:
From: Thomas Klausner <wiz@NetBSD.org>
To: NetBSD bugtracking <gnats-bugs@NetBSD.org>
Cc: 
Subject: Re: pkg/50376: /usr/pkg/bin hardcoded in several patches
Date: Wed, 28 Oct 2015 22:30:07 +0100

 On Wed, Oct 28, 2015 at 07:55:00PM +0000, schaecsn@gmx.net wrote:
 > >Number:         50376
 > >Category:       pkg
 > >Synopsis:       /usr/pkg/bin hardcoded in several patches

 To make this more explicit, here's my result for /usr/pkg/bin and
 /usr/pkg/lib ignoring patch comment lines and line removals.

 benchmarks/randread/patches/patch-Makefile:+LDFLAGS?=-L/usr/pkg/lib
 comms/asterisk/patches/patch-contrib_scripts_vmail.cgi:+#!/usr/pkg/bin/perl
 databases/mongodb/patches/patch-SConstruct:+    env.Append( LIBPATH=[ "/usr/pkg/lib" ] )
 databases/mongodb/patches/patch-SConstruct:+    env.Append( LIBPATH=[ "/usr/pkg/lib" ] )
 devel/SDL2/patches/patch-configure:+                EXTRA_LDFLAGS="$EXTRA_LDFLAGS -L/usr/pkg/lib -lbcm_host -ldl"
 devel/SDL2/patches/patch-configure:+                EXTRA_LDFLAGS="$EXTRA_LDFLAGS -Wl,-R/usr/pkg/lib -L/usr/pkg/lib -lbcm_host -ldl"
 games/monsterz/patches/patch-ab:+#!/usr/pkg/bin/python2.5
 graphics/blender/patches/patch-build__files_scons_config_netbsd6-config.py:+PLATFORM_LINKFLAGS = ['-pthread', '-lexecinfo', '-Wl,-R/usr/pkg/lib',  '-Wl,-R/usr/X11R7/lib']
 lang/ocaml/patches/patch-configure:+    /usr/pkg/lib          \
 mail/spamassassin/patches/patch-sa-update:+#!/usr/pkg/bin/perl -w -T
 misc/brs/patches/patch-ab:+.BR /usr/pkg/libdata/brs .
 misc/brs/patches/patch-ab:+/usr/pkg/libdata/brs/bible.data
 misc/brs/patches/patch-ab:+/usr/pkg/libdata/brs/bible.data.conc
 misc/openoffice3/patches/patch-by:+#!/usr/pkg/bin/perl
 net/icsi-finger/patches/patch-ah:+#define BinDir /usr/pkg/bin
 net/tightvnc/patches/patch-ab:+#define DefaultUserPath		/usr/bin:/bin:/usr/pkg/bin:$(BINDIR):/usr/local/bin
 net/tightvnc/patches/patch-ab:+#define DefaultSystemPath	/usr/bin:/bin:/usr/sbin:/sbin:/usr/pkg/bin:/usr/pkg/sbin:$(BINDIR):/usr/local/bin:/usr/local/sbin
 net/vnc/patches/patch-ab:+#define DefaultUserPath		/usr/bin:/bin:/usr/pkg/bin:$(BINDIR):/usr/local/bin
 net/vnc/patches/patch-ab:+#define DefaultSystemPath	/usr/bin:/bin:/usr/sbin:/sbin:/usr/pkg/bin:/usr/pkg/sbin:$(BINDIR):/usr/local/bin:/usr/local/sbin
 print/gutenprint-lib/patches/patch-aa:+    "/usr/pkg/bin/lpstat -v | awk '/^device for /i {sub(\":\", \"\", $3); print $3}'",
 sysutils/strace/patches/patch-av:+#!/usr/pkg/bin/perl -w
 sysutils/system-tools-backends/patches/patch-ag:+#!/usr/pkg/bin/perl
 sysutils/xe-guest-utilities/patches/patch-xe-update-guest-attrs:+export PATH=/usr/sbin:/usr/bin:/sbin:/bin:/usr/pkg/sbin:/usr/pkg/bin
 sysutils/xentools3/patches/patch-dm:+#!/usr/pkg/bin/python2.4
 www/ap-ruby/patches/patch-aa:+#!/usr/pkg/bin/ruby
 www/nspluginwrapper/patches/patch-aa:+	"/usr/pkg/lib/seamonkey/plugins",
 www/screws/patches/patch-ae:+	if [ "${INCORE_LUA}" = "1" ]; then echo "-L /usr/pkg/lib ${COMPILER_RPATH_FLAG}/usr/pkg/lib -llua -lm " > .opts ; \
 x11/kdelibs3/patches/patch-bd:+	    << "/usr/pkg/lib/"
 x11/kdelibs4/patches/patch-ac:+	    << "/usr/pkg/lib/"
 x11/tk-Tix/patches/patch-aa:+	dirs="/usr/unsupported/lib /usr/local/lib /usr/X386/lib /usr/X11R7/lib /usr/X11R6/lib /usr/X11R5/lib /usr/lib/X11R5 /usr/lib/X11R4 /usr/openwin/lib /usr/X11/lib /usr/sww/X11/lib /usr/pkg/lib"
 x11/tk-Tix/patches/patch-ac:+	dirs="/usr/unsupported/lib /usr/local/lib /usr/X386/lib /usr/X11R7/lib /usr/X11R6/lib /usr/X11R5/lib /usr/lib/X11R5 /usr/lib/X11R4 /usr/openwin/lib /usr/X11/lib /usr/sww/X11/lib /usr/pkg/lib"
 x11/xmove/patches/patch-aa:+ATOM_MAPPING_LIBRARY_PATH=\"/usr/pkg/lib\"

  Thomas

Home	PR Database Search