NetBSD Problem Report #50391

From www@NetBSD.org  Mon Nov  2 04:46:34 2015
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 3BED8A5858
	for <gnats-bugs@gnats.NetBSD.org>; Mon,  2 Nov 2015 04:46:34 +0000 (UTC)
Message-Id: <20151102044632.EC69CA6558@mollari.NetBSD.org>
Date: Mon,  2 Nov 2015 04:46:32 +0000 (UTC)
From: schaecsn@gmx.net
Reply-To: schaecsn@gmx.net
To: gnats-bugs@NetBSD.org
Subject: x11/XaoS does not build
X-Send-Pr-Version: www-1.0

>Number:         50391
>Category:       pkg
>Synopsis:       x11/XaoS does not build
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    bsiegert
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Nov 02 04:50:00 +0000 2015
>Closed-Date:    Tue Dec 29 13:43:08 +0000 2015
>Last-Modified:  Tue Dec 29 13:45:00 +0000 2015
>Originator:     Stefan Schaeckeler
>Release:        pkgsrc 2015Q3
>Organization:
>Environment:
NetBSD t60p 7.0 NetBSD 7.0 (GENERIC) #0: Sat Sep 26 20:21:41 PDT 2015  root@t60p:/usr/obj/sys/arch/i386/compile/GENERIC i386
>Description:
x11/XaoS does not build for me on NetBSD 7.0/i386. Apparently prototype does not match definition for some functions:

gcc -O2 -march=prescott -pipe -I/usr/local/include -I/usr/include -I/usr/X11R7/include  -I/usr/X11R7/include -I/usr/local/include -fomit-frame-pointer -DSFFE_USING -DSFFE_CMPLX_GSL -I/tmp/pkgsrc/x11/XaoS/work/xaos-3.6/src/include -I/usr/local/include -I/usr/include -I/usr/X11R7/include  -c -o zoom.o zoom.c
zoom.c:156:18: error: conflicting types for 'fillline_8'
 #define fillline fillline_8
                  ^
zoomd.c:283:20: note: in expansion of macro 'fillline'
 static INLINE void fillline(int line)
                    ^
zoom.c:144:13: note: previous declaration of 'fillline_8' was here
 static void fillline_8(int line) REGISTERS(0);
             ^
zoom.c:163:18: error: conflicting types for 'fillline_32'
 #define fillline fillline_32
                  ^
zoomd.c:283:20: note: in expansion of macro 'fillline'
 static INLINE void fillline(int line)
                    ^
zoom.c:147:13: note: previous declaration of 'fillline_32' was here
 static void fillline_32(int line) REGISTERS(0);
             ^
zoom.c:170:18: error: conflicting types for 'fillline_24'
 #define fillline fillline_24
                  ^
zoomd.c:283:20: note: in expansion of macro 'fillline'
 static INLINE void fillline(int line)
                    ^
zoom.c:146:13: note: previous declaration of 'fillline_24' was here
 static void fillline_24(int line) REGISTERS(0);
             ^
zoom.c:177:18: error: conflicting types for 'fillline_16'
 #define fillline fillline_16
                  ^
zoomd.c:283:20: note: in expansion of macro 'fillline'
 static INLINE void fillline(int line)
                    ^
zoom.c:145:13: note: previous declaration of 'fillline_16' was here
 static void fillline_16(int line) REGISTERS(0);
             ^
zoom.c:937:1: error: conflicting types for 'moveoldpoints'
 moveoldpoints(void /*@unused@ */ *data1,
 ^
zoom.c:142:1: note: previous declaration of 'moveoldpoints' was here
 moveoldpoints(void *data1, struct taskinfo *task, int r1, int r2)
 ^
<builtin>: recipe for target 'zoom.o' failed
gmake[2]: *** [zoom.o] Error 1
gmake[2]: *** Waiting for unfinished jobs....

>How-To-Repeat:

>Fix:
$NetBSD$

--- src/engine/zoom.c.orig	2015-11-01 20:40:43.000000000 -0800
+++ src/engine/zoom.c	2015-11-01 20:41:31.000000000 -0800
@@ -138,13 +138,11 @@
 #endif

 #ifndef USE_i386ASM
-static void
-moveoldpoints(void *data1, struct taskinfo *task, int r1, int r2)
-REGISTERS(0);
-static void fillline_8(int line) REGISTERS(0);
-static void fillline_16(int line) REGISTERS(0);
-static void fillline_24(int line) REGISTERS(0);
-static void fillline_32(int line) REGISTERS(0);
+static void moveoldpoints(void *data1, struct taskinfo *task, int r1, int r2);
+static INLINE void fillline_8(int line);
+static INLINE void fillline_16(int line);
+static INLINE void fillline_24(int line);
+static INLINE void fillline_32(int line);
 #endif

 /*first of all inline driver section */

>Release-Note:

>Audit-Trail:
From: Benny Siegert <bsiegert@gmail.com>
To: gnats-bugs@netbsd.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/50391: x11/XaoS does not build
Date: Mon, 28 Dec 2015 22:24:07 +0100

 > x11/XaoS does not build for me on NetBSD 7.0/i386. Apparently prototype does not match definition for some functions:

 I cannot reproduce this failure. Also, the bulk builds of XaoS have
 been green everywhere
 (http://bulktracker.appspot.com/pkgresults/x11/XaoS). Is it a local
 problem?

From: schaecsn <schaecsn@gmx.net>
To: gnats-bugs@NetBSD.org
Cc: pkg-manager@netbsd.org,gnats-admin@netbsd.org,pkgsrc-bugs@netbsd.org
Subject: Re: pkg/50391: x11/XaoS does not build
Date: Mon, 28 Dec 2015 13:56:08 -0800 (PST)

 >  > x11/XaoS does not build for me on NetBSD 7.0/i386. Apparently prototype does not match definition for some functions:
 >  
 >  I cannot reproduce this failure.

 I still see it. Just to clarify: you tried it on i386 (opposed to x86_64)?


 > Also, the bulk builds of XaoS have been green everywhere
 > (http://bulktracker.appspot.com/pkgresults/x11/XaoS).

 Only NetBSD 6.0 is tested on i386 which comes possibly with an older version of the c compiler.


 > Is it a local problem?

 Nothing is impossible :)

  Stefan

From: Benny Siegert <bsiegert@gmail.com>
To: schaecsn@gmx.net
Cc: gnats-bugs@netbsd.org, pkg-manager@netbsd.org, gnats-admin@netbsd.org, 
	pkgsrc-bugs@netbsd.org
Subject: Re: pkg/50391: x11/XaoS does not build
Date: Tue, 29 Dec 2015 14:11:37 +0100

 On Mon, Dec 28, 2015 at 10:56 PM, schaecsn <schaecsn@gmx.net> wrote:
 >
 >>  > x11/XaoS does not build for me on NetBSD 7.0/i386. Apparently prototype does not match definition for some functions:
 >>
 >>  I cannot reproduce this failure.
 >
 > I still see it. Just to clarify: you tried it on i386 (opposed to x86_64)?

 Yes, that was it. On -7/i386, I see the exact same symptoms. Looking.

 -- 
 The first essential in chemistry is that you should perform practical
 work and conduct experiments, for he who performs not practical work
 nor makes experiments will never attain the least degree of mastery.
         -- Abu Musa Jabir ibn Hayyan (721-815)

Responsible-Changed-From-To: pkg-manager->bsiegert
Responsible-Changed-By: bsiegert@NetBSD.org
Responsible-Changed-When: Tue, 29 Dec 2015 13:43:08 +0000
Responsible-Changed-Why:


State-Changed-From-To: open->closed
State-Changed-By: bsiegert@NetBSD.org
State-Changed-When: Tue, 29 Dec 2015 13:43:08 +0000
State-Changed-Why:
Committed, thanks!


From: "Benny Siegert" <bsiegert@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/50391 CVS commit: pkgsrc/x11/XaoS
Date: Tue, 29 Dec 2015 13:41:58 +0000

 Module Name:	pkgsrc
 Committed By:	bsiegert
 Date:		Tue Dec 29 13:41:58 UTC 2015

 Modified Files:
 	pkgsrc/x11/XaoS: Makefile distinfo
 Added Files:
 	pkgsrc/x11/XaoS/patches: patch-src_engine_zoom.c

 Log Message:
 Fix build on NetBSD-7/i386. From Stefan Schaeckeler in PR pkg/50391.


 To generate a diff of this commit:
 cvs rdiff -u -r1.37 -r1.38 pkgsrc/x11/XaoS/Makefile
 cvs rdiff -u -r1.17 -r1.18 pkgsrc/x11/XaoS/distinfo
 cvs rdiff -u -r0 -r1.1 pkgsrc/x11/XaoS/patches/patch-src_engine_zoom.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search