NetBSD Problem Report #50408

From www@NetBSD.org  Thu Nov  5 18:37:40 2015
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 9F7E7A6554
	for <gnats-bugs@gnats.NetBSD.org>; Thu,  5 Nov 2015 18:37:40 +0000 (UTC)
Message-Id: <20151105183739.6D8AAA6558@mollari.NetBSD.org>
Date: Thu,  5 Nov 2015 18:37:39 +0000 (UTC)
From: pfg@FreeBSD.org
Reply-To: pfg@FreeBSD.org
To: gnats-bugs@NetBSD.org
Subject: tirpc should use poll() instead of select()
X-Send-Pr-Version: www-1.0

>Number:         50408
>Category:       lib
>Synopsis:       tirpc should use poll() instead of select()
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    christos
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Thu Nov 05 18:40:00 +0000 2015
>Closed-Date:    Sat Aug 07 03:18:44 +0000 2021
>Last-Modified:  Sat Aug 07 03:18:44 +0000 2021
>Originator:     Pedro Giffuni
>Release:        current
>Organization:
>Environment:
N/A
>Description:
Just an idea that came for the linux tirpc project (derived indirectly from NetBSD's RPC)


Use poll() instead of select() in svc_run()

TI-RPC is using select() in svc_run(), while glibc and Solaris
are using poll(). This has two drawbacks: poll() is much more efficient
then select(), and with select() we are limited to 1024 open filehandles.
And applications replacing svc_run on Linux don't work, since they
expect svc_pollfd and svc_max_pollfd.
____

>How-To-Repeat:
poll(2) should be faster than select().
>Fix:
http://git.linux-nfs.org/?p=steved/libtirpc.git;a=commit;h=b2c9430f46c4ac848957fb8adaac176a3f6ac03f

Unfortunately the linux change replaces __svc_clean_idle() in svc_vc.c
with a dummy. __svc_clean_idle() was introduced by NetBSD and is used
in rpcbind.

>Release-Note:

>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/50408 CVS commit: src/lib/libc/rpc
Date: Sat, 7 Nov 2015 18:09:20 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Sat Nov  7 23:09:20 UTC 2015

 Modified Files:
 	src/lib/libc/rpc: rpc_internal.h svc_fdset.c svc_run.c svc_vc.c

 Log Message:
 PR/50408: Pedro Giffuni: Provide a way for rpc to use poll(2) instead of
 select(2), and the linux svc_pollfd and svc_maxpollfd members. Our select(2)
 implementation does not suffer from the FD_SETSIZE limitation so this is
 not turned on by default.


 To generate a diff of this commit:
 cvs rdiff -u -r1.7 -r1.8 src/lib/libc/rpc/rpc_internal.h
 cvs rdiff -u -r1.8 -r1.9 src/lib/libc/rpc/svc_fdset.c
 cvs rdiff -u -r1.24 -r1.25 src/lib/libc/rpc/svc_run.c
 cvs rdiff -u -r1.32 -r1.33 src/lib/libc/rpc/svc_vc.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

Responsible-Changed-From-To: lib-bug-people->christos
Responsible-Changed-By: maya@NetBSD.org
Responsible-Changed-When: Sun, 18 Aug 2019 05:13:59 +0000
Responsible-Changed-Why:
Hi christos, are there remaining issues/changes here? thanks!


State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sat, 07 Aug 2021 03:18:44 +0000
State-Changed-Why:
fixed by christos in 2015


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: gnats-precook-prs,v 1.4 2018/12/21 14:20:20 maya Exp $
$NetBSD: gnats_config.sh,v 1.9 2014/08/02 14:16:04 spz Exp $
Copyright © 1994-2017 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.