NetBSD Problem Report #50514

From www@NetBSD.org  Thu Dec 10 22:02:52 2015
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.NetBSD.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 6C1A0A6655
	for <gnats-bugs@gnats.NetBSD.org>; Thu, 10 Dec 2015 22:02:52 +0000 (UTC)
Message-Id: <20151210220251.5196CA6660@mollari.NetBSD.org>
Date: Thu, 10 Dec 2015 22:02:51 +0000 (UTC)
From: dcb314@hotmail.com
Reply-To: dcb314@hotmail.com
To: gnats-bugs@NetBSD.org
Subject: src/sys/arch/acorn32/podulebus/esc.c:1447: missing break ?
X-Send-Pr-Version: www-1.0

>Number:         50514
>Category:       port-acorn32
>Synopsis:       src/sys/arch/acorn32/podulebus/esc.c:1447: missing break ?
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    port-acorn32-maintainer
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Dec 10 22:05:00 +0000 2015
>Closed-Date:    Sun Dec 13 20:26:05 +0000 2015
>Last-Modified:  Sun Dec 13 20:26:05 +0000 2015
>Originator:     David Binderman
>Release:        cvs dated 20151210
>Organization:
>Environment:
>Description:
[src/sys/arch/acorn32/podulebus/esc.c:1447] -> [src/sys/arch/acorn32/podulebus/esc.c:1449]: (warning) Variable 'state' is reassigned a value before the old one has been used. 'break;' missing?

Source code is

            case 0x00:  /* COMMAND COMPLETE */
                nexus->state = ESC_NS_DONE;
            case 0x04:  /* DISCONNECT */
                nexus->state = ESC_NS_DISCONNECTING;
                break;

>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/50514 CVS commit: src/sys/arch/acorn32/podulebus
Date: Sun, 13 Dec 2015 14:53:02 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Sun Dec 13 19:53:02 UTC 2015

 Modified Files:
 	src/sys/arch/acorn32/podulebus: esc.c

 Log Message:
 PR/50514: David Binderman: Add missing break


 To generate a diff of this commit:
 cvs rdiff -u -r1.29 -r1.30 src/sys/arch/acorn32/podulebus/esc.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Sun, 13 Dec 2015 20:26:05 +0000
State-Changed-Why:
christos fixed it.


>Unformatted:

Home	PR Database Search