NetBSD Problem Report #50556

From www@NetBSD.org  Tue Dec 15 04:01:44 2015
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.NetBSD.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 759FB7ABE6
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 15 Dec 2015 04:01:44 +0000 (UTC)
Message-Id: <20151215040143.2FA277ACC6@mollari.NetBSD.org>
Date: Tue, 15 Dec 2015 04:01:43 +0000 (UTC)
From: coypu@sdf.org
Reply-To: coypu@sdf.org
To: gnats-bugs@NetBSD.org
Subject: comms/lirc fails with gcc 5.3.1 (Linux)
X-Send-Pr-Version: www-1.0

>Number:         50556
>Category:       pkg
>Synopsis:       comms/lirc fails with gcc 5.3.1 (Linux)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    maya
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Dec 15 04:05:00 +0000 2015
>Closed-Date:    Mon Aug 22 01:30:59 +0000 2016
>Last-Modified:  Mon Aug 22 01:30:59 +0000 2016
>Originator:     coypu
>Release:        pkgsrc-current, not NetBSD
>Organization:
>Environment:
Linux localhost.localdomain 4.4.0-0.rc4.git4.1.fc24.x86_64 #1 SMP Fri Dec 11 17:39:06 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux
>Description:
can't build comms/lirc under Linux
>How-To-Repeat:
attempt to build comms/lirc, fails because of use of 'inline fun(...' instead of 'static inline fun(...'.

this is a GNU C89 extension not supported by default on newer GCC.

produces the following errors:

libhw_module.a(receive.o): In function `receive_decode':
receive.c:(.text+0x1b0f): undefined reference to `sync_rec_buffer'
receive.c:(.text+0x1b73): undefined reference to `get_header'
receive.c:(.text+0x1b8d): undefined reference to `get_repeat'
receive.c:(.text+0x1d16): undefined reference to `sync_rec_buffer'
receive.c:(.text+0x1d39): undefined reference to `get_header'
>Fix:
adding CFLAGS+=-fgnu89-inline to Makefile

alternatively: replacing all instances of '^inline' with 'static inline'.

>Release-Note:

>Audit-Trail:
From: coypu@SDF.ORG
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/50556
Date: Tue, 15 Dec 2015 05:08:04 +0000

 This already fixed in ver 0.9.3 upstream, so updating to that is another
 solution. Having some trouble making the update myself.

From: coypu@SDF.ORG
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/50556
Date: Tue, 15 Dec 2015 06:45:12 +0000

 This patch makes it possible to build comms/lirc 0.9.3

 --- Makefile.old	2015-12-15 08:37:20.071151277 +0200
 +++ Makefile	2015-12-15 08:40:25.913827924 +0200
 @@ -1,7 +1,7 @@
  # $NetBSD: Makefile,v 1.4 2015/01/01 09:35:17 dholland Exp $
  #

 -DISTNAME=	lirc-0.9.0
 +DISTNAME=	lirc-0.9.3
  PKGREVISION=	2
  CATEGORIES=	comms
  MASTER_SITES=	${MASTER_SITE_SOURCEFORGE:=lirc/}
 @@ -12,10 +12,12 @@
  COMMENT=	Linux Infrared Remote Control
  LICENSE=	gnu-gpl-v2

 +USE_LANGUAGES=c c++
  USE_LIBTOOL=		yes
  USE_TOOLS+=		gmake

  GNU_CONFIGURE=		yes
 +
  CONFIGURE_ARGS+=	--with-syslog --with-driver=userspace
  CONFIGURE_ARGS+=	--sysconfdir=${PKG_SYSCONFDIR}

 @@ -42,6 +44,7 @@
  .endif

  .include "options.mk"
 -
 +PYTHON_VERSIONS_ACCEPTED=33 34 35
 +.include "../../lang/python/versioned_dependencies.mk"
  .include "../../devel/libusb/buildlink3.mk"
  .include "../../mk/bsd.pkg.mk"

Responsible-Changed-From-To: pkg-manager->cheusov
Responsible-Changed-By: wiz@NetBSD.org
Responsible-Changed-When: Tue, 15 Dec 2015 09:43:05 +0000
Responsible-Changed-Why:
Over to maintainer.


From: coypu@SDF.ORG
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/50556
Date: Mon, 28 Mar 2016 08:22:39 +0000

 I am unable to test the functionality of this program, but it is
 blocking building other packages (I was building VLC), and maintainer
 did not respond.

 Please consider taking this patch anyway.

 Thanks.

From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/50556 CVS commit: pkgsrc/comms/lirc
Date: Mon, 2 May 2016 02:32:14 +0000

 Module Name:	pkgsrc
 Committed By:	dholland
 Date:		Mon May  2 02:32:14 UTC 2016

 Modified Files:
 	pkgsrc/comms/lirc: distinfo
 Added Files:
 	pkgsrc/comms/lirc/patches: patch-daemons_config__file.c
 	    patch-daemons_config__file.h patch-daemons_receive.c
 	    patch-daemons_receive.h patch-daemons_transmit.c
 	    patch-daemons_transmit.h

 Log Message:
 PR 50556: comms/lirc doesn't build
 Add patches to work around gcc inline mess.

 Note: this package should be updated and the PR contains an update, but
 I don't want to do that when I can't compile it (whereas simple mechanical
 patches are much less likely to go astray...)


 To generate a diff of this commit:
 cvs rdiff -u -r1.2 -r1.3 pkgsrc/comms/lirc/distinfo
 cvs rdiff -u -r0 -r1.1 pkgsrc/comms/lirc/patches/patch-daemons_config__file.c \
     pkgsrc/comms/lirc/patches/patch-daemons_config__file.h \
     pkgsrc/comms/lirc/patches/patch-daemons_receive.c \
     pkgsrc/comms/lirc/patches/patch-daemons_receive.h \
     pkgsrc/comms/lirc/patches/patch-daemons_transmit.c \
     pkgsrc/comms/lirc/patches/patch-daemons_transmit.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: PR/50556 CVS commit: pkgsrc/comms/lirc
Date: Mon, 2 May 2016 02:55:56 +0000

 On Mon, May 02, 2016 at 02:35:00AM +0000, David A. Holland wrote:
  >  Note: this package should be updated and the PR contains an update, but
  >  I don't want to do that when I can't compile it (whereas simple mechanical
  >  patches are much less likely to go astray...)

 Update: I have fairly small patches that let me compile it on NetBSD.
 I have no idea though if the results are likely to work (as opposed to
 issuing reams of invalid ioctls with made-up ioctl numbers, as
 defining one's own ioctl numbers and assuming they'll work is common
 practice in the Linux world) and I have no way to test it.

 Do we have anyone who can test this package?

 -- 
 David A. Holland
 dholland@netbsd.org

Responsible-Changed-From-To: cheusov->maya
Responsible-Changed-By: bsiegert@NetBSD.org
Responsible-Changed-When: Sat, 20 Aug 2016 09:52:20 +0000
Responsible-Changed-Why:
Maya, you can commit your own patch now :)


From: coypu@SDF.ORG
To: gnats-bugs@NetBSD.org
Cc: bsiegert@NetBSD.org
Subject: Re: pkg/50556 (comms/lirc fails with gcc 5.3.1 (Linux))
Date: Mon, 22 Aug 2016 01:20:20 +0000

 On Sat, Aug 20, 2016 at 09:52:21AM +0000, bsiegert@NetBSD.org wrote:
 > Synopsis: comms/lirc fails with gcc 5.3.1 (Linux)
 > 
 > Responsible-Changed-From-To: cheusov->maya
 > Responsible-Changed-By: bsiegert@NetBSD.org
 > Responsible-Changed-When: Sat, 20 Aug 2016 09:52:20 +0000
 > Responsible-Changed-Why:
 > Maya, you can commit your own patch now :)
 > 
 > 

 dholland applied a build fix, but not the update.
 we thought it might be safer because neither of us can test it.
 still needed, as it came up as a dependency to other packages.

State-Changed-From-To: open->closed
State-Changed-By: maya@NetBSD.org
State-Changed-When: Mon, 22 Aug 2016 01:30:59 +0000
State-Changed-Why:
Most likely fixed (builds with the GCC version),
updating would be nicer, but we cannot test this change.


>Unformatted:

Home	PR Database Search