NetBSD Problem Report #50558

From www@NetBSD.org  Tue Dec 15 05:46:59 2015
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.NetBSD.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 3505C7A0EB
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 15 Dec 2015 05:46:59 +0000 (UTC)
Message-Id: <20151215054658.139017ACC6@mollari.NetBSD.org>
Date: Tue, 15 Dec 2015 05:46:58 +0000 (UTC)
From: coypu@sdf.org
Reply-To: coypu@sdf.org
To: gnats-bugs@NetBSD.org
Subject: multimedia/liboggz patches break Linux
X-Send-Pr-Version: www-1.0

>Number:         50558
>Category:       pkg
>Synopsis:       multimedia/liboggz patches break Linux
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    maya
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Dec 15 05:50:00 +0000 2015
>Closed-Date:    Sun Oct 30 09:43:23 +0000 2016
>Last-Modified:  Sun Oct 30 09:45:01 +0000 2016
>Originator:     coypu
>Release:        pkgsrc-current, not NetBSD
>Organization:
>Environment:
Linux localhost.localdomain 4.4.0-0.rc4.git4.1.fc24.x86_64 #1 SMP Fri Dec 11 17:39:06 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux
>Description:
package builds without patches on Linux but the patches for free/open break it.
>How-To-Repeat:
build multimedia/liboggz on Linux
>Fix:
do not apply patches for Linux

>Release-Note:

>Audit-Trail:
From: Thomas Klausner <wiz@NetBSD.org>
To: NetBSD bugtracking <gnats-bugs@NetBSD.org>
Cc: 
Subject: Re: pkg/50558: multimedia/liboggz patches break Linux
Date: Tue, 15 Dec 2015 08:47:25 +0100

 On Tue, Dec 15, 2015 at 05:50:00AM +0000, coypu@sdf.org wrote:
 > package builds without patches on Linux but the patches for free/open break it.

 Please provide more details on how it breaks.

 Thanks,
  Thomas

From: coypu@SDF.ORG
To: gnats-bugs@NetBSD.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/50558: multimedia/liboggz patches break Linux
Date: Tue, 15 Dec 2015 17:45:12 +0000

 Apologies, I didn't notice the error before, it can be improved not to
 fail most likely.

 In both patches it complains of the line 'struct timezone tzone', with
 the error "storage size of 'tzone' isn't known".


From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/50558: multimedia/liboggz patches break Linux
Date: Fri, 18 Dec 2015 10:30:57 +0000

 On Tue, Dec 15, 2015 at 05:50:01PM +0000, coypu@SDF.ORG wrote:
  >  Apologies, I didn't notice the error before, it can be improved not to
  >  fail most likely.
  >  
  >  In both patches it complains of the line 'struct timezone tzone', with
  >  the error "storage size of 'tzone' isn't known".

 That patch is completely wrong anyway - it declares an uninitialized
 timezone structure and uses it to adjust the date.

 ...even if struct timezone weren't deprecated.

 -- 
 David A. Holland
 dholland@netbsd.org

Responsible-Changed-From-To: pkg-manager->rodent
Responsible-Changed-By: bsiegert@NetBSD.org
Responsible-Changed-When: Mon, 28 Dec 2015 16:21:28 +0000
Responsible-Changed-Why:
Over to maintainer (and author of the patches in question).


Responsible-Changed-From-To: rodent->maya
Responsible-Changed-By: maya@NetBSD.org
Responsible-Changed-When: Sun, 30 Oct 2016 09:43:23 +0000
Responsible-Changed-Why:
take


State-Changed-From-To: open->closed
State-Changed-By: maya@NetBSD.org
State-Changed-When: Sun, 30 Oct 2016 09:43:23 +0000
State-Changed-Why:
I removed the patches. build was fixed in r1.2 of patches too.


From: "Maya Rashish" <maya@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/50558 CVS commit: pkgsrc/multimedia/liboggz
Date: Sun, 30 Oct 2016 09:41:58 +0000

 Module Name:	pkgsrc
 Committed By:	maya
 Date:		Sun Oct 30 09:41:58 UTC 2016

 Modified Files:
 	pkgsrc/multimedia/liboggz: distinfo
 Removed Files:
 	pkgsrc/multimedia/liboggz/patches: patch-src_tools_oggz-chop_httpdate.c
 	    patch-src_tools_oggz-chop_httpdate__test.c

 Log Message:
 liboggz: remove all patches

 these patches were intended to fix build on Open/Free-BSD and are simply wrong
 and broke the build on linux before and now on OS X.

 "it declares an uninitialized timezone structure and uses it to adjust the date.
  ...even if struct timezone weren't deprecated."

 PR pkg/50558, report on pkgsrc-users by Emre Eryilmaz


 To generate a diff of this commit:
 cvs rdiff -u -r1.4 -r1.5 pkgsrc/multimedia/liboggz/distinfo
 cvs rdiff -u -r1.2 -r0 \
     pkgsrc/multimedia/liboggz/patches/patch-src_tools_oggz-chop_httpdate.c \
     pkgsrc/multimedia/liboggz/patches/patch-src_tools_oggz-chop_httpdate__test.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search