NetBSD Problem Report #50679

From www@NetBSD.org  Tue Jan 19 14:58:36 2016
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.NetBSD.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 3590F7ABDD
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 19 Jan 2016 14:58:36 +0000 (UTC)
Message-Id: <20160119145835.3D6187ACA5@mollari.NetBSD.org>
Date: Tue, 19 Jan 2016 14:58:35 +0000 (UTC)
From: triaxx@triaxx.org
Reply-To: triaxx@triaxx.org
To: gnats-bugs@NetBSD.org
Subject: databases/openldap-server fails with bdb option
X-Send-Pr-Version: www-1.0

>Number:         50679
>Category:       pkg
>Synopsis:       databases/openldap-server fails with bdb option
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Jan 19 15:00:01 +0000 2016
>Closed-Date:    Fri Sep 27 07:16:08 +0000 2019
>Last-Modified:  Fri Sep 27 07:16:08 +0000 2019
>Originator:     Frédéric Fauberteau
>Release:        pkgsrc-2015Q4
>Organization:
>Environment:
NetBSD trashware 7.0_STABLE NetBSD 7.0_STABLE (TRASHWARE) #1: Sat Dec  5 19:26:52 CET 2015  triaxx@hydralisk:/home/triaxx/dev/nbsd/netbsd-7/usr/objs/sys/arch/amd64/compile/TRASHWARE amd64
>Description:
/usr/pkgsrc/databases/openldap-server/work/.destdir/usr/pkg/share/examples/openldap/DB_CONFIG: no such file or directory when the option 'bdb' is disabled.
>How-To-Repeat:
PKG_OPTIONS.openldap-server += -bdb
>Fix:
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/databases/openldap-server/Makefile,v
retrieving revision 1.46
diff -u -u -r1.46 Makefile
--- Makefile  2 Dec 2015 17:04:57 -0000 1.46
+++ Makefile  19 Jan 2016 14:01:46 -0000
@@ -50,8 +50,6 @@

 CNFS_PERMS=    slapd.conf

-DB_CONFIG=   DB_CONFIG
-
 RCD_SCRIPTS=   slapd

 FILES_SUBST+=    OPENLDAP_ETCDIR=${OPENLDAP_ETCDIR}
@@ -68,8 +66,6 @@

 .include "../../databases/openldap/Makefile.common"

-CONF_FILES_PERMS+= ${EGDIR}/DB_CONFIG ${OPENLDAP_VARDIR}/openldap-data/DB_CONFIG ${OPENLDAP_FILEPERMS}
-
 .include "../../mk/bsd.prefs.mk"
 .if ${OPSYS} == "Linux" || ${OPSYS} == "SunOS"
 .include "../../devel/libuuid/buildlink3.mk"
Index: PLIST
===================================================================
RCS file: /cvsroot/pkgsrc/databases/openldap-server/PLIST,v
retrieving revision 1.12
diff -u -u -r1.12 PLIST
--- PLIST 11 Mar 2014 14:05:00 -0000  1.12
+++ PLIST 19 Jan 2016 14:01:46 -0000
@@ -10,7 +10,7 @@
 sbin/slappasswd
 sbin/slapschema
 sbin/slaptest
-share/examples/openldap/DB_CONFIG
+${PLIST.bdb}share/examples/openldap/DB_CONFIG
 share/examples/openldap/schema/README
 share/examples/openldap/schema/collective.ldif
 share/examples/openldap/schema/collective.schema
Index: options.mk
===================================================================
RCS file: /cvsroot/pkgsrc/databases/openldap-server/options.mk,v
retrieving revision 1.19
diff -u -u -r1.19 options.mk
--- options.mk  7 Sep 2015 12:02:06 -0000 1.19
+++ options.mk  19 Jan 2016 14:01:46 -0000
@@ -8,7 +8,7 @@

 .include "../../mk/bsd.options.mk"

-PLIST_VARS+= slapi
+PLIST_VARS+= bdb slapi

 ### 
 ### Whether to build with the Berkeley DB based slapd backends.
@@ -20,7 +20,10 @@
 BDB_ACCEPTED=    db4 db5 
 CONFIGURE_ARGS+= --enable-bdb --enable-hdb
 TEST_TARGET=   test
+DB_CONFIG=   DB_CONFIG
+CONF_FILES_PERMS+= ${EGDIR}/DB_CONFIG ${OPENLDAP_VARDIR}/openldap-data/DB_CONFIG ${OPENLDAP_FILEPERMS}
 .  include "../../mk/bdb.buildlink3.mk"
+PLIST.bdb=   yes
 .else
 CONFIGURE_ARGS+= --disable-bdb --disable-hdb
 .endif

>Release-Note:

>Audit-Trail:
From: triaxx <triaxx@triaxx.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/50679: databases/openldap-server fails WITHOUT bdb option
Date: Thu, 21 Jan 2016 08:57:14 +0100

 Sorry, the package fails when bdb option is *disabled* due to DB_CONFIG 
 file not installed (but in PLIST). The patch fix the problem.

 Le 19/01/2016 16:00, triaxx@triaxx.org a écrit :
 >> Number:         50679
 >> Category:       pkg
 >> Synopsis:       databases/openldap-server fails with bdb option
 >> Confidential:   no
 >> Severity:       serious
 >> Priority:       medium
 >> Responsible:    pkg-manager
 >> State:          open
 >> Class:          sw-bug
 >> Submitter-Id:   net
 >> Arrival-Date:   Tue Jan 19 15:00:01 +0000 2016
 >> Originator:     Fr�d�ric Fauberteau
 >> Release:        pkgsrc-2015Q4
 >> Organization:
 >> Environment:
 > NetBSD trashware 7.0_STABLE NetBSD 7.0_STABLE (TRASHWARE) #1: Sat Dec
 > 5 19:26:52 CET 2015
 > triaxx@hydralisk:/home/triaxx/dev/nbsd/netbsd-7/usr/objs/sys/arch/amd64/compile/TRASHWARE
 > amd64
 >> Description:
 > /usr/pkgsrc/databases/openldap-server/work/.destdir/usr/pkg/share/examples/openldap/DB_CONFIG:
 > no such file or directory when the option 'bdb' is disabled.
 >> How-To-Repeat:
 > PKG_OPTIONS.openldap-server += -bdb
 >> Fix:
 > Index: Makefile
 > ===================================================================
 > RCS file: /cvsroot/pkgsrc/databases/openldap-server/Makefile,v
 > retrieving revision 1.46
 > diff -u -u -r1.46 Makefile
 > --- Makefile  2 Dec 2015 17:04:57 -0000 1.46
 > +++ Makefile  19 Jan 2016 14:01:46 -0000
 > @@ -50,8 +50,6 @@
 > 
 >  CNFS_PERMS=    slapd.conf
 > 
 > -DB_CONFIG=   DB_CONFIG
 > -
 >  RCD_SCRIPTS=   slapd
 > 
 >  FILES_SUBST+=    OPENLDAP_ETCDIR=${OPENLDAP_ETCDIR}
 > @@ -68,8 +66,6 @@
 > 
 >  .include "../../databases/openldap/Makefile.common"
 > 
 > -CONF_FILES_PERMS+= ${EGDIR}/DB_CONFIG
 > ${OPENLDAP_VARDIR}/openldap-data/DB_CONFIG ${OPENLDAP_FILEPERMS}
 > -
 >  .include "../../mk/bsd.prefs.mk"
 >  .if ${OPSYS} == "Linux" || ${OPSYS} == "SunOS"
 >  .include "../../devel/libuuid/buildlink3.mk"
 > Index: PLIST
 > ===================================================================
 > RCS file: /cvsroot/pkgsrc/databases/openldap-server/PLIST,v
 > retrieving revision 1.12
 > diff -u -u -r1.12 PLIST
 > --- PLIST 11 Mar 2014 14:05:00 -0000  1.12
 > +++ PLIST 19 Jan 2016 14:01:46 -0000
 > @@ -10,7 +10,7 @@
 >  sbin/slappasswd
 >  sbin/slapschema
 >  sbin/slaptest
 > -share/examples/openldap/DB_CONFIG
 > +${PLIST.bdb}share/examples/openldap/DB_CONFIG
 >  share/examples/openldap/schema/README
 >  share/examples/openldap/schema/collective.ldif
 >  share/examples/openldap/schema/collective.schema
 > Index: options.mk
 > ===================================================================
 > RCS file: /cvsroot/pkgsrc/databases/openldap-server/options.mk,v
 > retrieving revision 1.19
 > diff -u -u -r1.19 options.mk
 > --- options.mk  7 Sep 2015 12:02:06 -0000 1.19
 > +++ options.mk  19 Jan 2016 14:01:46 -0000
 > @@ -8,7 +8,7 @@
 > 
 >  .include "../../mk/bsd.options.mk"
 > 
 > -PLIST_VARS+= slapi
 > +PLIST_VARS+= bdb slapi
 > 
 >  ###
 >  ### Whether to build with the Berkeley DB based slapd backends.
 > @@ -20,7 +20,10 @@
 >  BDB_ACCEPTED=    db4 db5
 >  CONFIGURE_ARGS+= --enable-bdb --enable-hdb
 >  TEST_TARGET=   test
 > +DB_CONFIG=   DB_CONFIG
 > +CONF_FILES_PERMS+= ${EGDIR}/DB_CONFIG
 > ${OPENLDAP_VARDIR}/openldap-data/DB_CONFIG ${OPENLDAP_FILEPERMS}
 >  .  include "../../mk/bdb.buildlink3.mk"
 > +PLIST.bdb=   yes
 >  .else
 >  CONFIGURE_ARGS+= --disable-bdb --disable-hdb
 >  .endif

From: =?UTF-8?B?RnLDqWTDqXJpYyBGYXViZXJ0ZWF1?= <triaxx@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/50679 CVS commit: pkgsrc/databases/openldap-server
Date: Fri, 27 Sep 2019 07:14:02 +0000

 Module Name:	pkgsrc
 Committed By:	triaxx
 Date:		Fri Sep 27 07:14:02 UTC 2019

 Modified Files:
 	pkgsrc/databases/openldap-server: Makefile PLIST options.mk

 Log Message:
 openldap-server: fix PR pkg/50679

 pkgsrc changes:
 ---------------
 * Make the configuration file DB_CONFIG installed only if 'bdb' option is
   enabled


 To generate a diff of this commit:
 cvs rdiff -u -r1.52 -r1.53 pkgsrc/databases/openldap-server/Makefile
 cvs rdiff -u -r1.12 -r1.13 pkgsrc/databases/openldap-server/PLIST
 cvs rdiff -u -r1.20 -r1.21 pkgsrc/databases/openldap-server/options.mk

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: triaxx@NetBSD.org
State-Changed-When: Fri, 27 Sep 2019 07:16:08 +0000
State-Changed-Why:
Fix approved by adam@. Thanks!


>Unformatted:

Home	PR Database Search