NetBSD Problem Report #50687

From www@NetBSD.org  Thu Jan 21 17:41:01 2016
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.NetBSD.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 1361F7ABE7
	for <gnats-bugs@gnats.NetBSD.org>; Thu, 21 Jan 2016 17:41:01 +0000 (UTC)
Message-Id: <20160121174100.00BFF7ACA7@mollari.NetBSD.org>
Date: Thu, 21 Jan 2016 17:40:59 +0000 (UTC)
From: dcb314@hotmail.com
Reply-To: dcb314@hotmail.com
To: gnats-bugs@NetBSD.org
Subject: src/sys/arch/arm/at91/at91emac.c:792: possible bad bitmask ?
X-Send-Pr-Version: www-1.0

>Number:         50687
>Category:       port-arm
>Synopsis:       src/sys/arch/arm/at91/at91emac.c:792: possible bad bitmask ?
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    port-arm-maintainer
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Jan 21 17:45:00 +0000 2016
>Closed-Date:    Thu Nov 04 07:00:38 +0000 2021
>Last-Modified:  Thu Nov 04 07:20:01 +0000 2021
>Originator:     David Binderman
>Release:        cvs dated 20160121
>Organization:
>Environment:
>Description:
[src/sys/arch/arm/at91/at91emac.c:792] -> [src/sys/arch/arm/at91/at91emac.c:792]: (style) Same expression on both sides of '|'.

source code is

    cfg &= ~(ETH_CFG_MTI | ETH_CFG_UNI | ETH_CFG_CAF | ETH_CFG_UNI);

At a simple level, it might be suitable to remove the duplicate.

However, there are a bunch of other bitmask values that might be appropriate.

Bitmask values listed in file src/sys/arch/arm/at91/at91emacreg.h
>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: skrll@NetBSD.org
State-Changed-When: Thu, 04 Nov 2021 07:00:38 +0000
State-Changed-Why:
Duplicate bit field define removed.
Someone with hardware should test and report any problems.


From: "Nick Hudson" <skrll@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/50687 CVS commit: src/sys/arch/arm/at91
Date: Thu, 4 Nov 2021 06:57:51 +0000

 Module Name:	src
 Committed By:	skrll
 Date:		Thu Nov  4 06:57:51 UTC 2021

 Modified Files:
 	src/sys/arch/arm/at91: at91emac.c

 Log Message:
 Remove unnecessary duplicate bit define in mask

 PR port-arm/50687


 To generate a diff of this commit:
 cvs rdiff -u -r1.32 -r1.33 src/sys/arch/arm/at91/at91emac.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.46 2020/01/03 16:35:01 leot Exp $
$NetBSD: gnats_config.sh,v 1.9 2014/08/02 14:16:04 spz Exp $
Copyright © 1994-2020 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.