NetBSD Problem Report #50688

From www@NetBSD.org  Thu Jan 21 17:44:49 2016
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.NetBSD.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id D86137ABE0
	for <gnats-bugs@gnats.NetBSD.org>; Thu, 21 Jan 2016 17:44:48 +0000 (UTC)
Message-Id: <20160121174448.0686A7ACC8@mollari.NetBSD.org>
Date: Thu, 21 Jan 2016 17:44:48 +0000 (UTC)
From: dcb314@hotmail.com
Reply-To: dcb314@hotmail.com
To: gnats-bugs@NetBSD.org
Subject: src/sys/arch/hpcmips/dev/plumpower.c:119: possible bad bitmask ?
X-Send-Pr-Version: www-1.0

>Number:         50688
>Category:       port-hpcmips
>Synopsis:       src/sys/arch/hpcmips/dev/plumpower.c:119: possible bad bitmask ?
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    port-hpcmips-maintainer
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Jan 21 17:45:01 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160121
>Organization:
>Environment:
>Description:
[src/sys/arch/hpcmips/dev/plumpower.c:119] -> [src/sys/arch/hpcmips/dev/plumpower.c:119]: (style) Same expression on both sides of '|'.

Source code is

       plum_conf_write(regt, regh, PLUM_POWER_RESETC_REG,
        PLUM_POWER_RESETC_IO5CL1 |
        PLUM_POWER_RESETC_IO5CL1);

At a simple level, it might be suitable to remove the duplicate.

Or maybe there is a simple typo:

$ fgrep PLUM_POWER_RESETC_IO5CL src/sys/arch/hpcmips/dev/*.h
src/sys/arch/hpcmips/dev/plumpowerreg.h:#define PLUM_POWER_RESETC_IO5CL1	0x00000002
src/sys/arch/hpcmips/dev/plumpowerreg.h:#define PLUM_POWER_RESETC_IO5CL0	0x00000001
$ 


>How-To-Repeat:

>Fix:

Home	PR Database Search