NetBSD Problem Report #50735

From www@NetBSD.org  Mon Feb  1 16:30:52 2016
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.NetBSD.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 756807ABF0
	for <gnats-bugs@gnats.NetBSD.org>; Mon,  1 Feb 2016 16:30:52 +0000 (UTC)
Message-Id: <20160201163051.95DCC7ACC0@mollari.NetBSD.org>
Date: Mon,  1 Feb 2016 16:30:51 +0000 (UTC)
From: dcb314@hotmail.com
Reply-To: dcb314@hotmail.com
To: gnats-bugs@NetBSD.org
Subject: src/sys/arch/evbmips/gdium/machdep.c:224: leap before looking ?
X-Send-Pr-Version: www-1.0

>Number:         50735
>Category:       port-evbmips
>Synopsis:       src/sys/arch/evbmips/gdium/machdep.c:224: leap before looking ?
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    port-evbmips-maintainer
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Feb 01 16:35:00 +0000 2016
>Closed-Date:    Mon Feb 01 17:56:13 +0000 2016
>Last-Modified:  Mon Feb 01 17:56:13 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160131
>Organization:
>Environment:
>Description:

[src/sys/arch/evbmips/gdium/machdep.c:224]: (style) Array index 'i' is used before limits check.

   while ((eptrs[i] != 0) && (i < 128)) {

Something like 

   while ((i < 128) && (eptrs[i] != 0)) {

would be more usual.

>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/50735 CVS commit: src/sys/arch/evbmips/gdium
Date: Mon, 1 Feb 2016 12:37:39 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Mon Feb  1 17:37:39 UTC 2016

 Modified Files:
 	src/sys/arch/evbmips/gdium: machdep.c

 Log Message:
 PR/50735: David Binderman: Check bounds before dereferencing.


 To generate a diff of this commit:
 cvs rdiff -u -r1.17 -r1.18 src/sys/arch/evbmips/gdium/machdep.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Mon, 01 Feb 2016 17:56:13 +0000
State-Changed-Why:
Fixed by christos, thanks!


>Unformatted:

Home	PR Database Search