NetBSD Problem Report #50783

From www@NetBSD.org  Mon Feb  8 16:16:51 2016
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.NetBSD.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id EDE9D7A215
	for <gnats-bugs@gnats.NetBSD.org>; Mon,  8 Feb 2016 16:16:50 +0000 (UTC)
Message-Id: <20160208161650.1D0FB7ACB9@mollari.NetBSD.org>
Date: Mon,  8 Feb 2016 16:16:50 +0000 (UTC)
From: dcb314@hotmail.com
Reply-To: dcb314@hotmail.com
To: gnats-bugs@NetBSD.org
Subject: src/sys/arch/sgimips/dev/crmfb.c:1132: break in wrong place ?
X-Send-Pr-Version: www-1.0

>Number:         50783
>Category:       port-sgimips
>Synopsis:       src/sys/arch/sgimips/dev/crmfb.c:1132: break in wrong place ?
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    port-sgimips-maintainer
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Feb 08 16:20:00 +0000 2016
>Closed-Date:    Mon Feb 08 17:24:03 +0000 2016
>Last-Modified:  Sun Feb 14 19:15:01 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160208
>Organization:
>Environment:
>Description:
[src/sys/arch/sgimips/dev/crmfb.c:1132]: (style) Statements following return, break, continue, goto or throw will never be executed.

Source code is

        case 32:
            sc->sc_de_mode = DE_MODE_TLB_A | DE_MODE_BUFDEPTH_32 |
                DE_MODE_TYPE_RGBA | DE_MODE_PIXDEPTH_32;
            break;
            sc->sc_mte_mode = MTE_MODE_DST_ECC |
                (MTE_TLB_A << MTE_DST_TLB_SHIFT) |
                (MTE_TLB_A << MTE_SRC_TLB_SHIFT) |
                (MTE_DEPTH_32 << MTE_DEPTH_SHIFT);
            sc->sc_mte_x_shift = 2;
        default:

All the other cases set sc_de_mode, sc_mte_mode and
sc_mte_x_shift and then break.

Maybe this case should also.

>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/50783 CVS commit: src/sys/arch/sgimips/dev
Date: Mon, 8 Feb 2016 11:44:46 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Mon Feb  8 16:44:46 UTC 2016

 Modified Files:
 	src/sys/arch/sgimips/dev: crmfb.c

 Log Message:
 PR/50783: David Binderman: Indent switch properly, add missing break.


 To generate a diff of this commit:
 cvs rdiff -u -r1.41 -r1.42 src/sys/arch/sgimips/dev/crmfb.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Mon, 08 Feb 2016 17:24:03 +0000
State-Changed-Why:
Fixed by christos, thanks!


From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/50783 CVS commit: src/sys/arch/sgimips/dev
Date: Sun, 14 Feb 2016 19:11:20 +0000

 Module Name:	src
 Committed By:	dholland
 Date:		Sun Feb 14 19:11:20 UTC 2016

 Modified Files:
 	src/sys/arch/sgimips/dev: crmfb.c

 Log Message:
 Remove extra stray break missed by Christos when committing PR 50783.


 To generate a diff of this commit:
 cvs rdiff -u -r1.42 -r1.43 src/sys/arch/sgimips/dev/crmfb.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search