NetBSD Problem Report #50785

From www@NetBSD.org  Mon Feb  8 16:24:38 2016
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.NetBSD.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 9C8607ACA5
	for <gnats-bugs@gnats.NetBSD.org>; Mon,  8 Feb 2016 16:24:38 +0000 (UTC)
Message-Id: <20160208162437.BD4F57ACBC@mollari.NetBSD.org>
Date: Mon,  8 Feb 2016 16:24:37 +0000 (UTC)
From: dcb314@hotmail.com
Reply-To: dcb314@hotmail.com
To: gnats-bugs@NetBSD.org
Subject: src/sys/dev/pci/mpii.c:4992: dead code ?
X-Send-Pr-Version: www-1.0

>Number:         50785
>Category:       misc
>Synopsis:       src/sys/dev/pci/mpii.c:4992: dead code ?
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    misc-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Feb 08 16:25:00 +0000 2016
>Closed-Date:    Mon Feb 08 16:33:02 +0000 2016
>Last-Modified:  Mon Feb 08 16:33:02 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160208
>Organization:
>Environment:
>Description:
[src/sys/dev/pci/mpii.c:4992]: (style) Statements following return, break, continue, goto or throw will never be executed.

Source code is

    if (mpii_req_cfg_page(sc, addr, MPII_PG_POLL, &hdr, 1,
        vpg, pagelen) != 0) {
        rv = EINVAL;
        goto done;
        free(vpg, M_TEMP);
        return (EINVAL);
    }

Maybe better code

    if (mpii_req_cfg_page(sc, addr, MPII_PG_POLL, &hdr, 1,
        vpg, pagelen) != 0) {
        rv = EINVAL;
        free(vpg, M_TEMP);
        goto done;
    }

>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/50785 CVS commit: src/sys/dev/pci
Date: Mon, 8 Feb 2016 11:27:51 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Mon Feb  8 16:27:51 UTC 2016

 Modified Files:
 	src/sys/dev/pci: mpii.c

 Log Message:
 PR/50785: David Binderman: Remove dead code.


 To generate a diff of this commit:
 cvs rdiff -u -r1.6 -r1.7 src/sys/dev/pci/mpii.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Mon, 08 Feb 2016 16:33:02 +0000
State-Changed-Why:
Fixed by christos, thanks.
Are we up to 100 now?


>Unformatted:

Home	PR Database Search