NetBSD Problem Report #50854

From www@NetBSD.org  Fri Feb 26 17:18:47 2016
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.NetBSD.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 30C4F7A0F0
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 26 Feb 2016 17:18:47 +0000 (UTC)
Message-Id: <20160226171846.2A75D7ACDF@mollari.NetBSD.org>
Date: Fri, 26 Feb 2016 17:18:46 +0000 (UTC)
From: dcb314@hotmail.com
Reply-To: dcb314@hotmail.com
To: gnats-bugs@NetBSD.org
Subject: src/sys/arch/alpha/isa/isadma_bounce.c: 2 * redundant conditions
X-Send-Pr-Version: www-1.0

>Number:         50854
>Category:       port-alpha
>Synopsis:       src/sys/arch/alpha/isa/isadma_bounce.c: 2 * redundant conditions
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    port-alpha-maintainer
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Feb 26 17:20:00 +0000 2016
>Closed-Date:    Mon Feb 29 15:30:19 +0000 2016
>Last-Modified:  Mon Feb 29 15:30:19 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160226
>Organization:
>Environment:
>Description:
1.

[src/sys/arch/alpha/isa/isadma_bounce.c:216]: (style) Redundant condition: error!=0. 'error==0 || (error!=0 && (cookie.id_flags&1)==0)' is equivalent to 'error==0 || (cookie.id_flags&1)==0'

Source code is

    if (error == 0 ||
        (error != 0 && (cookie->id_flags & ID_MIGHT_NEED_BOUNCE) == 0))

2.

[src/sys/arch/alpha/isa/isadma_bounce.c:287]: (style) Redundant condition: error!=0. 'error==0 || (error!=0 && (cookie.id_flags&1)==0)' is equivalent to 'error==0 || (cookie.id_flags&1)==0'

Source code is

    if (error == 0 ||
        (error != 0 && (cookie->id_flags & ID_MIGHT_NEED_BOUNCE) == 0))

>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/50854 CVS commit: src/sys/arch/alpha/isa
Date: Mon, 29 Feb 2016 10:28:35 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Mon Feb 29 15:28:35 UTC 2016

 Modified Files:
 	src/sys/arch/alpha/isa: isadma_bounce.c

 Log Message:
 PR/50854: David Binderman: Remove redundant code.


 To generate a diff of this commit:
 cvs rdiff -u -r1.12 -r1.13 src/sys/arch/alpha/isa/isadma_bounce.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Mon, 29 Feb 2016 15:30:19 +0000
State-Changed-Why:
Fixed by christos, thanks!


>Unformatted:

Home	PR Database Search