NetBSD Problem Report #50868

From www@NetBSD.org  Mon Feb 29 17:30:38 2016
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id C21FE7ACA2
	for <gnats-bugs@gnats.NetBSD.org>; Mon, 29 Feb 2016 17:30:38 +0000 (UTC)
Message-Id: <20160229173037.F2F947ACD3@mollari.NetBSD.org>
Date: Mon, 29 Feb 2016 17:30:37 +0000 (UTC)
From: dcb314@hotmail.com
Reply-To: dcb314@hotmail.com
To: gnats-bugs@NetBSD.org
Subject: [src/sys/arch/atari/dev/ite.c:804]: (style) Boolean result is used in bitwise operation. 
X-Send-Pr-Version: www-1.0

>Number:         50868
>Category:       port-atari
>Synopsis:       [src/sys/arch/atari/dev/ite.c:804]: (style) Boolean result is used in bitwise operation.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    port-atari-maintainer
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Feb 29 17:35:00 +0000 2016
>Closed-Date:    Mon Feb 29 20:41:43 +0000 2016
>Last-Modified:  Mon Feb 29 20:41:43 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160229
>Organization:
>Environment:
>Description:

Source code is

        if (last_dead == key->mode & KBD_MODE_ACCMASK)

Maybe
        if (last_dead == (key->mode & KBD_MODE_ACCMASK))


>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/50868 CVS commit: src/sys/arch/atari/dev
Date: Mon, 29 Feb 2016 13:25:29 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Mon Feb 29 18:25:29 UTC 2016

 Modified Files:
 	src/sys/arch/atari/dev: ite.c

 Log Message:
 PR/50868: David Binderman: Fix operator precedence.


 To generate a diff of this commit:
 cvs rdiff -u -r1.76 -r1.77 src/sys/arch/atari/dev/ite.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Mon, 29 Feb 2016 20:41:43 +0000
State-Changed-Why:
Fixed by christos, thanks.


>Unformatted:

Home	PR Database Search