NetBSD Problem Report #50963

From www@NetBSD.org  Sun Mar 13 17:23:31 2016
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 4558F7ABF3
	for <gnats-bugs@gnats.NetBSD.org>; Sun, 13 Mar 2016 17:23:31 +0000 (UTC)
Message-Id: <20160313172330.312947ACC7@mollari.NetBSD.org>
Date: Sun, 13 Mar 2016 17:23:30 +0000 (UTC)
From: dcb314@hotmail.com
Reply-To: dcb314@hotmail.com
To: gnats-bugs@NetBSD.org
Subject: src/sys/arch/arm/nvidia/tegra_gpio.c: 4 * uninit data ?
X-Send-Pr-Version: www-1.0

>Number:         50963
>Category:       port-arm
>Synopsis:       src/sys/arch/arm/nvidia/tegra_gpio.c: 4 * uninit data ?
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    port-arm-maintainer
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Mar 13 17:25:00 +0000 2016
>Closed-Date:    Sun Mar 13 19:10:48 +0000 2016
>Last-Modified:  Sun Mar 13 19:10:48 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160313
>Organization:
>Environment:
>Description:
1.

[src/sys/arch/arm/nvidia/tegra_gpio.c:307]: (error) Uninitialized struct member: gbank.bank_dev
[src/sys/arch/arm/nvidia/tegra_gpio.c:307]: (error) Uninitialized struct member: gbank.bank_gc

Source code is

    gpin = kmem_alloc(sizeof(*gpin), KM_SLEEP);
    gpin->pin_bank = gbank;
    gpin->pin_no = pin;
    gpin->pin_flags = flags;
    gpin->pin_actlo = actlo;

Not sure it is going to make any difference, but it might
be safer better code to use 

    memset(gpin, 0, sizeof(*gpin));

2.

[src/sys/arch/arm/nvidia/tegra_gpio.c:402]: (error) Uninitialized struct member: bank.bank_dev
[src/sys/arch/arm/nvidia/tegra_gpio.c:402]: (error) Uninitialized struct member: bank.bank_gc

Duplicate.

>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/50963 CVS commit: src/sys/arch/arm/nvidia
Date: Sun, 13 Mar 2016 13:38:44 -0400

 Module Name:	src
 Committed By:	christos
 Date:		Sun Mar 13 17:38:44 UTC 2016

 Modified Files:
 	src/sys/arch/arm/nvidia: tegra_gpio.c

 Log Message:
 PR/50963: David Binderman: Use kmem_zalloc() so all members are initialized.


 To generate a diff of this commit:
 cvs rdiff -u -r1.6 -r1.7 src/sys/arch/arm/nvidia/tegra_gpio.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Sun, 13 Mar 2016 19:10:48 +0000
State-Changed-Why:
Fixed by christos, thanks.


>Unformatted:

Home	PR Database Search