NetBSD Problem Report #50964

From www@NetBSD.org  Sun Mar 13 17:35:56 2016
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 3600B7ABDB
	for <gnats-bugs@gnats.NetBSD.org>; Sun, 13 Mar 2016 17:35:56 +0000 (UTC)
Message-Id: <20160313173555.05E4A7ACC0@mollari.NetBSD.org>
Date: Sun, 13 Mar 2016 17:35:55 +0000 (UTC)
From: dcb314@hotmail.com
Reply-To: dcb314@hotmail.com
To: gnats-bugs@NetBSD.org
Subject: src/sys/arch/dreamcast/dev/gdrom.c: signed integer overflow ?
X-Send-Pr-Version: www-1.0

>Number:         50964
>Category:       port-dreamcast
>Synopsis:       src/sys/arch/dreamcast/dev/gdrom.c: signed integer overflow ?
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    port-dreamcast-maintainer
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Mar 13 17:40:00 +0000 2016
>Closed-Date:    Sun Mar 13 19:17:22 +0000 2016
>Last-Modified:  Sun Mar 13 19:17:22 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160313
>Organization:
>Environment:
>Description:

src/sys/arch/dreamcast/dev/gdrom.c:192]: (error) Signed integer overflow for expression '2690609152+156'.

Source code is

    cond = GDROM_COND;

but

#define GDROM_COND  GDROM(0x9c)
#define GDROM(o)    (*(volatile uint8_t *)(0xa05f7000 + (o)))

Maybe better code

#define GDROM(o)    (*(volatile uint8_t *)(0xa05f7000ULL + (o)))

>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/50964 CVS commit: src/sys/arch/dreamcast/dev
Date: Sun, 13 Mar 2016 13:59:20 -0400

 Module Name:	src
 Committed By:	christos
 Date:		Sun Mar 13 17:59:20 UTC 2016

 Modified Files:
 	src/sys/arch/dreamcast/dev: gdrom.c

 Log Message:
 PR/50964: David Binderman: Avoid signed overflow warning


 To generate a diff of this commit:
 cvs rdiff -u -r1.41 -r1.42 src/sys/arch/dreamcast/dev/gdrom.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Sun, 13 Mar 2016 19:17:22 +0000
State-Changed-Why:
Fixed by christos, thanks.


>Unformatted:

Home	PR Database Search