NetBSD Problem Report #51014

From www@NetBSD.org  Sat Mar 26 15:24:21 2016
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 004AD7A2AE
	for <gnats-bugs@gnats.NetBSD.org>; Sat, 26 Mar 2016 15:24:20 +0000 (UTC)
Message-Id: <20160326152419.CC0397ABFD@mollari.NetBSD.org>
Date: Sat, 26 Mar 2016 15:24:19 +0000 (UTC)
From: dcb314@hotmail.com
Reply-To: dcb314@hotmail.com
To: gnats-bugs@NetBSD.org
Subject: src/sys/arch/newsmips/dev/scsi_1185.c: possible read uninit data ?
X-Send-Pr-Version: www-1.0

>Number:         51014
>Category:       port-newsmips
>Synopsis:       src/sys/arch/newsmips/dev/scsi_1185.c: possible read uninit data ?
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    port-newsmips-maintainer
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Mar 26 15:25:00 +0000 2016
>Closed-Date:    Sat Mar 26 17:15:20 +0000 2016
>Last-Modified:  Sat Mar 26 17:15:20 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160326
>Organization:
>Environment:
>Description:
src/sys/arch/newsmips/dev/scsi_1185.c:1742]: (error) Uninitialized variable: remain_cnt

Source code is

   sent_byte = scb->sc_ctrnscnt - remain_cnt;

but

    u_int remain_cnt;

It looks as if when this preprocessor condition

# if defined(__mips__) && defined(CPU_SINGLE)

is false, then remain_cnt can be uninitialised.

Suggest init remain_cnt at its declaration.
>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/51014 CVS commit: src/sys/arch/newsmips/dev
Date: Sat, 26 Mar 2016 17:14:38 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Sat Mar 26 17:14:38 UTC 2016

 Modified Files:
 	src/sys/arch/newsmips/dev: scsi_1185.c

 Log Message:
 David Binderman in PR port-newsmips/51014:
 Move initialization of remain_cnt up to the declaration.
 XXX the #ifdef here does not make much sense to me, but I know nothing
 about the hardware. I'd guess it could be removed or inverted and #error'd
 instead.


 To generate a diff of this commit:
 cvs rdiff -u -r1.21 -r1.22 src/sys/arch/newsmips/dev/scsi_1185.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: martin@NetBSD.org
State-Changed-When: Sat, 26 Mar 2016 17:15:20 +0000
State-Changed-Why:
Fixed, thanks!


>Unformatted:

Home	PR Database Search