NetBSD Problem Report #51097

From www@NetBSD.org  Wed Apr 27 14:15:01 2016
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 7C6F27A2AD
	for <gnats-bugs@gnats.NetBSD.org>; Wed, 27 Apr 2016 14:15:01 +0000 (UTC)
Message-Id: <20160427141500.562917AA92@mollari.NetBSD.org>
Date: Wed, 27 Apr 2016 14:15:00 +0000 (UTC)
From: nonakap@gmail.com
Reply-To: nonakap@gmail.com
To: gnats-bugs@NetBSD.org
Subject: pkgsrc/sysutils/grub2: build failed
X-Send-Pr-Version: www-1.0

>Number:         51097
>Category:       pkg
>Synopsis:       pkgsrc/sysutils/grub2: build failed
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    nonaka
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Apr 27 14:20:00 +0000 2016
>Closed-Date:    Tue May 03 15:02:14 +0000 2016
>Last-Modified:  Tue May 03 15:02:14 +0000 2016
>Originator:     NONAKA Kimihiro
>Release:        HEAD (20160427)
>Organization:
>Environment:
NetBSD koharu.myhome.nonakap.org 7.99.28 NetBSD 7.99.28 (KOHARU) #3613: Wed Apr 27 21:37:49 JST 2016  nonaka@koharu.myhome.nonakap.org:/home/storage/snapshot/NetBSD/HEAD-20160424/obj.NetBSD-amd64/amd64/sys/arch/amd64/compile/KOHARU amd64
>Description:
net/bootp.c: In function ‘grub_net_configure_by_dhcp_ack’:
net/bootp.c:255:30: error: passing argument 2 of ‘parse_dhcp_vendor’ discards ‘c
onst’ qualifier from pointer target type [-Werror=discarded-array-qualifiers]
     parse_dhcp_vendor (name, &bp->vendor, size - OFFSET_OF (vendor, bp), &mask)
;
                              ^
net/bootp.c:55:1: note: expected ‘void *’ but argument is of type ‘const grub_ui
nt8_t (*)[] {aka const unsigned char (*)[]}’
 parse_dhcp_vendor (const char *name, void *vend, int limit, int *mask)
 ^

>How-To-Repeat:
1. cd /usr/pkgsrc/sysutils/grub2
2. make

>Fix:
Apply the following patch.

--- grub-core/net/bootp.c.orig	2012-06-22 05:15:48.000000000 +0900
+++ grub-core/net/bootp.c	2016-04-27 22:57:02.990825737 +0900
@@ -52,9 +52,9 @@ set_env_limn_ro (const char *intername, 
 }

 static void
-parse_dhcp_vendor (const char *name, void *vend, int limit, int *mask)
+parse_dhcp_vendor (const char *name, const void *vend, int limit, int *mask)
 {
-  grub_uint8_t *ptr, *ptr0;
+  const grub_uint8_t *ptr, *ptr0;

   ptr = ptr0 = vend;


>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->gsutre
Responsible-Changed-By: wiz@NetBSD.org
Responsible-Changed-When: Wed, 27 Apr 2016 15:16:13 +0000
Responsible-Changed-Why:
Over to maintainer


From: =?UTF-8?Q?Gr=c3=a9goire_Sutre?= <gregoire.sutre@labri.fr>
To: gnats-bugs@NetBSD.org, gsutre@NetBSD.org, pkg-manager@netbsd.org,
 pkgsrc-bugs@netbsd.org, gnats-admin@netbsd.org, wiz@NetBSD.org,
 nonakap@gmail.com
Cc: 
Subject: Re: pkg/51097 (pkgsrc/sysutils/grub2: build failed)
Date: Tue, 3 May 2016 12:28:10 +0200

 Hi,

 I no longer wish to maintain this package.  Please transfer
 maintainership to, say, pkgsrc-users@NetBSD.org.

 Regarding this PR, the patch provided by nonaka works fine.

 Best,

 Grégoire

Responsible-Changed-From-To: gsutre->nonaka
Responsible-Changed-By: wiz@NetBSD.org
Responsible-Changed-When: Tue, 03 May 2016 10:41:23 +0000
Responsible-Changed-Why:
Reviewed by gsutre, please commit. Thanks!


From: "NONAKA Kimihiro" <nonaka@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/51097 CVS commit: pkgsrc/sysutils/grub2
Date: Tue, 3 May 2016 14:53:14 +0000

 Module Name:	pkgsrc
 Committed By:	nonaka
 Date:		Tue May  3 14:53:14 UTC 2016

 Modified Files:
 	pkgsrc/sysutils/grub2: distinfo
 Added Files:
 	pkgsrc/sysutils/grub2/patches: patch-grub-core_net_bootp.c

 Log Message:
 PR/51097: Fix build failure on NetBSD-current.

 reviewed by gsutre@.


 To generate a diff of this commit:
 cvs rdiff -u -r1.5 -r1.6 pkgsrc/sysutils/grub2/distinfo
 cvs rdiff -u -r0 -r1.1 \
     pkgsrc/sysutils/grub2/patches/patch-grub-core_net_bootp.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: nonaka@NetBSD.org
State-Changed-When: Tue, 03 May 2016 15:02:14 +0000
State-Changed-Why:
comitted.


>Unformatted:

Home	PR Database Search