NetBSD Problem Report #51185

From www@NetBSD.org  Sun May 29 17:23:41 2016
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 997067A471
	for <gnats-bugs@gnats.NetBSD.org>; Sun, 29 May 2016 17:23:41 +0000 (UTC)
Message-Id: <20160529172340.BA0187AABA@mollari.NetBSD.org>
Date: Sun, 29 May 2016 17:23:40 +0000 (UTC)
From: dcb314@hotmail.com
Reply-To: dcb314@hotmail.com
To: gnats-bugs@NetBSD.org
Subject: src/sys/arch/amiga/stand/binpatch/binpatch.c:406]: (style) Redundant condition
X-Send-Pr-Version: www-1.0

>Number:         51185
>Category:       port-amiga
>Synopsis:       src/sys/arch/amiga/stand/binpatch/binpatch.c:406]: (style) Redundant condition
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    port-amiga-maintainer
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun May 29 17:25:01 +0000 2016
>Closed-Date:    Mon May 30 03:04:45 +0000 2016
>Last-Modified:  Mon May 30 03:04:45 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160529
>Organization:
>Environment:
>Description:

src/sys/arch/amiga/stand/binpatch/binpatch.c:406]: (style) Redundant condition: If 'EXPR == ' '', the comparison 'EXPR != 0' is always true.

Source code is

   for (cn=ce + 1;((*cn==' ')&&(*cn!='\0'));cn++)


Suggest code rework.
>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/51185 CVS commit: src/sys/arch/amiga/stand/binpatch
Date: Mon, 30 May 2016 02:36:37 +0000

 Module Name:	src
 Committed By:	dholland
 Date:		Mon May 30 02:36:37 UTC 2016

 Modified Files:
 	src/sys/arch/amiga/stand/binpatch: binpatch.c

 Log Message:
 PR 51185 David Binderman: simplify redundant conditional


 To generate a diff of this commit:
 cvs rdiff -u -r1.11 -r1.12 src/sys/arch/amiga/stand/binpatch/binpatch.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Mon, 30 May 2016 03:04:45 +0000
State-Changed-Why:
fixed, thanks


>Unformatted:

Home	PR Database Search