NetBSD Problem Report #51360

From www@NetBSD.org  Tue Jul 26 14:27:44 2016
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 79F587A219
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 26 Jul 2016 14:27:44 +0000 (UTC)
Message-Id: <20160726142743.87A507A282@mollari.NetBSD.org>
Date: Tue, 26 Jul 2016 14:27:43 +0000 (UTC)
From: nonakap@gmail.com
Reply-To: nonakap@gmail.com
To: gnats-bugs@NetBSD.org
Subject: devel/pkgconf: should handle ${X11BASE}/lib/pkgconfig
X-Send-Pr-Version: www-1.0

>Number:         51360
>Category:       pkg
>Synopsis:       devel/pkgconf: should handle ${X11BASE}/lib/pkgconfig
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Jul 26 14:30:00 +0000 2016
>Closed-Date:    Thu Aug 04 14:36:18 +0000 2016
>Last-Modified:  Thu Aug 04 14:36:18 +0000 2016
>Originator:     Kimihiro Nonaka
>Release:        HEAD (20160725)
>Organization:
>Environment:
NetBSD koharu.myhome.nonakap.org 7.99.34 NetBSD 7.99.34 (KOHARU) #3904: Tue Jul 26 01:56:03 JST 2016  nonaka@koharu.myhome.nonakap.org:/home/storage/snapshot/NetBSD/HEAD-20160725/obj.NetBSD-amd64/amd64/sys/arch/amd64/compile/KOHARU amd64
>Description:
nonaka@koharu$ pkg-config x11 --cflags
Package x11 was not found in the pkg-config search path.
Perhaps you should add the directory containing `x11.pc'
to the PKG_CONFIG_PATH environment variable
Package 'x11', required by 'world', not found
nonaka@koharu$ locate x11.pc
/usr/X11R7/lib/pkgconfig/x11.pc
/usr/pkg/share/x11-links/lib/pkgconfig/x11.pc
/usr/xsrc/external/mit/libX11/dist/x11.pc.in

>How-To-Repeat:
/etc/mk.conf
-----
X11_TYPE= native
-----

# cd /usr/pkgsrc/devel/pkgconf && make install
# pkg-config x11 --cflags
>Fix:
Please add ${X11BASE}/lib/pkgconfig to --with-pkg-config-dir like devel/pkg-config.

>Release-Note:

>Audit-Trail:
From: Thomas Klausner <wiz@NetBSD.org>
To: NetBSD bugtracking <gnats-bugs@NetBSD.org>
Cc: 
Subject: Re: pkg/51360: devel/pkgconf: should handle ${X11BASE}/lib/pkgconfig
Date: Tue, 26 Jul 2016 22:04:19 +0200

 On Tue, Jul 26, 2016 at 02:30:00PM +0000, nonakap@gmail.com wrote:
 > >Fix:
 > Please add ${X11BASE}/lib/pkgconfig to --with-pkg-config-dir like devel/pkg-config.

 Fine with me.

 Can you do it like pkg-config/Makefile does it, or should someone else
 do it?
  Thomas

From: Kimihiro Nonaka <nonakap@gmail.com>
To: "gnats-bugs@netbsd.org" <gnats-bugs@netbsd.org>
Cc: pkg-manager@netbsd.org, "gnats-admin@netbsd.org" <gnats-admin@netbsd.org>, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/51360: devel/pkgconf: should handle ${X11BASE}/lib/pkgconfig
Date: Wed, 27 Jul 2016 11:27:49 +0900

 2016-07-27 5:05 GMT+09:00 Thomas Klausner <wiz@netbsd.org>:

 > The following reply was made to PR pkg/51360; it has been noted by GNATS.
 >
 > From: Thomas Klausner <wiz@NetBSD.org>
 > To: NetBSD bugtracking <gnats-bugs@NetBSD.org>
 > Cc:
 > Subject: Re: pkg/51360: devel/pkgconf: should handle ${X11BASE}/lib/pkgconfig
 > Date: Tue, 26 Jul 2016 22:04:19 +0200
 >
 >  On Tue, Jul 26, 2016 at 02:30:00PM +0000, nonakap@gmail.com wrote:
 >  > >Fix:
 >  > Please add ${X11BASE}/lib/pkgconfig to --with-pkg-config-dir like devel/pkg-config.
 >
 >  Fine with me.
 >
 >  Can you do it like pkg-config/Makefile does it, or should someone else
 >  do it?

 Index: Makefile
 ===================================================================
 RCS file: /cvsroot/pkgsrc/devel/pkgconf/Makefile,v
 retrieving revision 1.6
 diff -u -p -r1.6 Makefile
 --- Makefile    4 Feb 2016 11:50:54 -0000    1.6
 +++ Makefile    27 Jul 2016 02:27:09 -0000
 @@ -15,12 +15,23 @@ CONFLICTS+=    pkg-config-[0-9]*

  WRKSRC=        ${WRKDIR}/pkgconf-1.0

 +.include "../../mk/bsd.prefs.mk"
 +
  GNU_CONFIGURE=    yes
 -CONFIGURE_ARGS=
 --with-pkg-config-dir=${PREFIX}/lib/pkgconfig:${PREFIX}/share/pkgconfig:/usr/lib/pkgconfig
 \
 -        --with-system-libdir=/usr/lib \
 +CONFIGURE_ARGS=    --with-system-libdir=/usr/lib \
          --with-system-includedir=/usr/include
  MAKE_FLAGS+=    MANDIR=${PREFIX}/${PKGMANDIR}/man1

 +PKGCONFIG_PATHS=    ${PREFIX}/lib/pkgconfig
 +PKGCONFIG_PATHS+=    ${PREFIX}/share/pkgconfig
 +PKGCONFIG_PATHS+=    /usr/lib/pkgconfig
 +
 +.if ${LOCALBASE} != ${X11BASE}
 +PKGCONFIG_PATHS+=    ${X11BASE}/lib/pkgconfig
 +.endif
 +
 +CONFIGURE_ARGS+=    --with-pkg-config-dir='${PKGCONFIG_PATHS:ts::Q}'
 +
  post-install:
      ${LN} -s ${PREFIX}/bin/pkgconf ${DESTDIR}${PREFIX}/bin/pkg-config


 Regards,
 -- 
 Kimihiro Nonaka

From: Thomas Klausner <wiz@NetBSD.org>
To: NetBSD bugtracking <gnats-bugs@NetBSD.org>
Cc: 
Subject: Re: pkg/51360: devel/pkgconf: should handle ${X11BASE}/lib/pkgconfig
Date: Fri, 29 Jul 2016 12:51:43 +0200

 On Wed, Jul 27, 2016 at 11:27:49AM +0900, Kimihiro Nonaka wrote:
 > Index: Makefile
 > ===================================================================
 > RCS file: /cvsroot/pkgsrc/devel/pkgconf/Makefile,v
 > retrieving revision 1.6
 > diff -u -p -r1.6 Makefile
 > --- Makefile    4 Feb 2016 11:50:54 -0000    1.6
 > +++ Makefile    27 Jul 2016 02:27:09 -0000
 > @@ -15,12 +15,23 @@ CONFLICTS+=    pkg-config-[0-9]*
 > 
 >  WRKSRC=        ${WRKDIR}/pkgconf-1.0
 > 
 > +.include "../../mk/bsd.prefs.mk"
 > +
 >  GNU_CONFIGURE=    yes
 > -CONFIGURE_ARGS=
 > --with-pkg-config-dir=${PREFIX}/lib/pkgconfig:${PREFIX}/share/pkgconfig:/usr/lib/pkgconfig
 > \
 > -        --with-system-libdir=/usr/lib \
 > +CONFIGURE_ARGS=    --with-system-libdir=/usr/lib \
 >          --with-system-includedir=/usr/include
 >  MAKE_FLAGS+=    MANDIR=${PREFIX}/${PKGMANDIR}/man1
 > 
 > +PKGCONFIG_PATHS=    ${PREFIX}/lib/pkgconfig
 > +PKGCONFIG_PATHS+=    ${PREFIX}/share/pkgconfig
 > +PKGCONFIG_PATHS+=    /usr/lib/pkgconfig
 > +
 > +.if ${LOCALBASE} != ${X11BASE}
 > +PKGCONFIG_PATHS+=    ${X11BASE}/lib/pkgconfig
 > +.endif
 > +
 > +CONFIGURE_ARGS+=    --with-pkg-config-dir='${PKGCONFIG_PATHS:ts::Q}'
 > +
 >  post-install:
 >      ${LN} -s ${PREFIX}/bin/pkgconf ${DESTDIR}${PREFIX}/bin/pkg-config

 Looks good. If it works, bump PKGREVISION and commit!

 Thanks,
  Thomas

From: "NONAKA Kimihiro" <nonaka@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/51360 CVS commit: pkgsrc/devel/pkgconf
Date: Thu, 4 Aug 2016 14:30:08 +0000

 Module Name:	pkgsrc
 Committed By:	nonaka
 Date:		Thu Aug  4 14:30:08 UTC 2016

 Modified Files:
 	pkgsrc/devel/pkgconf: Makefile

 Log Message:
 PR/51360: handle ${X11BASE}/lib/pkgconfig.

 bump PKGREVISION.


 To generate a diff of this commit:
 cvs rdiff -u -r1.7 -r1.8 pkgsrc/devel/pkgconf/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: nonaka@NetBSD.org
State-Changed-When: Thu, 04 Aug 2016 14:36:18 +0000
State-Changed-Why:
patch applied.


>Unformatted:

Home	PR Database Search