NetBSD Problem Report #51410

From www@NetBSD.org  Fri Aug 12 01:32:38 2016
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id CCB197A25E
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 12 Aug 2016 01:32:37 +0000 (UTC)
Message-Id: <20160812013236.9F6B77A2B6@mollari.NetBSD.org>
Date: Fri, 12 Aug 2016 01:32:36 +0000 (UTC)
From: coypu@sdf.org
Reply-To: coypu@sdf.org
To: gnats-bugs@NetBSD.org
Subject: running lfs_cleanerd after mount panics on sasert
X-Send-Pr-Version: www-1.0

>Number:         51410
>Category:       kern
>Synopsis:       running lfs_cleanerd after mount panics on sasert
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    dholland
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Aug 12 01:35:00 +0000 2016
>Closed-Date:    
>Last-Modified:  Thu May 26 05:17:12 +0000 2022
>Originator:     coypu
>Release:        NetBSD 7.99.35
>Organization:
>Environment:
NetBSD laptop 7.99.35 NetBSD 7.99.35 (GENERIC) #9: Sun Aug  7 01:51:29 IDT 2016  fly@:/home/fly/cvs/obj-amd64/sys/arch/amd64/compile/GENERIC amd64
>Description:
have LFS mounted on /lfs

# pkill lfs_cleanerd
# lfs_cleanerd /lfs

-> panic

System panicked: kernel diagnostic assertion "fs->lfs_cleaner_thread == curlwp" failed: file "/home/fly/cvs/src/sys/ufs/lfs/lfs_syscalls.c", line 668
>How-To-Repeat:

>Fix:
The following will prevent the panic, but run into other issues with two cleaners, most likely.

--- /usr/cvs/src/sys/ufs/lfs/lfs_syscalls.c	2015-10-15 09:15:48.000000000 +0300
+++ /home/fly/lfs_syscalls.c	2016-08-12 04:25:00.437899808 +0300
@@ -663,9 +663,8 @@
 	ump = VFSTOULFS(mntp);
 	fs = ump->um_lfs;

-	if (fs->lfs_cleaner_thread == NULL)
+	if (fs->lfs_cleaner_thread != curlwp)
 		fs->lfs_cleaner_thread = curlwp;
-	KASSERT(fs->lfs_cleaner_thread == curlwp);

 	cnt = blkcnt;


>Release-Note:

>Audit-Trail:
From: coypu@SDF.ORG
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: kern/51410: running lfs_cleanerd after mount panics on sasert
Date: Fri, 12 Aug 2016 02:03:57 +0000

 Maybe test if previous cleaner is still running in this instead?
 I don't know how.

State-Changed-From-To: open->closed
State-Changed-By: maya@NetBSD.org
State-Changed-When: Sun, 26 Feb 2017 12:33:40 +0000
State-Changed-Why:


Responsible-Changed-From-To: kern-bug-people->dholland
Responsible-Changed-By: dholland@NetBSD.org
Responsible-Changed-When: Thu, 26 May 2022 05:17:12 +0000
Responsible-Changed-Why:
lfs


State-Changed-From-To: closed->open
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Thu, 26 May 2022 05:17:12 +0000
State-Changed-Why:
not actually fixed


>Unformatted:

Home	PR Database Search