NetBSD Problem Report #51456

From www@NetBSD.org  Thu Sep  1 07:04:05 2016
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 95D247A213
	for <gnats-bugs@gnats.NetBSD.org>; Thu,  1 Sep 2016 07:04:05 +0000 (UTC)
Message-Id: <20160901070404.99C057A2B6@mollari.NetBSD.org>
Date: Thu,  1 Sep 2016 07:04:04 +0000 (UTC)
From: joern.clausen@uni-bielefeld.de
Reply-To: joern.clausen@uni-bielefeld.de
To: gnats-bugs@NetBSD.org
Subject: please withdraw the change to lang/php5* introduced by jdolecek@ in July
X-Send-Pr-Version: www-1.0

>Number:         51456
>Category:       pkg
>Synopsis:       please withdraw the change to lang/php5* introduced by jdolecek@ in July
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    jdolecek
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Thu Sep 01 07:05:00 +0000 2016
>Closed-Date:    Mon Oct 31 03:42:59 +0000 2016
>Last-Modified:  Mon Oct 31 03:42:59 +0000 2016
>Originator:     Joern Clausen
>Release:        
>Organization:
University of Bielefeld
>Environment:
>Description:
For further reference see this thread on pkgsrc-users

http://mail-index.netbsd.org/pkgsrc-users/2016/08/29/msg023649.html

and this one on joyent/pkgsrc:

https://github.com/joyent/pkgsrc/issues/355

The change introduced in July forces PHP to automatically load all available modules. This may break installed applications that define the set of modules with a private php.ini (due to loading modules twice), and forces applications to load modules they don't need (e.g. database connectors that are never used).

The "fix" described by jperkins@ in the first mail thread is IMHO unacceptable, as I don't want to constantly remove files from $LOCALBASE.
>How-To-Repeat:

>Fix:
If this new behavior is considered useful, please make it an optional one you can switch on and off (with default "off") in e.g. mk.conf. By default the module specific .ini files should only be placed into

$LOCALBASE/share/examples/php/

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->jdolecek
Responsible-Changed-By: maya@NetBSD.org
Responsible-Changed-When: Fri, 14 Oct 2016 16:19:58 +0000
Responsible-Changed-Why:
at the risk of upsetting people, I don't think you noticed this.


State-Changed-From-To: open->feedback
State-Changed-By: jdolecek@NetBSD.org
State-Changed-When: Tue, 18 Oct 2016 19:10:59 +0000
State-Changed-Why:
Committed a change to make it possible to override the directory where
the example config files are installed if they don't exist already,
via PHP_EXT_CONF_DIR. Would this be okay solution for you?


From: "Jaromir Dolecek" <jdolecek@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/51456 CVS commit: pkgsrc/lang/php
Date: Tue, 18 Oct 2016 19:09:10 +0000

 Module Name:	pkgsrc
 Committed By:	jdolecek
 Date:		Tue Oct 18 19:09:10 UTC 2016

 Modified Files:
 	pkgsrc/lang/php: MESSAGE.module ext.mk

 Log Message:
 rename EXT_CONF_DIR to PHP_EXT_CONF_DIR, adjust it so that it's overridable
 in mk.conf, and adjust working in MESSAGE.module to say more clearly
 what is happening

 PR pkg/51456 by Joern Clausen


 To generate a diff of this commit:
 cvs rdiff -u -r1.4 -r1.5 pkgsrc/lang/php/MESSAGE.module
 cvs rdiff -u -r1.42 -r1.43 pkgsrc/lang/php/ext.mk

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Manuel Bouyer <bouyer@antioche.eu.org>
To: gnats-bugs@netbsd.org
Cc: jdolecek@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org,
        joern.clausen@uni-bielefeld.de
Subject: Re: PR/51456 CVS commit: pkgsrc/lang/php
Date: Tue, 18 Oct 2016 22:12:58 +0200

 On Tue, Oct 18, 2016 at 07:20:01PM +0000, Jaromir Dolecek wrote:
 > The following reply was made to PR pkg/51456; it has been noted by GNATS.
 > 
 > From: "Jaromir Dolecek" <jdolecek@netbsd.org>
 > To: gnats-bugs@gnats.NetBSD.org
 > Cc: 
 > Subject: PR/51456 CVS commit: pkgsrc/lang/php
 > Date: Tue, 18 Oct 2016 19:09:10 +0000
 > 
 >  Module Name:	pkgsrc
 >  Committed By:	jdolecek
 >  Date:		Tue Oct 18 19:09:10 UTC 2016
 >  
 >  Modified Files:
 >  	pkgsrc/lang/php: MESSAGE.module ext.mk
 >  
 >  Log Message:
 >  rename EXT_CONF_DIR to PHP_EXT_CONF_DIR, adjust it so that it's overridable
 >  in mk.conf, and adjust working in MESSAGE.module to say more clearly
 >  what is happening
 >  
 >  PR pkg/51456 by Joern Clausen

 will PHP_EXT_CONF_DIR work for binary packages too ?

 -- 
 Manuel Bouyer <bouyer@antioche.eu.org>
      NetBSD: 26 ans d'experience feront toujours la difference
 --

From: =?ISO-8859-15?Q?J=F6rn_Clausen?= <joern.clausen@uni-bielefeld.de>
To: gnats-bugs@NetBSD.org
Cc: Jaromir Dolecek <jdolecek@NetBSD.org>, gnats-admin@NetBSD.org,
 pkgsrc-bugs@NetBSD.org
Subject: Re: PR/51456 CVS commit: pkgsrc/lang/php
Date: Wed, 26 Oct 2016 14:53:29 +0200

 We have tested the change against our PHP installation and are happy 
 with the solution. From our point of view this PR can be closed, but 
 maybe Manual's question should be answered first.

 Thanks for the fix!

 Joern

 -- 
 Jörn Clausen
 Plattformen & Serverdienste
 Hochschulrechenzentrum

 Universität Bielefeld
 Universitätsstraße 25
 33615 Bielefeld
 Telefon: +49 521 106-12601
 E-Mail: joern.clausen@uni-bielefeld.de

 http://www.uni-bielefeld.de/hrz

State-Changed-From-To: feedback->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Mon, 31 Oct 2016 03:42:59 +0000
State-Changed-Why:
Feedback received.

as for binary packages, I wouldn't expect so as it's a compile-time path.
If this is a problem, we should maybe do something about it, but it's hard
to know what. File another PR if necessary.


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2014 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.