NetBSD Problem Report #51643

From www@NetBSD.org  Tue Nov 22 22:56:28 2016
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 776A47A2C1
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 22 Nov 2016 22:56:28 +0000 (UTC)
Message-Id: <20161122225627.477B17A309@mollari.NetBSD.org>
Date: Tue, 22 Nov 2016 22:56:27 +0000 (UTC)
From: waddell@caravaninfotech.com
Reply-To: waddell@caravaninfotech.com
To: gnats-bugs@NetBSD.org
Subject: please add auth-request module to pkgsrc/www/nginx/options.mk
X-Send-Pr-Version: www-1.0

>Number:         51643
>Category:       pkg
>Synopsis:       please add auth-request module to pkgsrc/www/nginx/options.mk
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    osa
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Tue Nov 22 23:00:00 +0000 2016
>Closed-Date:    Mon Apr 24 16:57:25 +0000 2023
>Last-Modified:  Mon Apr 24 16:57:25 +0000 2023
>Originator:     Harry Waddell
>Release:        pkgsrc current as of 11/22/16
>Organization:
Caravan Electronic Publishing, LLC
>Environment:
NetBSD  6.1_STABLE NetBSD 6.1_STABLE (GENERIC) amd64
>Description:
The auth-request module is commonly needed if one wants to authenticate against a credential sources other than a local passwd file. 

http://nginx.org/en/docs/http/ngx_http_auth_request_module.html

I've been using the attached patch for a few years now without issue. No further adaptation seems to be needed for use with pkgsrc. This is useful to support SSO and other external authentication schemes. 

I think adding it to the options is sufficient. As per the nginx docs, I don't think it needs to be added by default. 


>How-To-Repeat:
n/a
>Fix:
Index: options.mk
===================================================================
RCS file: /cvsroot/pkgsrc/www/nginx/options.mk,v
retrieving revision 1.36
diff -u -r1.36 options.mk
--- options.mk	15 Jun 2016 14:49:11 -0000	1.36
+++ options.mk	22 Nov 2016 22:43:31 -0000
@@ -5,7 +5,7 @@
 			pcre push realip ssl sub uwsgi image-filter \
 			debug status nginx-autodetect-cflags echo \
 			set-misc headers-more array-var encrypted-session \
-			form-input perl gzip v2
+			form-input perl gzip v2 auth-request

 PKG_SUGGESTED_OPTIONS=	inet6 pcre ssl

@@ -216,3 +216,7 @@
 .if !empty(PKG_OPTIONS:Mgzip)
 CONFIGURE_ARGS+=	--with-http_gzip_static_module
 .endif
+
+.if !empty(PKG_OPTIONS:Mauth-request)
+CONFIGURE_ARGS+=        --with-http_auth_request_module
+.endif

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->joerg
Responsible-Changed-By: maya@NetBSD.org
Responsible-Changed-When: Thu, 24 Nov 2016 10:56:21 +0000
Responsible-Changed-Why:
Over to maintainer


Responsible-Changed-From-To: joerg->osa
Responsible-Changed-By: osa@NetBSD.org
Responsible-Changed-When: Mon, 24 Apr 2023 16:47:20 +0000
Responsible-Changed-Why:
I'll take it.


State-Changed-From-To: open->closed
State-Changed-By: osa@NetBSD.org
State-Changed-When: Mon, 24 Apr 2023 16:57:25 +0000
State-Changed-Why:
The auth-request module was added to the www/nginx* packages.
Thanks for the report!


>Unformatted:

Home	PR Database Search