NetBSD Problem Report #51646

From hf@Bounce.nt.e-technik.tu-darmstadt.de  Wed Nov 23 12:38:22 2016
Return-Path: <hf@Bounce.nt.e-technik.tu-darmstadt.de>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id A4FFD7A324
	for <gnats-bugs@gnats.NetBSD.org>; Wed, 23 Nov 2016 12:38:22 +0000 (UTC)
Message-Id: <201611231214.uANCEF8v022421@Anscharte.nt.e-technik.tu-darmstadt.de>
Date: Wed, 23 Nov 2016 13:14:15 +0100 (CET)
From: Hauke Fath <hf@spg.tu-darmstadt.de>
Reply-To: Hauke Fath <hf@spg.tu-darmstadt.de>
To: gnats-bugs@NetBSD.org
Cc: Hauke Fath <hf@spg.tu-darmstadt.de>
Subject: x11/modular-xorg-server fails to configure 
X-Send-Pr-Version: 3.95

>Number:         51646
>Category:       pkg
>Synopsis:       x11/modular-xorg-server fails to configure
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Nov 23 12:40:00 +0000 2016
>Closed-Date:    Thu Mar 23 17:20:19 +0000 2017
>Last-Modified:  Thu Mar 23 17:20:19 +0000 2017
>Originator:     Hauke Fath
>Release:        NetBSD 7.99.42
>Organization:
Technische Universitaet Darmstadt
>Environment:


System: NetBSD Anscharte.nt.e-technik.tu-darmstadt.de 7.99.42 NetBSD 7.99.42 (HP2170P) #0: Wed Nov 16 17:23:21 CET 2016 hauke@Anscharte.nt.e-technik.tu-darmstadt.de:/var/obj/netbsd-builds/developer/amd64/sys/arch/amd64/compile/HP2170P amd64
Architecture: x86_64
Machine: amd64
>Description:

	On -current, after the recent update to 1.19.0 the
	x11/modular-xorg-server build fails in configure phase with

[...]
checking for socklen_t... yes
checking for struct msghdr.msg_control... yes
checking if Xtrans should support os-specific local connections... no
checking for authdes_seccreate... no
checking for authdes_create... no
checking if Secure RPC authentication ("SUN-DES-1") should be supported... no
checking for PIXMAN... yes
checking whether PTHREAD_MUTEX_RECURSIVE is declared... yes
checking if compiler needs -Werror to reject unknown flags... no
configure: error: threaded input requested but no pthread support has been found
*** Error code 1

Stop.
make[1]: stopped in /local/source/pkgsrc/x11/modular-xorg-server
*** Error code 1


	config.log has

[...]
configure:22411: gcc -c -O2 -pipe -Wall -Wno-error -I/usr/include -I/usr/pkg/inc
lude -I/usr/pkg/include/freetype2 -I/usr/pkg/include/libdrm -Werror -Wunknown-wa
rning-option -Wsizeof-array-argument -D_OPENBSD_SOURCE -I/usr/include -I/usr/pkg
/include -I/usr/pkg/include/freetype2 -I/usr/pkg/include/libdrm conftest.c >&5
gcc: error: unrecognized command line option '-Wunknown-warning-option'
[...]

	gcc is

% gcc --version
gcc (nb1 20160606) 5.4.0
Copyright (C) 2015 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
%


>How-To-Repeat:

	(Try to) build the package on netbsd-current.


>Fix:

	Yes, please.



>Release-Note:

>Audit-Trail:
From: Thomas Klausner <wiz@NetBSD.org>
To: NetBSD bugtracking <gnats-bugs@NetBSD.org>
Cc: 
Subject: Re: pkg/51646: x11/modular-xorg-server fails to configure
Date: Wed, 23 Nov 2016 13:47:03 +0100

 On Wed, Nov 23, 2016 at 12:40:00PM +0000, Hauke Fath wrote:
 > >Synopsis:       x11/modular-xorg-server fails to configure

 I don't see this. Please send me your complete config.log.

 Thanks,
  Thomas

From: Thomas Klausner <wiz@NetBSD.org>
To: NetBSD bugtracking <gnats-bugs@NetBSD.org>
Cc: 
Subject: Re: pkg/51646: x11/modular-xorg-server fails to configure
Date: Wed, 23 Nov 2016 14:48:08 +0100

 In my configure environment, PTHREAD_CFLAGS is set, but it doesn't
 seem to be set for you, according to the config.log you sent me.

 Please show me

 # make show-var VARNAME=3DCONFIGURE_ENV

 For me it is:

 APP_MAN_SUFFIX=3D1 FILE_MAN_SUFFIX=3D5 DRIVER_MAN_SUFFIX=3D4 ac_cv_path_RAW=
 CPP=3D"/usr/pkg/bin/tradcpp -Uunix" FREETYPE_CONFIG=3D/usr/pkg/bin/freetype=
 -config LIBTOOL=3D"/scratch/x11/modular-xorg-server/work/.cwrapper/bin/libt=
 ool " ac_cv_header_sys_event_h=3Dno INSTALL_INFO=3D MAKEINFO=3D/scratch/x11=
 /modular-xorg-server/work/.tools/bin/makeinfo FLEX=3D BISON=3D AWK=3D/usr/b=
 in/awk CAT=3D/bin/cat ac_cv_path_CAT=3D/bin/cat CHMOD=3D/bin/chmod CMP=3D/u=
 sr/bin/cmp CP=3D/bin/cp DIFF=3D/usr/bin/diff ECHO=3Decho ac_cv_path_ECHO=3D=
 echo EGREP=3D/usr/bin/egrep ac_cv_path_EGREP=3D/usr/bin/egrep SETENV=3D/usr=
 /bin/env ENV_PROG=3D/usr/bin/env ac_cv_path_ENV=3D/usr/bin/env FALSE=3Dfals=
 e ac_cv_path_FALSE=3Dfalse FIND=3D/usr/bin/find GREP=3D/usr/bin/grep ac_cv_=
 path_GREP=3D/usr/bin/grep HOSTNAME=3D/bin/hostname LN=3D/bin/ln LS=3D/bin/l=
 s MKDIR=3D/bin/mkdir\ -p MV=3D/bin/mv RM=3D/bin/rm RMDIR=3D/bin/rmdir SED=
 =3D/usr/bin/sed SORT=3D/usr/bin/sort TAR=3D/bin/tar TEST=3Dtest ac_cv_path_=
 TEST=3Dtest TOUCH=3D/usr/bin/touch TR=3D/usr/bin/tr TRUE=3Dtrue ac_cv_path_=
 TRUE=3Dtrue PKG_CONFIG=3D/scratch/x11/modular-xorg-server/work/.tools/bin/p=
 kg-config PKG_CONFIG_LIBDIR=3D/scratch/x11/modular-xorg-server/work/.buildl=
 ink/lib/pkgconfig:/scratch/x11/modular-xorg-server/work/.buildlink/share/pk=
 gconfig PKG_CONFIG_LOG=3D/scratch/x11/modular-xorg-server/work/.pkg-config.=
 log PKG_CONFIG_PATH=3D MAKE=3Dmake PTHREAD_CFLAGS=3D\ -pthread\  PTHREAD_LD=
 FLAGS=3D\ -pthread PTHREAD_LIBS=3D PTHREADBASE=3D/usr CWRAPPERS_CONFIG_DIR=
 =3D/scratch/x11/modular-xorg-server/work/.cwrapper/config CC=3Dgcc CFLAGS=
 =3D-O2 CPPFLAGS=3D-D_OPENBSD_SOURCE CXX=3Dc++ CXXFLAGS=3D-O2 COMPILER_RPATH=
 _FLAG=3D-Wl,-R F77=3Dg77 FC=3Dg77 FFLAGS=3D-O LANG=3DC LC_ALL=3DC LC_COLLAT=
 E=3DC LC_CTYPE=3DC LC_MESSAGES=3DC LC_MONETARY=3DC LC_NUMERIC=3DC LC_TIME=
 =3DC LDFLAGS=3D LINKER_RPATH_FLAG=3D-R PATH=3D/scratch/x11/modular-xorg-ser=
 ver/work/.cwrapper/bin:/scratch/x11/modular-xorg-server/work/.buildlink/bin=
 :/scratch/x11/modular-xorg-server/work/.gcc/bin:/scratch/x11/modular-xorg-s=
 erver/work/.tools/bin:/usr/pkg/bin:/usr/X11R7/bin:/home/wiz/bin:/bin:/usr/b=
 in:/usr/pkg/bin:/usr/X11R7/bin:/usr/local/bin:/sbin:/usr/sbin:/usr/pkg/sbin=
 :/usr/local/sbin:/usr/games:/usr/pkg/lib/surfraw:/archive/foreign/nfotex/ta=
 sks/bin:/usr/pkg/bin:/usr/pkg/bin PREFIX=3D/usr/pkg MAKELEVEL=3D0 CONFIG_SI=
 TE=3D PKG_SYSCONFDIR=3D/usr/pkg/etc CXXCPP=3Dcpp HOME=3D/scratch/x11/modula=
 r-xorg-server/work/.home CWRAPPERS_CONFIG_DIR=3D/scratch/x11/modular-xorg-s=
 erver/work/.cwrapper/config CONFIG_SHELL=3D/bin/sh LIBS=3D ac_given_INSTALL=
 =3D/usr/bin/install\ -c\ -o\ root\ -g\ wheel lt_cv_sys_max_cmd_len=3D262144

From: Hauke Fath <hf@spg.tu-darmstadt.de>
To: gnats-bugs@NetBSD.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org
Subject: Re: pkg/51646: x11/modular-xorg-server fails to configure
Date: Wed, 23 Nov 2016 14:55:04 +0100

 On Wed, 23 Nov 2016 13:50:01 +0000 (UTC), Thomas Klausner wrote:
 >  Please show me
 >  
 >  # make show-var VARNAME=3DCONFIGURE_ENV

 % pwd
 /misc/pkgsrc/x11/modular-xorg-server
 %  make show-var VARNAME=CONFIGURE_ENV
 APP_MAN_SUFFIX=1 FILE_MAN_SUFFIX=5 DRIVER_MAN_SUFFIX=4 
 ac_cv_path_RAWCPP="/usr/pkg/bin/tradcpp -Uunix" 
 FREETYPE_CONFIG=/usr/pkg/bin/freetype-config 
 LIBTOOL="/var/obj/pkgsrc/x11/modular-xorg-server/work/.cwrapper/bin/libtool 
 " ac_cv_header_sys_event_h=no INSTALL_INFO= 
 MAKEINFO=/var/obj/pkgsrc/x11/modular-xorg-server/work/.tools/bin/makeinfo 
 FLEX= BISON= AWK=/usr/bin/awk CAT=/bin/cat ac_cv_path_CAT=/bin/cat 
 CHMOD=/bin/chmod CMP=/usr/bin/cmp CP=/bin/cp DIFF=/usr/bin/diff 
 ECHO=echo ac_cv_path_ECHO=echo EGREP=/usr/bin/egrep 
 ac_cv_path_EGREP=/usr/bin/egrep SETENV=/usr/bin/env 
 ENV_PROG=/usr/bin/env ac_cv_path_ENV=/usr/bin/env FALSE=false 
 ac_cv_path_FALSE=false FIND=/usr/bin/find GREP=/usr/bin/grep 
 ac_cv_path_GREP=/usr/bin/grep HOSTNAME=/bin/hostname LN=/bin/ln 
 LS=/bin/ls MKDIR=/bin/mkdir\ -p MV=/bin/mv RM=/bin/rm RMDIR=/bin/rmdir 
 SED=/usr/bin/sed SORT=/usr/bin/sort TAR=/bin/tar TEST=test 
 ac_cv_path_TEST=test TOUCH=/usr/bin/touch TR=/usr/bin/tr TRUE=true 
 ac_cv_path_TRUE=true 
 PKG_CONFIG=/var/obj/pkgsrc/x11/modular-xorg-server/work/.tools/bin/pkg-config 
 PKG_CONFIG_LIBDIR=/var/obj/pkgsrc/x11/modular-xorg-server/work/.buildlink/lib/pkgconfig:/var/obj/pkgsrc/x11/modular-xorg-server/work/.buildlink/share/pkgconfig 
 PKG_CONFIG_LOG=/var/obj/pkgsrc/x11/modular-xorg-server/work/.pkg-config.log 
 PKG_CONFIG_PATH= MAKE=make PTHREAD_CFLAGS=\ -pthread\  
 PTHREAD_LDFLAGS=\ -pthread PTHREAD_LIBS= PTHREADBASE=/usr 
 CWRAPPERS_CONFIG_DIR=/var/obj/pkgsrc/x11/modular-xorg-server/work/.cwrapper/config 
 CC=gcc CFLAGS=-O2\ -pipe\ -Wall\ -Wno-error CPPFLAGS=-D_OPENBSD_SOURCE 
 CXX=c++ CXXFLAGS=-O2\ -pipe\ -Wall\ -Wno-error\ -pipe\ -Wall\ 
 -Wno-error COMPILER_RPATH_FLAG=-Wl,-R F77=g77 FC=g77 FFLAGS=-O LANG=C 
 LC_ALL=C LC_COLLATE=C LC_CTYPE=C LC_MESSAGES=C LC_MONETARY=C 
 LC_NUMERIC=C LC_TIME=C LDFLAGS= LINKER_RPATH_FLAG=-R 
 PATH=/var/obj/pkgsrc/x11/modular-xorg-server/work/.cwrapper/bin:/var/obj/pkgsrc/x11/modular-xorg-server/work/.buildlink/bin:/var/obj/pkgsrc/x11/modular-xorg-server/work/.gcc/bin:/var/obj/pkgsrc/x11/modular-xorg-server/work/.tools/bin:/usr/pkg/bin:/home/hauke/bin:/usr/pkg/sbin:/sbin:/usr/sbin:/usr/local/sbin:/usr/pkg/bin:/usr/X11R7/bin:/bin:/usr/bin:/usr/local/bin:/usr/pkg/bin:/usr/pkg/bin 
 PREFIX=/usr/pkg MAKELEVEL=0 CONFIG_SITE= PKG_SYSCONFDIR=/etc/pkg 
 CXXCPP=cpp HOME=/var/obj/pkgsrc/x11/modular-xorg-server/work/.home 
 CWRAPPERS_CONFIG_DIR=/var/obj/pkgsrc/x11/modular-xorg-server/work/.cwrapper/config 
 CONFIG_SHELL=/bin/sh LIBS= ac_given_INSTALL=/usr/bin/install\ -c\ -o\ 
 hauke\ -g\ users lt_cv_sys_max_cmd_len=262144
 %

From: Thomas Klausner <wiz@NetBSD.org>
To: NetBSD bugtracking <gnats-bugs@NetBSD.org>
Cc: 
Subject: Re: pkg/51646: x11/modular-xorg-server fails to configure
Date: Wed, 23 Nov 2016 15:02:41 +0100

 Ok, you have
 PTHREAD_CFLAGS=\ -pthread\  

 That's weird, because in your config.log it said:
 PTHREAD_CFLAGS=''

 Can you please check how that happens?
  Thomas

From: Hauke Fath <hf@spg.tu-darmstadt.de>
To: gnats-bugs@NetBSD.org
Cc: pkg-manager@NetBSD.org, gnats-admin@NetBSD.org
Subject: Re: pkg/51646: x11/modular-xorg-server fails to configure
Date: Wed, 23 Nov 2016 15:36:17 +0100

 On Wed, 23 Nov 2016 14:05:01 +0000 (UTC), Thomas Klausner wrote:
 >  Ok, you have
 >  PTHREAD_CFLAGS=3D\ -pthread\ =20
 > =20
 >  That's weird, because in your config.log it said:
 >  PTHREAD_CFLAGS=3D''
 > =20
 >  Can you please check how that happens?

 Hm - what is the relation between the configure script line numbers (as=20
 in 'less -N') and the numbers given in config.log? What I see doesn't=20
 make any sense...

 % ls -l configure config.log
 -rw-r--r--  1 hauke  wsrc   267478 Nov 23 14:54 config.log
 -rwxr-xr-x  1 hauke  wsrc  1047787 Nov 23 14:54 configure
 %

 While in config.log I see

 configure:22681: error: threaded input requested but no pthread support=20
 has been found

 the message is really issued from=20

   25436         as_fn_error $? "threaded input requested but no pthread=20
 support has been found" "$LINENO" 5

 hauke

 --=20
      The ASCII Ribbon Campaign                    Hauke Fath
 ()     No HTML/RTF in email            Institut f=FCr Nachrichtentechnik
 /\     No Word docs in email                     TU Darmstadt
      Respect for open standards              Ruf +49-6151-16-21344

From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/51646: x11/modular-xorg-server fails to configure
Date: Thu, 24 Nov 2016 18:05:54 +0000

 On Wed, Nov 23, 2016 at 02:40:01PM +0000, Hauke Fath wrote:
  >  Hm - what is the relation between the configure script line numbers (as=20
  >  in 'less -N') and the numbers given in config.log? What I see doesn't=20
  >  make any sense...

 There's a shell builtin for it. When configure thinks that's missing,
 it creates a "configure.lineno" script with the line numbers baked in
 and then runs that. If sh is getting it wrong it would be nice to find
 out why, even though it's probably unrelated to the real problem.

 (Unless the problem in both cases is that it's running some other
 configure script than the one you're looking at, I guess...)

 -- 
 David A. Holland
 dholland@netbsd.org

From: Hauke Fath <hf@spg.tu-darmstadt.de>
To: gnats-bugs@NetBSD.org
Cc: pkg-manager@NetBSD.org, gnats-admin@NetBSD.org
Subject: Re: pkg/51646: x11/modular-xorg-server fails to configure
Date: Thu, 24 Nov 2016 22:12:35 +0100

 On Thu, 24 Nov 2016 18:10:00 +0000 (UTC), David Holland wrote:
 >  On Wed, Nov 23, 2016 at 02:40:01PM +0000, Hauke Fath wrote:
 >   >  Hm - what is the relation between the configure script line=20
 > numbers (as=3D20
 >   >  in 'less -N') and the numbers given in config.log? What I see=20
 > doesn't=3D20
 >   >  make any sense...
 > =20
 >  There's a shell builtin for it.

 ???

 Are we talking about any shell (including my tcsh login shell), the=20
 POSIX shell, some bash magic? Something that autohell may or may not=20
 ship?=20

 Pardon me if I sound exasperated, because that's how I feel. All my=20
 google fu came up with was=20
 <https://lists.gnu.org/archive/html/autoconf/2004-01/msg00034.html>,=20
 and it didn't help.

 >  When configure thinks that's missing,
 >  it creates a "configure.lineno" script with the line numbers baked in
 >  and then runs that.=20

 % pwd
 /var/obj/pkgsrc/x11/modular-xorg-server/work/xorg-server-1.19.0
 % ls -dF config*
 config/           config.guess@     config.log        config.sub@      =20
 configure*        configure.ac      configure.orig*
 %

 >  If sh is getting it wrong it would be nice to find
 >  out why, even though it's probably unrelated to the real problem.
 > =20
 >  (Unless the problem in both cases is that it's running some other
 >  configure script than the one you're looking at, I guess...)

 % find . -name configure -print
 ./configure
 %

 I hope not?

 hauke

 --=20
      The ASCII Ribbon Campaign                    Hauke Fath
 ()     No HTML/RTF in email            Institut f=FCr Nachrichtentechnik
 /\     No Word docs in email                     TU Darmstadt
      Respect for open standards              Ruf +49-6151-16-21344

From: coypu@SDF.ORG
To: gnats-bugs@NetBSD.org
Cc: wiz@netbsd.org
Subject: Re: pkg/51646: x11/modular-xorg-server fails to configure
Date: Thu, 24 Nov 2016 22:13:28 +0000

 Hello, my other message seemed to have disappeared.

 This hunk to patch-configure gets me through configure.

 @@ -25101,11 +25101,6 @@ case ${host_os} in
          darwin*)
          ax_pthread_flags="-pthread $ax_pthread_flags"
          ;;
 -	netbsd*)
 -	# use libc stubs, don't link against libpthread, to allow
 -	# dynamic loading
 -	ax_pthread_flags=""
 -	;;
  esac

  # Clang doesn't consider unrecognized options an error unless we specify


 However, build fails:
   CC       dri.lo
 In file included from xf86dri.c:59:
 ./dri.h:41:10: fatal error: 'xf86dri.h' file not found
 #include "xf86dri.h"
          ^
 In file included from dri.c:64:
 ./dri.h:41:10: fatal error: 'xf86dri.h' file not found
 #include "xf86dri.h"
          ^

From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/51646: x11/modular-xorg-server fails to configure
Date: Fri, 25 Nov 2016 18:08:42 +0000

 On Thu, Nov 24, 2016 at 10:00:01PM +0000, Hauke Fath wrote:
  >  >  There's a shell builtin for it.
  >  
  >  ???
  >  
  >  Are we talking about any shell (including my tcsh login shell), the=20
  >  POSIX shell, some bash magic? Something that autohell may or may not=20
  >  ship?=20

 sh.

 % sh -c 'echo $LINENO'
 1

 Anyway, I can repeat the failure you see by configuring outside pkgsrc
 (unsurprisingly) but I get correct line numbers in config.log.

 That's with a -current sh from some time back, though, so maybe
 someone broke it.

 -- 
 David A. Holland
 dholland@netbsd.org

From: Hauke Fath <hf@spg.tu-darmstadt.de>
To: gnats-bugs@NetBSD.org
Cc: pkg-manager@NetBSD.org, gnats-admin@NetBSD.org
Subject: Re: pkg/51646: x11/modular-xorg-server fails to configure
Date: Sat, 26 Nov 2016 13:08:51 +0100

 On Thu, 24 Nov 2016 22:15:01 +0000 (UTC), coypu@SDF.ORG wrote:
 >  This hunk to patch-configure gets me through configure.
 > =20
 >  @@ -25101,11 +25101,6 @@ case ${host_os} in
 >           darwin*)
 >           ax_pthread_flags=3D"-pthread $ax_pthread_flags"
 >           ;;
 >  -=09netbsd*)
 >  -=09# use libc stubs, don't link against libpthread, to allow
 >  -=09# dynamic loading
 >  -=09ax_pthread_flags=3D""
 >  -=09;;
 >   esac
 >  =20
 >   # Clang doesn't consider unrecognized options an error unless we specif=
 y

 This works for me too, and would probably answer Thomases question.
  =20
 >  However, build fails:
 >    CC       dri.lo
 >  In file included from xf86dri.c:59:
 >  ./dri.h:41:10: fatal error: 'xf86dri.h' file not found
 >  #include "xf86dri.h"
 >           ^
 >  In file included from dri.c:64:
 >  ./dri.h:41:10: fatal error: 'xf86dri.h' file not found
 >  #include "xf86dri.h"
 >           ^

 This, OTOH, I don't see. After the above patch, the package builds and=20
 packages.

 And after the pkg-rolling-replace run completed, it looks like the X=20
 server is fine.

 Cheerio,
 hauke=20

 --=20
      The ASCII Ribbon Campaign                    Hauke Fath
 ()     No HTML/RTF in email            Institut f=FCr Nachrichtentechnik
 /\     No Word docs in email                     TU Darmstadt
      Respect for open standards              Ruf +49-6151-16-21344

From: Hauke Fath <hf@spg.tu-darmstadt.de>
To: gnats-bugs@NetBSD.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org
Subject: Re: pkg/51646: x11/modular-xorg-server fails to configure
Date: Wed, 7 Dec 2016 15:56:17 +0100

 On 11/26/16 13:30, Hauke Fath wrote:
 > After the above patch, the package builds andpackages.
 >
 > And after the pkg-rolling-replace run completed, it looks like the X
 > server is fine.

 Sort of... the X server does not start, complaining about incompatible 
 mouse and keyboard modules. Looking through 
 x11/modular-xorg-server/Makefile*, xf86-input-{keyboard,mouse} are 
 indeed not in its list of dependencies (most everything else appears to 
 be...).

 Adter updating the two packages, the x11/xf86-video-intel driver does 
 fail to build against modular-xorg-server 1.19 (see PR pkg/51687), so no X.

 Any comments on the viability of the above patch?

 Cheerio,
 hauke

 -- 
       The ASCII Ribbon Campaign                    Hauke Fath
 ()     No HTML/RTF in email	        Institut für Nachrichtentechnik
 /\     No Word docs in email                     TU Darmstadt
       Respect for open standards              Ruf +49-6151-16-3281

From: coypu@SDF.ORG
To: gnats-bugs@netbsd.org
Cc: wiz@netbsd.org
Subject: Re: pkg/51646: x11/modular-xorg-server fails to configure
Date: Wed, 4 Jan 2017 14:44:35 +0000

 currently we have ax_pthread_ok = no all the time.

         if test x"$ax_pthread_ok" = xno; then
                 PTHREAD_LIBS=""
                 PTHREAD_CFLAGS=""
         fi
 (indentation irrelevant, it is unconditional.)

 Normally, there is:
 # Create a list of thread flags to try.  Items starting with a "-" are
 # C compiler flags, and other items are library names, except for "none"
 # which indicates that we try without any flags at all, and "pthread-config"
 # which is a program returning the flags for the Pth emulation library.

 ax_pthread_flags="pthreads none -Kthread -kthread lthread -pthread -pthreads -mthreads pthread --thread-safe -mt pthread-config"

 we set it on netbsd to ""

 then...
 if test x"$ax_pthread_ok" = xno; then
 for flag in $ax_pthread_flags; do

         case $flag in
                 none)
                 { $as_echo "$as_me:${as_lineno-$LINENO}: checking whether pthreads work without any flags" >&5
 $as_echo_n "checking whether pthreads work without any flags... " >&6; }
                 ;;

                 -*)
                 { $as_echo "$as_me:${as_lineno-$LINENO}: checking whether pthreads work with $flag" >&5
 $as_echo_n "checking whether pthreads work with $flag... " >&6; }
                 PTHREAD_CFLAGS="$flag"
                 ;;

                 pthread-config)
                 # Extract the first word of "pthread-config", so it can be a program name with args.

 neither of this cases applies. and PTHREAD_CFLAGS does not get set back.

 it will attempt ax_pthread_flags and ignore PTHREAD_CFLAGS environment.
 we tell it to try nothing. nothing doesn't work since we need -pthread.

From: Joerg Sonnenberger <joerg@bec.de>
To: gnats-bugs@NetBSD.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org,
	Hauke Fath <hf@spg.tu-darmstadt.de>
Subject: Re: pkg/51646: x11/modular-xorg-server fails to configure
Date: Thu, 5 Jan 2017 11:36:38 +0100

 On Wed, Jan 04, 2017 at 02:45:00PM +0000, coypu@SDF.ORG wrote:
 >  it will attempt ax_pthread_flags and ignore PTHREAD_CFLAGS environment.
 >  we tell it to try nothing. nothing doesn't work since we need -pthread.

 No, we don't. It looks like someone refactored that logic but didn't
 update the existing code consistently, i.e. testing only on Linux.
 I'd guess from the latter case that the variable should now be set to
 "none".

 Joerg

From: coypu@SDF.ORG
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/51646: x11/modular-xorg-server fails to configure
Date: Sat, 7 Jan 2017 22:42:31 +0000

 --OXfL5xGRrasGEqWY
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline

 > I'd guess from the latter case that the variable should now be set to
 > "none".

 I attempted this but it still failed. I've attempted to force pass the
 test with ax_pthread_ok="yes" and it seems to get further.
 I'd need a clean bootstrap and a bunch of packages to get through the
 build, though.

 --OXfL5xGRrasGEqWY
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename=patch-configure

 $NetBSD: patch-configure,v 1.3 2015/06/29 11:12:45 wiz Exp $

 Use USE_AMD64_IOPL (actually x86_64_iopl) on NetBSD/amd64.
 (c.f. patch-hw_xfree86_os-support_bsd_i386.c)

 --- configure.orig	2016-11-15 16:21:02.000000000 +0000
 +++ configure
 @@ -23260,7 +23260,7 @@ $as_echo "#define USE_DEV_IO 1" >>confde
  $as_echo "#define USE_DEV_IO 1" >>confdefs.h
   ;;
  		*netbsd*)
 -$as_echo "#define USE_I386_IOPL 1" >>confdefs.h
 +$as_echo "#define USE_AMD64_IOPL 1" >>confdefs.h

  				SYS_LIBS=-lx86_64
  				;;
 @@ -25104,7 +25104,8 @@ case ${host_os} in
  	netbsd*)
  	# use libc stubs, don't link against libpthread, to allow
  	# dynamic loading
 -	ax_pthread_flags=""
 +	ax_pthread_flags="none"
 +	ax_pthread_ok="yes"
  	;;
  esac


 --OXfL5xGRrasGEqWY--

From: "Maya Rashish" <maya@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/51646 CVS commit: pkgsrc/x11/modular-xorg-server
Date: Sat, 28 Jan 2017 21:47:55 +0000

 Module Name:	pkgsrc
 Committed By:	maya
 Date:		Sat Jan 28 21:47:55 UTC 2017

 Modified Files:
 	pkgsrc/x11/modular-xorg-server: distinfo
 	pkgsrc/x11/modular-xorg-server/patches: patch-configure

 Log Message:
 Fix xorg server build on NetBSD by force-passing configure checks.
 pthread seems needed for configure checks only.

 PR pkg/51646


 To generate a diff of this commit:
 cvs rdiff -u -r1.80 -r1.81 pkgsrc/x11/modular-xorg-server/distinfo
 cvs rdiff -u -r1.3 -r1.4 \
     pkgsrc/x11/modular-xorg-server/patches/patch-configure

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->feedback
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Tue, 14 Mar 2017 05:32:32 +0000
State-Changed-Why:
Is this fixed?


State-Changed-From-To: feedback->closed
State-Changed-By: hauke@NetBSD.org
State-Changed-When: Thu, 23 Mar 2017 17:20:19 +0000
State-Changed-Why:
Confirmed fixed.


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2014 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.