NetBSD Problem Report #51666

From kre@munnari.OZ.AU  Sun Nov 27 13:31:00 2016
Return-Path: <kre@munnari.OZ.AU>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 3676A7A2F7
	for <gnats-bugs@www.NetBSD.org>; Sun, 27 Nov 2016 13:31:00 +0000 (UTC)
Message-Id: <201611271254.uARCsbm3006281@onyx.coe.psu.AC.TH>
Date: Sun, 27 Nov 2016 19:54:37 +0700 (ICT)
From: kre@munnari.OZ.AU
To: gnats-bugs@www.NetBSD.org
Subject: www/seamonkey with also audio wants EBADFD (from patch)
X-Send-Pr-Version: 3.95

>Number:         51666
>Category:       pkg
>Synopsis:       www/seamonkey with also audio wants EBADFD (from patch)
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    maya
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Nov 27 13:35:00 +0000 2016
>Closed-Date:    Wed Dec 07 22:09:14 +0000 2016
>Last-Modified:  Wed Dec 07 22:10:01 +0000 2016
>Originator:     Robert Elz
>Release:        NetBSD 6.99.30 -- pkgsrc current of 2016-11-26
>Organization:
>Environment:
System: NetBSD onyx.coe.psu.ac.th 6.99.30 NetBSD 6.99.30 (ONYX-Dom0) #0: Mon Feb 3 19:26:44 ICT 2014 kre@onyx.coe.psu.ac.th:/usr/obj/current/kernels/amd64/ONYX-Dom0 amd64
Architecture: x86_64
Machine: amd64
>Description:
	If www/seamonkey is built with the alsa option enabled, (on NetBSD)
	it fails to build as NetBSD doesn't have the EBADFD error code.

	The need for that isn't in the seamonkey sources, it is added in
	patches/patch-mozilla_media_libcubeb_src_cubeb__alsa.c

>How-To-Repeat:
	By inspection - just read the patch....   Or attempt a build using
	the also option (and -pulseaudio to duplicate my build).

>Fix:
	Perhaps #ifdef EBADFD/#endif around the section of code that
	handles EBADFD in the patch (NetBSD never generates it of course.) 

	Just what is EBADFD (I see it is a linux error), but what is a
	"file descriptor in a bad state" ??

>Release-Note:

>Audit-Trail:
From: coypu@SDF.ORG
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/51666: www/seamonkey with also audio wants EBADFD (from
 patch)
Date: Sun, 27 Nov 2016 13:50:04 +0000

 Hi kre,

 #ifndef EBADFD
 #define EBADFD EBADF
 #endif

 Will probably work. I can't test now, unfortunately.

From: Robert Elz <kre@munnari.OZ.AU>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/51666: www/seamonkey with also audio wants EBADFD (from patch)
Date: Sun, 27 Nov 2016 22:09:02 +0700

     Date:        Sun, 27 Nov 2016 13:55:01 +0000 (UTC)
     From:        coypu@SDF.ORG
     Message-ID:  <20161127135501.A36367A33E@mollari.NetBSD.org>

   |  #ifndef EBADFD
   |  #define EBADFD EBADF
   |  #endif
   |  
   |  Will probably work. I can't test now, unfortunately.

 That is more or less what I did (had done before I sent the PR) - it
 compiles and runs OK, but is not really the correct solution.

 No correct program ever gets EBADF in a situation like that, so checking
 for it is really just wasting time (may as well check for EFAULT as well,
 that is just as likely...).  What EBADFD really is supposed to mean, and
 why it could actually occur are something only linux people understand I
 assume.

 kre

From: "Maya Rashish" <maya@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/51666 CVS commit: pkgsrc/www/seamonkey
Date: Wed, 7 Dec 2016 22:01:28 +0000

 Module Name:	pkgsrc
 Committed By:	maya
 Date:		Wed Dec  7 22:01:28 UTC 2016

 Modified Files:
 	pkgsrc/www/seamonkey: distinfo
 	pkgsrc/www/seamonkey/patches:
 	    patch-mozilla_media_libcubeb_src_cubeb__alsa.c

 Log Message:
 seamonkey: do not add a test for EBADFD in a patch.
 besides not being defined on NetBSD (where it is EBADF), it doesn't
 make sense to test for it.

 From kre in PR pkg/51666


 To generate a diff of this commit:
 cvs rdiff -u -r1.139 -r1.140 pkgsrc/www/seamonkey/distinfo
 cvs rdiff -u -r1.6 -r1.7 \
     pkgsrc/www/seamonkey/patches/patch-mozilla_media_libcubeb_src_cubeb__alsa.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

Responsible-Changed-From-To: pkg-manager->maya
Responsible-Changed-By: maya@NetBSD.org
Responsible-Changed-When: Wed, 07 Dec 2016 22:09:14 +0000
Responsible-Changed-Why:
Mine


State-Changed-From-To: open->closed
State-Changed-By: maya@NetBSD.org
State-Changed-When: Wed, 07 Dec 2016 22:09:14 +0000
State-Changed-Why:
Works For Me (TM). let me know if I'm wrong.


From: coypu@SDF.ORG
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/51666: www/seamonkey with also audio wants EBADFD (from
 patch)
Date: Wed, 7 Dec 2016 22:05:47 +0000

 I've committed the change.

 Note www/firefox is where we keep the shiniest (and
 working) versions of our mozilla-cubeb-patches. So
 if audio is not working or is annoying, a fix is
 likely there.

>Unformatted:

Home	PR Database Search